Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2026-10-03 10:13:47 +10:00
Code Issues Packages Projects Releases Wiki Activity

docs: record plan 02 hosted fix review

Browse Source
This commit is contained in:
Amruth Pillai
2026-09-06 01:40:50 +02:00
parent b9da6ed587
commit 02b53ee3d2
2 changed files with 30 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/execution/approved-issue-plans-ledger.md
+3 -2
View File
@@ -34,7 +34,7 @@ state changes are outside scope.
| Unit | Issues | Status / current validity | Owner | Worktree / branch | Base → head | Dependencies | Evidence | Tests | PR | Next action | Blockers |
| --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- |
| 01 account login/recovery | #3166, #3164, #3078, #3046, #2897, #2837 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | none | zero drift; live issues remain split; #3046/#3078 have merged #3095 candidate only | auth 42, email 6, focused/full API/server suites and affected typechecks/boundaries passed in audit | — | select exact auth/mail/API boundary only after current sanitized trace | current cloud digest, provider/account method, request/status trace, controlled mailbox |
| 02 hosted v4 recovery | #3181, #2760 | published; hosted fix active | fix `task_1d56264e5f15` / `ctx_2a1a0a6af73e` | `codex/issue-3181-recovery-procedure` | `7a98f6662` → `6c4743935` | #2760 identity branch depends on 01 evidence | independent adjudication confirmed Unicode format-character ID gap; bot cleanup safe; scanner extraction and relaxed canonicalization rejected with evidence | exact bot-head E2E/all checks green; 59/54/21 local tests and gates green before valid Cf finding | [#3460](https://github.com/amruthpillai/reactive-resume/pull/3460) | reject/document Cf IDs via TDD, rereview, push, reply/resolve four threads | real recovery still needs verified owner, snapshot, mapping, private delivery |
| 02 hosted v4 recovery | #3181, #2760 | published; hosted fix rereviewing | review `task_51b92554b36b` / `ctx_08bc7a78dd61` | `codex/issue-3181-recovery-procedure` | `7a98f6662` → `325d1fcd1` local | #2760 identity branch depends on 01 evidence | Unicode format-character IDs now rejected across all manifest fields; bot cleanup preserved; scanner extraction and relaxed canonicalization rejected with evidence | 83 comparator, 54 API, 21 auth tests, affected typechecks, boundaries, lint/import/diff/scope gates green; independent rereview active | [#3460](https://github.com/amruthpillai/reactive-resume/pull/3460) | if rereview clean, fresh verify, push, reply/resolve four hosted threads | real recovery still needs verified owner, snapshot, mapping, private delivery |
| 03 MCP registration | #3398, #3153 | no-change | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | coordinate DB/startup with 05 | merged #3421 (`fe9b59e`) present on main; current schema/startup/auth contracts match plan | #3421 hosted checks successful; audit auth/server/API/DB tests, typechecks, boundaries passed | #3421 merged before run | deployment verification only | deployed digest/log correlation and exact Codex/Claude DCR/consent/PKCE/MCP retest unavailable |
| 04 AI provider compatibility | #2732, #2766, #2723, #2708 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | serialize edits to AI service | zero drift; historical #2708 Responses path and #2766 structured Test path absent; remaining tuples differ | focused API 96 and full API suites/typecheck/boundaries passed in audit | — | select wire/state/import/base-path unit only after exact current tuple fails | provider/model/base URL/path/version/action/error tuple and allowed endpoint unavailable |
| 05 AI provider migrations | #3152 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | coordinate DB/startup with 03 | zero drift; table schema, migration, startup ordering, Docker copy path coherent; `42P01` historical cause unresolved | audit API/server/DB tests, typechecks, boundaries passed; no real PostgreSQL migration fixture | — | choose config/packaging/startup/migration repair only after disposable reproduction | affected image layout/digest, working directory, DB schema/search path/journal, fresh+upgrade DB fixture |
@@ -96,7 +96,8 @@ state changes are outside scope.
| Plan 02 hardening round 4 | `task_5b56f07b5a2c` / `ctx_e7c63529b719` | same Plan 02 worktree | complete; worker released | commit `4125074f9`; 59 comparator tests plus duplicate-member and unsafe-ID adversarial gates green |
| Plan 02 independent review round 5 | `task_a2b0562df7aa` / `ctx_bc5056c8978c` | same Plan 02 worktree | complete; no findings; pushed; worker released | exact head `4125074f9`; full diff, 54 independent assertions, fresh coordinator verification, PR #3460 |
| Plan 02 autofix review | `task_796f15a35422` / `ctx_c581be24021a` | same Plan 02 worktree | complete; changes required; worker released | bot export cleanup safe; valid P2 Unicode Cf ID gap; three Codacy suggestions rejected/already satisfied with evidence |
| Plan 02 hosted review fix | `task_1d56264e5f15` / `ctx_2a1a0a6af73e` | same Plan 02 worktree | implementing | reject and document Unicode format-character IDs, add all-field regressions, preserve strict comparator contract |
| Plan 02 hosted review fix | `task_1d56264e5f15` / `ctx_2a1a0a6af73e` | same Plan 02 worktree | complete; worker released | commit `325d1fcd1`; reject and document Unicode format-character IDs, add all-field regressions, preserve strict comparator contract |
| Plan 02 hosted fix rereview | `task_51b92554b36b` / `ctx_08bc7a78dd61` | same Plan 02 worktree | reviewing | full diff and all four hosted dispositions at exact local head `325d1fcd1`; no GitHub mutation |
| Plan 09 re-review | `task_1bd82b008a77` / `ctx_ca2a0176b52f` | same Plan 09 worktree | complete; no findings; worker released | full diff and both factual corrections verified before PR #3458 |
| Plan 09 hosted review follow-up | `task_a44e374822b4` / `ctx_89e6769df19d` | same Plan 09 worktree | complete; changes required; worker released | selected revision prints correctly but no importable file is created |
| Plan 09 hosted review fix round 2 | `task_8605c30ca032` / `ctx_2e0aa7be1312` | same Plan 09 worktree | complete; worker released | commit `9dd218ba1`; non-destructive recovered-file command plus synthetic proof |
docs/execution/briefs/rereview-plan-02-hosted.md
+27
View File
@@ -0,0 +1,27 @@
# Independent rereview: Plan 02 hosted feedback fix
Review only in `/Users/amruth/orca/workspaces/reactive-resume/issue-3181-recovery-procedure`.
Exact target head: `325d1fcd1e2ea3744896c1688c6f6c0bfc3dd5ce`. Do not edit tracked files, commit, push, reply,
resolve threads, publish, merge, or mutate issues.
Read current repository instructions, pinned approved Plan 02, prior review reports, hosted-review fix report, full
`origin/main...HEAD` diff, live PR #3460, and all four unresolved hosted threads. Refresh base and verify exact head.
Run root Intent inventory and load matching review skill if any; no subagents.
Review Standards and Spec independently. Verify especially:
- `caseId`, `sourceResumeId`, and non-null `targetResumeId` reject all Unicode control (`Cc`) and format (`Cf`)
characters, including embedded and format-only U+200B, U+2066, U+202E, and U+FEFF values;
- safe accepted identifiers remain byte-preserving and unnormalized;
- strict current-v5 canonical equality and duplicate-member scanner remain fail-closed;
- autofix cleanup is retained and no scope expansion or contract weakening occurred;
- migration guidance exactly matches executable validation and does not imply raw-v4 conversion or real recovery;
- Codacy scanner-complexity and scanner-coverage comments are non-actionable or already satisfied, and relaxing
canonical equality would violate approved direction;
- all 83 comparator cases and independent adversarial probes are mutation-sensitive enough to catch removal or partial
application of the `Cf` guard.
Run focused comparator/API/auth tests, affected typechecks, boundaries, narrow non-writing Biome/Markdown lint,
static-import, diff/base/scope gates, and any small independent probes needed. Report findings first with severity and
anchors, publication verdict, exact head, and hosted-thread disposition in `.orchestration/plan-02-hosted-rereview.md`;
send `worker_done`.