docs: record plan 15a review findings

This commit is contained in:
Amruth Pillai
2026-09-06 00:57:12 +02:00
parent 7cea541aef
commit 036829a8c7
@@ -47,7 +47,7 @@ state changes are outside scope.
| 12 preview/export failures | #3323, #3290, #3033, #3007, #2609 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer ownership; share observation harness with 18 | zero drift; staged-preview/error-boundary baselines remain; reports cross persistence/font/PDF/viewer/deployment boundaries | audit focused web/PDF suites, affected typechecks, boundaries, build passed | — | isolate PT Sans, browser/config, and template-selection boundaries; no shared fix | exact JSON/output/browser/config/current reproduction missing |
| 13 font/glyph/spacing | #3249, #3159, #3147, #3093, #3089, #2988 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize font sources with 14/27 | merged metrics/cache/Unicode fixes present and passing; residuals require per-font/per-symptom fixtures | audit focused PDF/font suites, affected typechecks, boundaries, build passed | — | retain regressions; create residual unit only from exact failing font fixture | missing Ropa Sans/source strings/font hashes/before-after artifacts |
| 14 RTL export layout | #3275 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize renderer/fonts with 13/27 | merged canvas-direction fix remains; broader shaping/bidi cause unproved | audit RTL/preview suites, affected typechecks, boundaries, build passed | — | run controlled same-bytes export matrix against approved shaping oracle | exact JSON/font/version and known-good reference absent |
| 15 picture fitting/style | #3168, #3088, #2794, #2782 | reviewing 15A; other causes blocked | review `task_d4f4841355e2` / `ctx_467f293cf443` | `codex/issue-2782-picture-fit` | `7a98f6662` → `d891afd66` | coordinate 06/25; schema/PDF owner exclusion | explicit Cover/Contain across schema, import, builder, shared PDF, docs/catalogs and raster E2E committed | full repo tests; schema/web/PDF/import suites; typechecks/boundaries/build; 2 authenticated raster E2E green; independent review active | — | resolve findings or publish after clean review/fresh verification | delivery/centering issues still lack source revisions/assets/expected crop |
| 15 picture fitting/style | #3168, #3088, #2794, #2782 | fixing 15A review findings; other causes blocked | fix `task_5a4afecb7d0d` / `ctx_43faac4f25eb` | `codex/issue-2782-picture-fit` | `7a98f6662` → `d891afd66` | coordinate 06/25; schema/PDF owner exclusion | runtime Cover/Contain behavior passed review; geometry regression was too weak and UI tests coupled to Tailwind class | full repo tests; focused suites/typechecks/boundaries/build; 2 authenticated raster E2E green before test-strength finding | — | pin Cover/Contain geometry and behavioral CSS assertions, deduplicate props, then rereview | delivery/centering issues still lack source revisions/assets/expected crop |
| 16 imported table borders | #3196 | pending implementation | unassigned | planned `codex/issue-3196-editable-tables` | `7a98f6662` → — | rich-text owner; must precede 19/31 | editor lacks table extensions; Q11 approves editable supported tables; atomic editor/HTML/PDF unit ready | audit current table/rich-input regressions, affected typechecks, boundaries, build passed | — | implement via TDD, including persistence, undo/redo, borders, and lossless unsupported fallback | historical visual equivalence lacks reporter HTML/JSON but feature contract is approved |
| 17 list/skill pagination | #2751, #3040 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer owner shared with 13/14/18 | merged ordered-marker/wrap/level-gap fixes present; current residual not reproduced | audit focused PDF suites, typecheck, boundaries, build passed | — | retain controls; add fix only from exact failing list/skill fixture | #2751 source absent; #3040 current fixture no longer proves residual clipping |
| 18 preview/export geometry | #2683 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | share output-boundary harness with 12; viewer owner exclusion | current viewport/page-size/margin baselines pass; video alone cannot locate cause | audit page/preview tests, affected typechecks, boundaries, build passed | — | compare identical preview/download bytes, MediaBoxes, ink bounds, viewport, DPR | exact JSON/PDF/browser/DPR/zoom/page settings absent |
@@ -105,7 +105,8 @@ state changes are outside scope.
| Plan 11 re-review | `task_86a66b578544` / `ctx_3bb8017e8676` | same Plan 11 worktree | complete; no findings; worker released | exact head `e05977007`; 52 focused tests and full diff verified before PR #3459 |
| Plan 11 hosted review follow-up | `task_a9d8b3e0a8a2` / `ctx_6b03ba8f389c` | same Plan 11 worktree | no findings; pushed; worker released | commit `1d03978`; sample wording plus heading/UI terminology alignment; all hosted checks green and both threads resolved |
| Plan 15A implementation | `task_557902c8adef` / `ctx_db6fae1b75c4` | `codex/issue-2782-picture-fit` | complete; worker released | commit `d891afd66`; explicit cover/contain contract across schema/editor/preview/PDF |
| Plan 15A independent review | `task_d4f4841355e2` / `ctx_467f293cf443` | same Plan 15A worktree | reviewing | full 70-file diff, raster/E2E reliability, schema/import/UI/PDF compatibility |
| Plan 15A independent review | `task_d4f4841355e2` / `ctx_467f293cf443` | same Plan 15A worktree | complete; changes required; worker released | medium: raster checks did not pin fit geometry; low: class coupling and duplicate props type |
| Plan 15A review fix | `task_5a4afecb7d0d` / `ctx_43faac4f25eb` | same Plan 15A worktree | implementing | strengthen Cover/Contain geometry and behavioral assertions, consolidate props type, rerun raster E2E |
| Plan 07 hosted review follow-up | `task_6e9bc84ca2d4` / `ctx_e31d0e345240` | `codex/issue-2722-postgres-docs` | no findings; pushed; worker released | commit `a7b8c4c`; five valid comments fixed, `--no-deps` removal rejected; six replies and zero unresolved threads |
## Existing PR and residual accounting