From 5a2c222d612ddba4d7befaf3288c8df938b09044 Mon Sep 17 00:00:00 2001
From: Zsombor Gegesy <gzsombor@gmail.com>
Date: Sat, 24 Feb 2024 12:47:41 +0100
Subject: [PATCH 1/3] Better error handling and more lenient on the imported
 values

---
 .../src/pages/dashboard/resumes/_dialogs/import.tsx      | 2 +-
 libs/parser/src/linkedin/index.ts                        | 9 ++++++---
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/apps/client/src/pages/dashboard/resumes/_dialogs/import.tsx b/apps/client/src/pages/dashboard/resumes/_dialogs/import.tsx
index 665e43a4..9c2fabaf 100644
--- a/apps/client/src/pages/dashboard/resumes/_dialogs/import.tsx
+++ b/apps/client/src/pages/dashboard/resumes/_dialogs/import.tsx
@@ -186,7 +186,7 @@ export const ImportDialog = () => {
       toast({
         variant: "error",
         title: t`Oops, the server returned an error.`,
-        description: importError?.message,
+        description: error?.message,
       });
     }
   };
diff --git a/libs/parser/src/linkedin/index.ts b/libs/parser/src/linkedin/index.ts
index 7686b3fc..631d0e62 100644
--- a/libs/parser/src/linkedin/index.ts
+++ b/libs/parser/src/linkedin/index.ts
@@ -55,6 +55,9 @@ export class LinkedInParser implements Parser<JSZip, LinkedIn> {
 
   convert(data: LinkedIn) {
     const result = JSON.parse(JSON.stringify(defaultResumeData)) as ResumeData;
+    function avoidToShort(name, len) {
+      if (!name || name.length<len) { return "Unknown" } else { return name; }
+    };
 
     // Profile
     if (data.Profile && data.Profile.length > 0) {
@@ -109,9 +112,9 @@ export class LinkedInParser implements Parser<JSZip, LinkedIn> {
         result.sections.education.items.push({
           ...defaultEducation,
           id: createId(),
-          institution: education["School Name"],
-          studyType: education["Degree Name"],
-          summary: education.Notes ?? "",
+          institution: avoidToShort(education["School Name"], 2),
+          studyType: avoidToShort(education["Degree Name"], 2),
+          summary: avoidToShort(education.Notes ?? "", 2),
           date: `${education["Start Date"]} - ${education["End Date"] ?? "Present"}`,
         });
       }

From befc5a67fc7600158d859cfb20dc0fbc1333e1fb Mon Sep 17 00:00:00 2001
From: Zsombor Gegesy <gzsombor@gmail.com>
Date: Mon, 26 Feb 2024 00:10:18 +0100
Subject: [PATCH 2/3] Format code, better function name

---
 libs/parser/src/linkedin/index.ts | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/libs/parser/src/linkedin/index.ts b/libs/parser/src/linkedin/index.ts
index 631d0e62..3e0254f4 100644
--- a/libs/parser/src/linkedin/index.ts
+++ b/libs/parser/src/linkedin/index.ts
@@ -55,8 +55,12 @@ export class LinkedInParser implements Parser<JSZip, LinkedIn> {
 
   convert(data: LinkedIn) {
     const result = JSON.parse(JSON.stringify(defaultResumeData)) as ResumeData;
-    function avoidToShort(name, len) {
-      if (!name || name.length<len) { return "Unknown" } else { return name; }
+    function avoidTooShort(name, len) {
+      if (!name || name.length<len) {
+        return "Unknown";
+      } else {
+        return name;
+      }
     };
 
     // Profile
@@ -112,9 +116,9 @@ export class LinkedInParser implements Parser<JSZip, LinkedIn> {
         result.sections.education.items.push({
           ...defaultEducation,
           id: createId(),
-          institution: avoidToShort(education["School Name"], 2),
-          studyType: avoidToShort(education["Degree Name"], 2),
-          summary: avoidToShort(education.Notes ?? "", 2),
+          institution: avoidTooShort(education["School Name"], 2),
+          studyType: avoidTooShort(education["Degree Name"], 2),
+          summary: avoidTooShort(education.Notes ?? "", 2),
           date: `${education["Start Date"]} - ${education["End Date"] ?? "Present"}`,
         });
       }

From 71d3cea1003318f722d8f9b02518018cc1d7271c Mon Sep 17 00:00:00 2001
From: Zsombor Gegesy <gzsombor@gmail.com>
Date: Sat, 9 Mar 2024 12:33:49 +0100
Subject: [PATCH 3/3] Fix build

---
 apps/client/src/pages/dashboard/resumes/_dialogs/import.tsx | 4 ++--
 libs/parser/src/linkedin/index.ts                           | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/apps/client/src/pages/dashboard/resumes/_dialogs/import.tsx b/apps/client/src/pages/dashboard/resumes/_dialogs/import.tsx
index 9c2fabaf..21189963 100644
--- a/apps/client/src/pages/dashboard/resumes/_dialogs/import.tsx
+++ b/apps/client/src/pages/dashboard/resumes/_dialogs/import.tsx
@@ -182,11 +182,11 @@ export const ImportDialog = () => {
       }
 
       close();
-    } catch (error) {
+    } catch (error: any) {
       toast({
         variant: "error",
         title: t`Oops, the server returned an error.`,
-        description: error?.message,
+        description: error["message"],
       });
     }
   };
diff --git a/libs/parser/src/linkedin/index.ts b/libs/parser/src/linkedin/index.ts
index 3e0254f4..e4aff8cf 100644
--- a/libs/parser/src/linkedin/index.ts
+++ b/libs/parser/src/linkedin/index.ts
@@ -55,7 +55,7 @@ export class LinkedInParser implements Parser<JSZip, LinkedIn> {
 
   convert(data: LinkedIn) {
     const result = JSON.parse(JSON.stringify(defaultResumeData)) as ResumeData;
-    function avoidTooShort(name, len) {
+    function avoidTooShort(name: string, len: number) {
       if (!name || name.length<len) {
         return "Unknown";
       } else {