Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2025-11-13 00:03:27 +10:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1790 from gzsombor/import-fixes

Browse Source 
Better error handling and more lenient on the imported values
This commit is contained in:
Amruth Pillai
2024-03-10 10:23:58 +01:00
committed by GitHub
parent 995b1e627b 71d3cea100
commit 10b2ca8bf2
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/client/src/pages/dashboard/resumes/_dialogs/import.tsx
View File

@ -182,11 +182,11 @@ export const ImportDialog = () => {
} }
close(); close();
} catch (error) { } catch (error: any) {
toast({ toast({
variant: "error", variant: "error",
title: t`Oops, the server returned an error.`, title: t`Oops, the server returned an error.`,
description: importError?.message, description: error["message"],
}); });
} }
}; };

13
libs/parser/src/linkedin/index.ts
View File

@ -55,6 +55,13 @@ export class LinkedInParser implements Parser<JSZip, LinkedIn> {
convert(data: LinkedIn) { convert(data: LinkedIn) {
const result = JSON.parse(JSON.stringify(defaultResumeData)) as ResumeData; const result = JSON.parse(JSON.stringify(defaultResumeData)) as ResumeData;
function avoidTooShort(name: string, len: number) {
if (!name || name.length<len) {
return "Unknown";
} else {
return name;
}
};
// Profile // Profile
if (data.Profile && data.Profile.length > 0) { if (data.Profile && data.Profile.length > 0) {
@ -109,9 +116,9 @@ export class LinkedInParser implements Parser<JSZip, LinkedIn> {
result.sections.education.items.push({ result.sections.education.items.push({
...defaultEducation, ...defaultEducation,
id: createId(), id: createId(),
institution: education["School Name"], institution: avoidTooShort(education["School Name"], 2),
studyType: education["Degree Name"], studyType: avoidTooShort(education["Degree Name"], 2),
summary: education.Notes ?? "", summary: avoidTooShort(education.Notes ?? "", 2),
date: `${education["Start Date"]} - ${education["End Date"] ?? "Present"}`, date: `${education["Start Date"]} - ${education["End Date"] ?? "Present"}`,
}); });
} }