From 1106562169a8135f82bb11d801a4f4f230917a61 Mon Sep 17 00:00:00 2001 From: Amruth Pillai Date: Wed, 9 Sep 2026 12:33:04 +0200 Subject: [PATCH] test(pdf): refresh Lapras date-layout baseline and run all packages in CI The Lapras section marginTop added in c0c658c0 shifted every date marker in that template down the page, but the date-layout characterization baseline was not regenerated, so packages/pdf has been failing on main since. The delta is geometry-only: same page count (2), same text item count (87), same markers, x and width unchanged; 17 markers move on y and the raster hashes follow. Nothing caught it because the workflow ran test:ci for only server and tooling, leaving 17 packages uncovered. Replace that filter list with the full workspace run so a package cannot silently lose coverage again, and move it after the migration and storage steps that the api suite needs. Serial execution is deliberate. Running the packages in parallel oversubscribes the runner and starves the PDF rasterization and API rate-limit suites past their timeouts; 19/19 pass consistently at --concurrency=1. --- .github/workflows/e2e.yml | 10 +++-- .../date-layout/all-templates.json | 38 +++++++++---------- 2 files changed, 26 insertions(+), 22 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 9da613ad2..dac1f65ac 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -56,9 +56,6 @@ jobs: - name: Install Dependencies run: pnpm install --frozen-lockfile - - name: Run Server and Tooling Tests - run: pnpm exec turbo run test:ci --filter=server --filter=@reactive-resume/tooling - - name: Install Playwright Browser run: pnpm exec playwright install --with-deps chromium @@ -73,6 +70,13 @@ jobs: - name: Run Database Migrations run: pnpm db:migrate + # Runs every workspace package, not a hand-maintained filter list, so a package + # cannot silently lose coverage by being left out. Serial execution: the PDF + # rasterization and API rate-limit suites time out when several packages' Vitest + # thread pools oversubscribe the runner at once. + - name: Run Unit Tests + run: pnpm exec turbo run test:ci --concurrency=1 + - name: Build run: pnpm build diff --git a/packages/pdf/test-artifacts/date-layout/all-templates.json b/packages/pdf/test-artifacts/date-layout/all-templates.json index 19dfc3937..79cfe8ebb 100644 --- a/packages/pdf/test-artifacts/date-layout/all-templates.json +++ b/packages/pdf/test-artifacts/date-layout/all-templates.json @@ -1180,14 +1180,14 @@ "textItemCount": 87, "missingMarkers": [], "rasterSha256": [ - "56eea42ffab93d25e038b1fd411e708cc07c377f350a67cb55bcb6423d50ff49", - "68d02d2741097a226889dd396ebbc08c30d03554a667da7dbc08453def126470" + "54d382f203128256e6c4d835cab6f402a1ebef2cceae905512f765a05448957a", + "609d3a23775f7000b77c4110d5537fb1e2b03513803b9c2f94b5ba0f673e59db" ], "coordinates": { "EXP_LONG": [ { "x": 376.24, - "y": 708.24, + "y": 692.24, "width": 186.04, "text": "März 2018 – Dezember 2024 EXP_LONG" } @@ -1195,7 +1195,7 @@ "EXP_NO_LOCATION": [ { "x": 441.21, - "y": 624.24, + "y": 608.24, "width": 121.07, "text": "2016 EXP_NO_LOCATION" } @@ -1203,7 +1203,7 @@ "ROLE_ONE": [ { "x": 483, - "y": 692.49, + "y": 676.49, "width": 79.28, "text": "2020 ROLE_ONE" } @@ -1211,7 +1211,7 @@ "ROLE_TWO": [ { "x": 481.54, - "y": 660.99, + "y": 644.99, "width": 80.74, "text": "2022 ROLE_TWO" } @@ -1219,7 +1219,7 @@ "EXP_NO_PERIOD": [ { "x": 454.47, - "y": 587.49, + "y": 571.49, "width": 107.81, "text": "Oslo EXP_NO_PERIOD" } @@ -1227,7 +1227,7 @@ "EDU_DATE": [ { "x": 411.99, - "y": 519.49, + "y": 487.49, "width": 150.29, "text": "Education City • 2019 EDU_DATE" } @@ -1235,7 +1235,7 @@ "PROJECT_DATE": [ { "x": 460.16, - "y": 446.24, + "y": 398.24, "width": 102.12, "text": "2020 PROJECT_DATE" } @@ -1243,7 +1243,7 @@ "AWARD_DATE": [ { "x": 470.41, - "y": 393.99, + "y": 329.99, "width": 91.87, "text": "2021 AWARD_DATE" } @@ -1251,7 +1251,7 @@ "CERT_DATE": [ { "x": 479.71, - "y": 325.99, + "y": 245.99, "width": 82.57, "text": "2022 CERT_DATE" } @@ -1259,7 +1259,7 @@ "VOLUNTEER_DATE": [ { "x": 445.91, - "y": 189.99, + "y": 77.99, "width": 116.37, "text": "2023 VOLUNTEER_DATE" } @@ -1267,7 +1267,7 @@ "CUSTOM_EXP_DATE": [ { "x": 438.13, - "y": 106.24, + "y": 773.64, "width": 124.15, "text": "2024 CUSTOM_EXP_DATE" } @@ -1275,7 +1275,7 @@ "CUSTOM_ROLE_DATE": [ { "x": 431.11, - "y": 90.49, + "y": 757.89, "width": 131.17, "text": "2024 CUSTOM_ROLE_DATE" } @@ -1283,7 +1283,7 @@ "CUSTOM_EDU_DATE": [ { "x": 363.5, - "y": 38.24, + "y": 689.64, "width": 198.78, "text": "Education City • 2024 CUSTOM_EDU_DATE" } @@ -1291,7 +1291,7 @@ "CUSTOM_PROJECT_DATE": [ { "x": 411.67, - "y": 776.39, + "y": 621.39, "width": 150.61, "text": "2024 CUSTOM_PROJECT_DATE" } @@ -1299,7 +1299,7 @@ "CUSTOM_AWARD_DATE": [ { "x": 421.92, - "y": 724.14, + "y": 553.14, "width": 140.36, "text": "2024 CUSTOM_AWARD_DATE" } @@ -1307,7 +1307,7 @@ "CUSTOM_CERT_DATE": [ { "x": 431.22, - "y": 656.14, + "y": 469.14, "width": 131.06, "text": "2024 CUSTOM_CERT_DATE" } @@ -1315,7 +1315,7 @@ "CUSTOM_VOLUNTEER_DATE": [ { "x": 397.42, - "y": 520.14, + "y": 301.14, "width": 164.86, "text": "2024 CUSTOM_VOLUNTEER_DATE" }