From 156f24063efb8fdb584785edc3f7b3297b2f06f8 Mon Sep 17 00:00:00 2001 From: Amruth Pillai Date: Sun, 6 Sep 2026 00:15:59 +0200 Subject: [PATCH] docs: queue clean plan 11 rereview --- docs/execution/approved-issue-plans-ledger.md | 7 ++++--- docs/execution/briefs/rereview-plan-11.md | 15 +++++++++++++++ 2 files changed, 19 insertions(+), 3 deletions(-) create mode 100644 docs/execution/briefs/rereview-plan-11.md diff --git a/docs/execution/approved-issue-plans-ledger.md b/docs/execution/approved-issue-plans-ledger.md index 26b4e91fa..37509ccd0 100644 --- a/docs/execution/approved-issue-plans-ledger.md +++ b/docs/execution/approved-issue-plans-ledger.md @@ -43,7 +43,7 @@ state changes are outside scope. | 08 root public resume | #2669 | plan amendment required before implementation | audit `task_9f27829ca50f` | planned `codex/issue-2669-root-resume` | `7a98f6662` → — | none | current password redirect rejects `/`; public view is slug-hook-bound; SSR canonical cannot import server env; expanded auth/canonical contract identified | audit focused API/web suites, typechecks, boundaries passed | — | amend ownership for identity-vs-return auth flow and server-derived canonical root, then dispatch coherent feature | engineering scope correction; feature remains narrower than arbitrary domain/TLS registry | | 09 external version backup | #2705 | published | implementation/review chain complete | `codex/issue-2705-git-backup-docs` | `7a98f6662` → `6931d2cc4` | none | JSON cover-letter scope and throttled template snapshot wording corrected; clean independent re-review | fresh 152 focused tests, Markdown/diff/exact-base/scope green | [#3458](https://github.com/amruthpillai/reactive-resume/pull/3458) | monitor hosted checks/review; keep unmerged | DB integration/E2E unavailable; no sync/remote/whole-account restore | | 10 legacy link routing | #2836 | pending implementation after brief correction | audit `task_9f27829ca50f` | planned `codex/issue-2836-retired-slug-notices` | `7a98f6662` → — | none | prospective same-username slug-attempt notice remains coherent; exact DB/API/UI/E2E owner set verified | audit focused API/web suites, DB/API/web typechecks, boundaries passed | — | correct final E2E target to `public-sharing.spec.ts`, then implement migration/API/owner UI atomically | historical cause absent; no redirects/emails/recovery; prospective partial coverage only | -| 11 job search policy | #3010 | implementing review correction | fix `task_351a96e90b69` / `ctx_e398c9128731` | `codex/issue-3010-jsearch-docs` | `7a98f6662` → `cb011841c` | none | review found unqualified attachment promise and adjacent restore-guidance duplication; bounded docs fix active | implementation tests/Markdown/diff/scope green; rerun after fix | — | clean re-review, fresh verify, publish unmerged PR | real provider/browser optional gate unavailable; removal motive unknown | +| 11 job search policy | #3010 | pending clean re-review | fix complete `task_351a96e90b69`; review queued `task_86a66b578544` | `codex/issue-3010-jsearch-docs` | `7a98f6662` → `e05977007` | none | attachment overclaim removed and restore guidance deduplicated in follow-up commit | Markdown/link/diff/scope green; independent re-review next | — | clean re-review, fresh verify, publish unmerged PR | real provider/browser optional gate unavailable; removal motive unknown | | 12 preview/export failures | #3323, #3290, #3033, #3007, #2609 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer ownership; share observation harness with 18 | zero drift; staged-preview/error-boundary baselines remain; reports cross persistence/font/PDF/viewer/deployment boundaries | audit focused web/PDF suites, affected typechecks, boundaries, build passed | — | isolate PT Sans, browser/config, and template-selection boundaries; no shared fix | exact JSON/output/browser/config/current reproduction missing | | 13 font/glyph/spacing | #3249, #3159, #3147, #3093, #3089, #2988 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize font sources with 14/27 | merged metrics/cache/Unicode fixes present and passing; residuals require per-font/per-symptom fixtures | audit focused PDF/font suites, affected typechecks, boundaries, build passed | — | retain regressions; create residual unit only from exact failing font fixture | missing Ropa Sans/source strings/font hashes/before-after artifacts | | 14 RTL export layout | #3275 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize renderer/fonts with 13/27 | merged canvas-direction fix remains; broader shaping/bidi cause unproved | audit RTL/preview suites, affected typechecks, boundaries, build passed | — | run controlled same-bytes export matrix against approved shaping oracle | exact JSON/font/version and known-good reference absent | @@ -92,9 +92,10 @@ state changes are outside scope. | Plan 02 second review fix | `task_eb3b8c09aef2` / `ctx_3d3e5f7d2496` | same Plan 02 worktree | implementing | original-form object validation plus boxed-string/custom-`toJSON` regressions | | Plan 09 re-review | `task_1bd82b008a77` / `ctx_ca2a0176b52f` | same Plan 09 worktree | complete; no findings; worker released | full diff and both factual corrections verified before PR #3458 | | Plan 11 independent review | `task_7d5d4c1417a9` / `ctx_17ee05faf9e7` | same Plan 11 worktree | complete; changes required | attachment-format overclaim and duplicated patch/restore guidance | -| Plan 11 review fix | `task_351a96e90b69` / `ctx_e398c9128731` | same Plan 11 worktree | implementing | qualify workflow and remove adjacent duplication | +| Plan 11 review fix | `task_351a96e90b69` / `ctx_e398c9128731` | same Plan 11 worktree | complete; worker released | commit `e05977007`; attachment promise removed and adjacent guidance deduplicated | +| Plan 11 re-review | `task_86a66b578544` | same Plan 11 worktree | ready; awaiting slot | full fixed diff and both prior findings | | Plan 15A implementation | `task_557902c8adef` / `ctx_db6fae1b75c4` | `codex/issue-2782-picture-fit` | implementing | explicit cover/contain contract across schema/editor/preview/PDF | -| Plan 07 hosted review follow-up | coordinator | `codex/issue-2722-postgres-docs` | fix committed; re-review pending | commit `a7b8c4c`; quickstart major pin, exact image/build update paths, host-port warning, verified-TLS guidance | +| Plan 07 hosted review follow-up | `task_6e9bc84ca2d4` / `ctx_e31d0e345240` | `codex/issue-2722-postgres-docs` | independent re-review active | commit `a7b8c4c`; quickstart major pin, exact image/build update paths, host-port warning, verified-TLS guidance | ## Existing PR and residual accounting diff --git a/docs/execution/briefs/rereview-plan-11.md b/docs/execution/briefs/rereview-plan-11.md new file mode 100644 index 000000000..5ff04b3d4 --- /dev/null +++ b/docs/execution/briefs/rereview-plan-11.md @@ -0,0 +1,15 @@ +# Independently re-review plan 11 after corrections + +Review only. Read pinned approved plan 11, current `AGENTS.md`, RTK, applicable code-review skill, +`.orchestration/plan-11-review.md`, and `.orchestration/plan-11-review-fix.md`. Review complete `origin/main...HEAD` diff, +not only follow-up commit. + +Verify both prior findings are fully resolved: changelog no longer promises arbitrary attachment-based tailoring, and +workflow no longer duplicates adjacent patch review/restore/rollback guidance. Revalidate history, redirect, provider +capability boundary, supported supplied-description paths, isolated AI Draft behavior, patch review/restore semantics, +three-doc scope, and absence of invented removal motive or JSearch restoration promise. + +Run fresh fetch/base and live issue/PR state checks, source probes, relevant focused tests, Markdown lint, link/diff/scope +gates. Write `.orchestration/plan-11-rereview.md` with findings first, exact head, commands/results, skipped gates, risks, +and publication verdict. Do not edit tracked files, push, open PR, merge, mutate issues, or spawn subagents. Final response +at most ten lines.