diff --git a/docs/execution/approved-issue-plans-ledger.md b/docs/execution/approved-issue-plans-ledger.md index cbfd4e2b1..5290e4c9e 100644 --- a/docs/execution/approved-issue-plans-ledger.md +++ b/docs/execution/approved-issue-plans-ledger.md @@ -39,7 +39,7 @@ state changes are outside scope. | 04 AI provider compatibility | #2732, #2766, #2723, #2708 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | serialize edits to AI service | zero drift; historical #2708 Responses path and #2766 structured Test path absent; remaining tuples differ | focused API 96 and full API suites/typecheck/boundaries passed in audit | — | select wire/state/import/base-path unit only after exact current tuple fails | provider/model/base URL/path/version/action/error tuple and allowed endpoint unavailable | | 05 AI provider migrations | #3152 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | coordinate DB/startup with 03 | zero drift; table schema, migration, startup ordering, Docker copy path coherent; `42P01` historical cause unresolved | audit API/server/DB tests, typechecks, boundaries passed; no real PostgreSQL migration fixture | — | choose config/packaging/startup/migration repair only after disposable reproduction | affected image layout/digest, working directory, DB schema/search path/journal, fresh+upgrade DB fixture | | 06 image storage delivery | #2684, #2778 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | coordinate 12/15/25 renderer/image fixtures | #2684 ACL cause fixed by merged #3432 (`35cecf9`); #2778 Browserless path obsolete; current topology unproved | #3432 hosted checks successful; audit storage/upload/PDF tests, typechecks, boundaries passed | #3432 merged before run | deployment retest plus shared real-encoding/backend/render fixture before repair | deployed digest; disposable S3/Garage/SeaweedFS/MinIO/proxy and browser/server raster matrix unavailable | -| 07 AIO deployment | #2722 | published; late hosted fix active | fix `task_6d0545ee43b1` / `ctx_1d6a1e36def3` | `codex/issue-2722-postgres-docs` | `7a98f6662` → `a7b8c4cc5` | none | late Greptile thread correctly notes repository-build users can reach image-service log command after taking alternative update path | existing head checks green/approved; one new unresolved thread under bounded fix | [#3457](https://github.com/amruthpillai/reactive-resume/pull/3457) | add adjacent `reactive_resume` log path, verify, independently rereview, then push/reply/resolve | no AIO implementation; optional Unraid host smoke unavailable | +| 07 AIO deployment | #2722 | published; late hosted fix awaiting review | queued review `task_8ff818f3e95a` | `codex/issue-2722-postgres-docs` | `7a98f6662` → published `a7b8c4cc5`; local `171637526` | none | image and repository update flows now separate through correct `reactive-resume`/`reactive_resume` log commands | Compose configs/dry-runs, DB, Markdown/link/command/diff/scope green after fix | [#3457](https://github.com/amruthpillai/reactive-resume/pull/3457) | independently rereview, then push/reply/resolve late thread | no AIO implementation; optional Unraid host smoke unavailable | | 08 root public resume | #2669 | plan amendment required before implementation | audit `task_9f27829ca50f` | planned `codex/issue-2669-root-resume` | `7a98f6662` → — | none | current password redirect rejects `/`; public view is slug-hook-bound; SSR canonical cannot import server env; expanded auth/canonical contract identified | audit focused API/web suites, typechecks, boundaries passed | — | amend ownership for identity-vs-return auth flow and server-derived canonical root, then dispatch coherent feature | engineering scope correction; feature remains narrower than arbitrary domain/TLS registry | | 09 external version backup | #2705 | published; exact-head hosted checks running | coordinator publication follow-up | `codex/issue-2705-git-backup-docs` | `7a98f6662` → `4ffdd96bd` | none | clean round-4 rereview; command-site prose requires unused output; sentinel/current resume preservation and import-as-new recovery proved | fresh coordinator 152 tests plus Markdown/diff/scope green; exact-head hosted checks queued | [#3458](https://github.com/amruthpillai/reactive-resume/pull/3458) | after hosted checks, reply/resolve two outdated duplicate threads; keep unmerged | DB integration/E2E unavailable; no sync/remote/whole-account restore | | 10 legacy link routing | #2836 | pending implementation after brief correction | audit `task_9f27829ca50f` | planned `codex/issue-2836-retired-slug-notices` | `7a98f6662` → — | none | prospective same-username slug-attempt notice remains coherent; exact DB/API/UI/E2E owner set verified | audit focused API/web suites, DB/API/web typechecks, boundaries passed | — | correct final E2E target to `public-sharing.spec.ts`, then implement migration/API/owner UI atomically | historical cause absent; no redirects/emails/recovery; prospective partial coverage only | @@ -48,7 +48,7 @@ state changes are outside scope. | 13 font/glyph/spacing | #3249, #3159, #3147, #3093, #3089, #2988 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize font sources with 14/27 | merged metrics/cache/Unicode fixes present and passing; residuals require per-font/per-symptom fixtures | audit focused PDF/font suites, affected typechecks, boundaries, build passed | — | retain regressions; create residual unit only from exact failing font fixture | missing Ropa Sans/source strings/font hashes/before-after artifacts | | 14 RTL export layout | #3275 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize renderer/fonts with 13/27 | merged canvas-direction fix remains; broader shaping/bidi cause unproved | audit RTL/preview suites, affected typechecks, boundaries, build passed | — | run controlled same-bytes export matrix against approved shaping oracle | exact JSON/font/version and known-good reference absent | | 15 picture fitting/style | #3168, #3088, #2794, #2782 | fixing 15A review findings; other causes blocked | fix `task_5a4afecb7d0d` / `ctx_43faac4f25eb` | `codex/issue-2782-picture-fit` | `7a98f6662` → `d891afd66` | coordinate 06/25; schema/PDF owner exclusion | runtime Cover/Contain behavior passed review; geometry regression was too weak and UI tests coupled to Tailwind class | full repo tests; focused suites/typechecks/boundaries/build; 2 authenticated raster E2E green before test-strength finding | — | pin Cover/Contain geometry and behavioral CSS assertions, deduplicate props, then rereview | delivery/centering issues still lack source revisions/assets/expected crop | -| 16 imported table borders | #3196 | pending implementation | unassigned | planned `codex/issue-3196-editable-tables` | `7a98f6662` → — | rich-text owner; must precede 19/31 | editor lacks table extensions; Q11 approves editable supported tables; atomic editor/HTML/PDF unit ready | audit current table/rich-input regressions, affected typechecks, boundaries, build passed | — | implement via TDD, including persistence, undo/redo, borders, and lossless unsupported fallback | historical visual equivalence lacks reporter HTML/JSON but feature contract is approved | +| 16 imported table borders | #3196 | implementing | `task_f3d05a6ebb86` / `ctx_686ba93fc8af` | `codex/issue-3196-editable-tables` | `7a98f6662` → work active | rich-text owner; must precede 19/31 | editor lacks table extensions; Q11 approves editable supported tables; atomic editor/HTML/PDF unit dispatched in isolated worktree | audit baseline green; implementation TDD and E2E running | — | complete atomic editor/HTML/PDF implementation, verify, commit, independently review | historical visual equivalence lacks reporter HTML/JSON but feature contract is approved | | 17 list/skill pagination | #2751, #3040 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer owner shared with 13/14/18 | merged ordered-marker/wrap/level-gap fixes present; current residual not reproduced | audit focused PDF suites, typecheck, boundaries, build passed | — | retain controls; add fix only from exact failing list/skill fixture | #2751 source absent; #3040 current fixture no longer proves residual clipping | | 18 preview/export geometry | #2683 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | share output-boundary harness with 12; viewer owner exclusion | current viewport/page-size/margin baselines pass; video alone cannot locate cause | audit page/preview tests, affected typechecks, boundaries, build passed | — | compare identical preview/download bytes, MediaBoxes, ink bounds, viewport, DPR | exact JSON/PDF/browser/DPR/zoom/page settings absent | | 19 literal rich-text whitespace | #3397 | pending after 16 | unassigned | planned `codex/issue-3397-literal-whitespace` | `7a98f6662` → — | stack/rebase after 16; coordinate DOCX/PDF/editor with 31 | verified current marked-policy gap; approved marker contract and four-space tabs remain implementation-ready | audit whitespace/indentation suites, affected typechecks, boundaries, build passed | — | implement web/PDF/DOCX atomically after table seam stabilizes | no product blocker; serialized file ownership only | @@ -109,7 +109,9 @@ state changes are outside scope. | Plan 15A independent review | `task_d4f4841355e2` / `ctx_467f293cf443` | same Plan 15A worktree | complete; changes required; worker released | medium: raster checks did not pin fit geometry; low: class coupling and duplicate props type | | Plan 15A review fix | `task_5a4afecb7d0d` / `ctx_43faac4f25eb` | same Plan 15A worktree | implementing | strengthen Cover/Contain geometry and behavioral assertions, consolidate props type, rerun raster E2E | | Plan 07 hosted review follow-up | `task_6e9bc84ca2d4` / `ctx_e31d0e345240` | `codex/issue-2722-postgres-docs` | no findings; pushed; worker released | commit `a7b8c4c`; five valid comments fixed, `--no-deps` removal rejected; six replies and zero unresolved threads | -| Plan 07 late hosted fix | `task_6d0545ee43b1` / `ctx_1d6a1e36def3` | same Plan 07 worktree | implementing | separate image/repository update paths through log inspection; address late Greptile thread without widening lifecycle scope | +| Plan 07 late hosted fix | `task_6d0545ee43b1` / `ctx_1d6a1e36def3` | same Plan 07 worktree | complete; worker released | commit `171637526`; separate image/repository build and log paths; Compose/docs gates green | +| Plan 07 late fix rereview | `task_8ff818f3e95a` / queued | same Plan 07 worktree | ready | independent full-diff and Compose validation before corrected head publication | +| Plan 16 implementation | `task_f3d05a6ebb86` / `ctx_686ba93fc8af` | `codex/issue-3196-editable-tables` | implementing | atomic editable supported tables, lossless unsupported fallback, PDF border geometry, persistence/E2E | ## Existing PR and residual accounting diff --git a/docs/execution/briefs/rereview-plan-07-round2.md b/docs/execution/briefs/rereview-plan-07-round2.md new file mode 100644 index 000000000..9191ce544 --- /dev/null +++ b/docs/execution/briefs/rereview-plan-07-round2.md @@ -0,0 +1,17 @@ +# Independent rereview: Plan 07 late hosted fix + +Review only in `/Users/amruth/orca/workspaces/reactive-resume/issue-2722-postgres-docs`. +Exact target head: `171637526de4bb0d0e4320ebb85048675b92f1c7`. +PR #3457 remains open at older remote head. Do not edit tracked files, commit, push, reply, resolve, or merge. + +Read current instructions, pinned approved Plan 07, complete `origin/main...HEAD` diff, all Plan 07 reports, live issue +number 2722, PR/check/thread state, and late thread `PRRT_kwDODuah5s6fnaBa`. Refresh base and verify target head. + +Independently verify image quickstart and repository source-build update paths are unmistakably separate through log +inspection. Both paths must use correct service names; image path retains pull/up/log commands for `reactive-resume`; +repository path uses build/up/log commands for `reactive_resume`, no pull, app-only `--no-deps`, and no dependency or +PostgreSQL lifecycle widening. + +Run both Compose config validations and dry-runs, focused DB test, Markdown/link/command/diff/exact-scope gates. Review +full diff for standards and approved-plan compliance. Write `.orchestration/plan-07-hosted-review-rereview-round2.md` +with findings first and publication verdict, then send worker_done. No subagents.