Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2026-08-23 14:52:18 +10:00
Code Issues Packages Projects Releases Wiki Activity

fix: address Greptile review on margin clamping

Browse Source 
Add .catch() fallbacks for marginX/marginY so oversized stored values
recover instead of failing schema parse, and allow transient empty
numeric input in the form without persisting invalid metadata.

Co-authored-by: Amruth Pillai <im.amruth@gmail.com>
This commit is contained in:
Cursor Agent
2026-07-29 16:03:45 +00:00
co-authored by Amruth Pillai
parent f55e584e34
commit 1aca52b0d7
3 changed files with 27 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/src/routes/builder/$resumeId/-sidebar/right/sections/page.tsx
+12 -4
View File
@@ -55,7 +55,12 @@ function PageSectionForm() {
useSyncFormValues(form, page);
const handleAutoSave = <K extends keyof FormValues>(name: K, value: FormValues[K]) => {
persist({ ...form.state.values, [name]: value });
const next = { ...form.state.values, [name]: value };
// Keep last-saved numeric page fields when the form holds a transient empty/NaN value
for (const key of ["marginX", "marginY", "gapX", "gapY"] as const) {
if (!Number.isFinite(next[key])) next[key] = page?.[key] ?? 0;
}
persist(next);
};
const pageNumberFields = [
@@ -148,7 +153,7 @@ function PageSectionForm() {
render={
<InputGroupInput
name={field.name}
value={field.state.value}
value={Number.isFinite(field.state.value) ? field.state.value : ""}
min={min}
{...(max !== undefined ? { max } : {})}
step={1}
@@ -156,8 +161,11 @@ function PageSectionForm() {
onBlur={field.handleBlur}
onChange={(e) => {
const v = e.target.value;
// Ignore transient empty/invalid input so resume metadata stays numeric
if (v === "") return;
if (v === "") {
// Allow clearing the controlled input without persisting invalid metadata
field.handleChange(Number.NaN);
return;
}
const raw = Number(v);
if (!Number.isFinite(raw)) return;