From 1be75240dd92f2bbcc06eae6c90b1431c3ed1d41 Mon Sep 17 00:00:00 2001
From: albanofazzito <albanofazzito@gmail.com>
Date: Wed, 17 Jun 2026 08:27:39 -0300
Subject: [PATCH] fix: use non-empty placeholder for redacted resume name
 (#3138)

* fix: use non-empty placeholder for redacted resume name

* fix: update stale test title to match new placeholder behavior

---------

Co-authored-by: Albano <alumno26.fazzito.albano@ipm.edu.ar>
---
 packages/api/src/dto/resume.test.ts                    | 2 +-
 packages/api/src/features/resume/access-policy.test.ts | 4 ++--
 packages/api/src/features/resume/access-policy.ts      | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/api/src/dto/resume.test.ts b/packages/api/src/dto/resume.test.ts
index 214a55513..4a33b5abe 100644
--- a/packages/api/src/dto/resume.test.ts
+++ b/packages/api/src/dto/resume.test.ts
@@ -28,7 +28,7 @@ describe("resume DTO output validation", () => {
 			hasPassword: dbResume.hasPassword,
 		};
 
-		expect(publicResume.name).toBe("");
+		expect(publicResume.name).toBe("Resume");
 		expect(publicResume.data.metadata.notes).toBe("");
 		expect(resumeDto.getBySlug.output.safeParse(publicResume).success).toBe(true);
 	});
diff --git a/packages/api/src/features/resume/access-policy.test.ts b/packages/api/src/features/resume/access-policy.test.ts
index 4aa6c6c9f..2c312dff2 100644
--- a/packages/api/src/features/resume/access-policy.test.ts
+++ b/packages/api/src/features/resume/access-policy.test.ts
@@ -53,13 +53,13 @@ describe("redactResumeForViewer", () => {
 		expect(redactResumeForViewer(resume, true)).toBe(resume);
 	});
 
-	it("strips name to empty for non-owner", () => {
+	it("replaces name with placeholder for non-owner", () => {
 		const resume = {
 			name: "Senior Eng @ Foo — final draft",
 			data: defaultResumeData,
 		};
 		const result = redactResumeForViewer(resume, false);
-		expect(result.name).toBe("");
+		expect(result.name).toBe("Resume");
 	});
 
 	it("strips metadata.notes for non-owner", () => {
diff --git a/packages/api/src/features/resume/access-policy.ts b/packages/api/src/features/resume/access-policy.ts
index 00b874b32..2d04cee4a 100644
--- a/packages/api/src/features/resume/access-policy.ts
+++ b/packages/api/src/features/resume/access-policy.ts
@@ -56,7 +56,7 @@ export function redactResumeForViewer<T extends { name: string; data: ResumeData
 
 	return {
 		...resume,
-		name: "",
+		name: "Resume",
 		data: {
 			...resume.data,
 			metadata: {