From 1e4d8ddea2e505749d63c35921fbfd88bb309278 Mon Sep 17 00:00:00 2001 From: Amruth Pillai Date: Sun, 6 Sep 2026 00:44:50 +0200 Subject: [PATCH] docs: queue final serialized recovery review --- docs/execution/approved-issue-plans-ledger.md | 13 +++++++------ docs/execution/briefs/review-plan-02-final.md | 19 +++++++++++++++++++ 2 files changed, 26 insertions(+), 6 deletions(-) create mode 100644 docs/execution/briefs/review-plan-02-final.md diff --git a/docs/execution/approved-issue-plans-ledger.md b/docs/execution/approved-issue-plans-ledger.md index acce14396..07a3c2c82 100644 --- a/docs/execution/approved-issue-plans-ledger.md +++ b/docs/execution/approved-issue-plans-ledger.md @@ -34,7 +34,7 @@ state changes are outside scope. | Unit | Issues | Status / current validity | Owner | Worktree / branch | Base → head | Dependencies | Evidence | Tests | PR | Next action | Blockers | | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | | 01 account login/recovery | #3166, #3164, #3078, #3046, #2897, #2837 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | none | zero drift; live issues remain split; #3046/#3078 have merged #3095 candidate only | auth 42, email 6, focused/full API/server suites and affected typechecks/boundaries passed in audit | — | select exact auth/mail/API boundary only after current sanitized trace | current cloud digest, provider/account method, request/status trace, controlled mailbox | -| 02 hosted v4 recovery | #3181, #2760 | implementing contract hardening | fix `task_baf33a609db0` / `ctx_48534ddcf89f` | `codex/issue-3181-recovery-procedure` | `7a98f6662` → `8607a5138` | #2760 identity branch depends on 01 evidence | third review found truthy non-boolean gate bypass and executable/non-JSON object identity; comparator contract now being narrowed to serialized requests | prior 16 tooling, 54 API, 21 auth tests and gates green; strict-TDD correction active | — | validate full serialized envelope, then fresh independent review | real recovery still needs verified owner, snapshot, mapping, private delivery | +| 02 hosted v4 recovery | #3181, #2760 | final independent review | review `task_5b02aa026038` / `ctx_d16058d89c7c` | `codex/issue-3181-recovery-procedure` | `7a98f6662` → `00855fa16` | #2760 identity branch depends on 01 evidence | serialized request-only API and strict inert envelope close gate/object bypasses with 36-case TDD | 36 tooling, 54 API, 21 auth tests; typechecks/boundaries/Biome/Markdown/import/diff green; final review active | — | clean final review, fresh verification, publish | real recovery still needs verified owner, snapshot, mapping, private delivery | | 03 MCP registration | #3398, #3153 | no-change | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | coordinate DB/startup with 05 | merged #3421 (`fe9b59e`) present on main; current schema/startup/auth contracts match plan | #3421 hosted checks successful; audit auth/server/API/DB tests, typechecks, boundaries passed | #3421 merged before run | deployment verification only | deployed digest/log correlation and exact Codex/Claude DCR/consent/PKCE/MCP retest unavailable | | 04 AI provider compatibility | #2732, #2766, #2723, #2708 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | serialize edits to AI service | zero drift; historical #2708 Responses path and #2766 structured Test path absent; remaining tuples differ | focused API 96 and full API suites/typecheck/boundaries passed in audit | — | select wire/state/import/base-path unit only after exact current tuple fails | provider/model/base URL/path/version/action/error tuple and allowed endpoint unavailable | | 05 AI provider migrations | #3152 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | coordinate DB/startup with 03 | zero drift; table schema, migration, startup ordering, Docker copy path coherent; `42P01` historical cause unresolved | audit API/server/DB tests, typechecks, boundaries passed; no real PostgreSQL migration fixture | — | choose config/packaging/startup/migration repair only after disposable reproduction | affected image layout/digest, working directory, DB schema/search path/journal, fresh+upgrade DB fixture | @@ -43,11 +43,11 @@ state changes are outside scope. | 08 root public resume | #2669 | plan amendment required before implementation | audit `task_9f27829ca50f` | planned `codex/issue-2669-root-resume` | `7a98f6662` → — | none | current password redirect rejects `/`; public view is slug-hook-bound; SSR canonical cannot import server env; expanded auth/canonical contract identified | audit focused API/web suites, typechecks, boundaries passed | — | amend ownership for identity-vs-return auth flow and server-derived canonical root, then dispatch coherent feature | engineering scope correction; feature remains narrower than arbitrary domain/TLS registry | | 09 external version backup | #2705 | published; hosted correction under final review | review `task_435249ae4c23` / `ctx_5fd78d0eeccd` | `codex/issue-2705-git-backup-docs` | `7a98f6662` → published `6931d2cc4`; local `9dd218ba1` | none | selected commit lookup plus explicit recovered-file creation committed; current resume preservation proved synthetically | 152 focused tests plus Markdown/commands/link/diff/scope green; final independent review active | [#3458](https://github.com/amruthpillai/reactive-resume/pull/3458) | clean re-review, push corrected head, resolve duplicate threads | DB integration/E2E unavailable; no sync/remote/whole-account restore | | 10 legacy link routing | #2836 | pending implementation after brief correction | audit `task_9f27829ca50f` | planned `codex/issue-2836-retired-slug-notices` | `7a98f6662` → — | none | prospective same-username slug-attempt notice remains coherent; exact DB/API/UI/E2E owner set verified | audit focused API/web suites, DB/API/web typechecks, boundaries passed | — | correct final E2E target to `public-sharing.spec.ts`, then implement migration/API/owner UI atomically | historical cause absent; no redirects/emails/recovery; prospective partial coverage only | -| 11 job search policy | #3010 | published; hosted wording correction under review | review `task_a9d8b3e0a8a2` / `ctx_6b03ba8f389c` | `codex/issue-3010-jsearch-docs` | `7a98f6662` → published `e05977007`; local `1d03978` | none | clean independent publication review; two valid low-risk hosted wording comments corrected locally | 52 focused tests plus Markdown/diff/base/scope green; follow-up Markdown/link/diff green | [#3459](https://github.com/amruthpillai/reactive-resume/pull/3459) | finish independent correction review, push, resolve threads | real provider/browser optional gate unavailable; removal motive unknown | +| 11 job search policy | #3010 | published; hosted correction pushed | hosted re-review complete | `codex/issue-3010-jsearch-docs` | `7a98f6662` → `1d0397884` | none | two valid wording comments fixed; independent full-diff re-review found no issues | 52 focused tests plus Markdown/link/diff/base/scope green; exact-head hosted checks rerunning | [#3459](https://github.com/amruthpillai/reactive-resume/pull/3459) | after hosted checks, reply/resolve two Codacy threads; keep unmerged | real provider/browser optional gate unavailable; removal motive unknown | | 12 preview/export failures | #3323, #3290, #3033, #3007, #2609 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer ownership; share observation harness with 18 | zero drift; staged-preview/error-boundary baselines remain; reports cross persistence/font/PDF/viewer/deployment boundaries | audit focused web/PDF suites, affected typechecks, boundaries, build passed | — | isolate PT Sans, browser/config, and template-selection boundaries; no shared fix | exact JSON/output/browser/config/current reproduction missing | | 13 font/glyph/spacing | #3249, #3159, #3147, #3093, #3089, #2988 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize font sources with 14/27 | merged metrics/cache/Unicode fixes present and passing; residuals require per-font/per-symptom fixtures | audit focused PDF/font suites, affected typechecks, boundaries, build passed | — | retain regressions; create residual unit only from exact failing font fixture | missing Ropa Sans/source strings/font hashes/before-after artifacts | | 14 RTL export layout | #3275 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize renderer/fonts with 13/27 | merged canvas-direction fix remains; broader shaping/bidi cause unproved | audit RTL/preview suites, affected typechecks, boundaries, build passed | — | run controlled same-bytes export matrix against approved shaping oracle | exact JSON/font/version and known-good reference absent | -| 15 picture fitting/style | #3168, #3088, #2794, #2782 | pending independent review 15A; other causes blocked | implementation complete `task_557902c8adef`; review queued `task_d4f4841355e2` | `codex/issue-2782-picture-fit` | `7a98f6662` → `d891afd66` | coordinate 06/25; schema/PDF owner exclusion | explicit Cover/Contain across schema, import, builder, shared PDF, docs/catalogs and raster E2E committed | full repo tests; schema/web/PDF/import suites; typechecks/boundaries/build; 2 authenticated raster E2E green | — | independent full-diff/raster review before publication | delivery/centering issues still lack source revisions/assets/expected crop | +| 15 picture fitting/style | #3168, #3088, #2794, #2782 | reviewing 15A; other causes blocked | review `task_d4f4841355e2` / `ctx_467f293cf443` | `codex/issue-2782-picture-fit` | `7a98f6662` → `d891afd66` | coordinate 06/25; schema/PDF owner exclusion | explicit Cover/Contain across schema, import, builder, shared PDF, docs/catalogs and raster E2E committed | full repo tests; schema/web/PDF/import suites; typechecks/boundaries/build; 2 authenticated raster E2E green; independent review active | — | resolve findings or publish after clean review/fresh verification | delivery/centering issues still lack source revisions/assets/expected crop | | 16 imported table borders | #3196 | pending implementation | unassigned | planned `codex/issue-3196-editable-tables` | `7a98f6662` → — | rich-text owner; must precede 19/31 | editor lacks table extensions; Q11 approves editable supported tables; atomic editor/HTML/PDF unit ready | audit current table/rich-input regressions, affected typechecks, boundaries, build passed | — | implement via TDD, including persistence, undo/redo, borders, and lossless unsupported fallback | historical visual equivalence lacks reporter HTML/JSON but feature contract is approved | | 17 list/skill pagination | #2751, #3040 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer owner shared with 13/14/18 | merged ordered-marker/wrap/level-gap fixes present; current residual not reproduced | audit focused PDF suites, typecheck, boundaries, build passed | — | retain controls; add fix only from exact failing list/skill fixture | #2751 source absent; #3040 current fixture no longer proves residual clipping | | 18 preview/export geometry | #2683 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | share output-boundary harness with 12; viewer owner exclusion | current viewport/page-size/margin baselines pass; video alone cannot locate cause | audit page/preview tests, affected typechecks, boundaries, build passed | — | compare identical preview/download bytes, MediaBoxes, ink bounds, viewport, DPR | exact JSON/PDF/browser/DPR/zoom/page settings absent | @@ -91,7 +91,8 @@ state changes are outside scope. | Plan 02 re-review | `task_5bffa8e386f2` / `ctx_57fe2ac671f8` | same Plan 02 worktree | complete; changes required | original object still serialized before validation; boxed string reproduced false no-op | | Plan 02 second review fix | `task_eb3b8c09aef2` / `ctx_3d3e5f7d2496` | same Plan 02 worktree | complete; worker released | commit `8607a5138`; original-form validation plus boxed-string/custom-`toJSON` regressions | | Plan 02 final re-review | `task_ae1f7e591826` / `ctx_475ef901639c` | same Plan 02 worktree | complete; changes required; worker released | P1 truthy gate bypass plus executable/non-JSON object input identity | -| Plan 02 contract hardening | `task_baf33a609db0` / `ctx_48534ddcf89f` | same Plan 02 worktree | implementing | serialized request-only API, strict envelope, adversarial regressions | +| Plan 02 contract hardening | `task_baf33a609db0` / `ctx_48534ddcf89f` | same Plan 02 worktree | complete; worker released | commit `00855fa16`; serialized request-only API, strict envelope, 36-case adversarial coverage | +| Plan 02 final independent review | `task_5b02aa026038` / `ctx_d16058d89c7c` | same Plan 02 worktree | reviewing | complete 596-line diff, all prior bypasses, proportionality and maintenance | | Plan 09 re-review | `task_1bd82b008a77` / `ctx_ca2a0176b52f` | same Plan 09 worktree | complete; no findings; worker released | full diff and both factual corrections verified before PR #3458 | | Plan 09 hosted review follow-up | `task_a44e374822b4` / `ctx_89e6769df19d` | same Plan 09 worktree | complete; changes required; worker released | selected revision prints correctly but no importable file is created | | Plan 09 hosted review fix round 2 | `task_8605c30ca032` / `ctx_2e0aa7be1312` | same Plan 09 worktree | complete; worker released | commit `9dd218ba1`; non-destructive recovered-file command plus synthetic proof | @@ -99,9 +100,9 @@ state changes are outside scope. | Plan 11 independent review | `task_7d5d4c1417a9` / `ctx_17ee05faf9e7` | same Plan 11 worktree | complete; changes required | attachment-format overclaim and duplicated patch/restore guidance | | Plan 11 review fix | `task_351a96e90b69` / `ctx_e398c9128731` | same Plan 11 worktree | complete; worker released | commit `e05977007`; attachment promise removed and adjacent guidance deduplicated | | Plan 11 re-review | `task_86a66b578544` / `ctx_3bb8017e8676` | same Plan 11 worktree | complete; no findings; worker released | exact head `e05977007`; 52 focused tests and full diff verified before PR #3459 | -| Plan 11 hosted review follow-up | `task_a9d8b3e0a8a2` / `ctx_6b03ba8f389c` | same Plan 11 worktree | reviewing | commit `1d03978`; sample wording plus heading/UI terminology alignment | +| Plan 11 hosted review follow-up | `task_a9d8b3e0a8a2` / `ctx_6b03ba8f389c` | same Plan 11 worktree | no findings; pushed; worker released | commit `1d03978`; sample wording plus heading/UI terminology alignment; hosted checks rerunning | | Plan 15A implementation | `task_557902c8adef` / `ctx_db6fae1b75c4` | `codex/issue-2782-picture-fit` | complete; worker released | commit `d891afd66`; explicit cover/contain contract across schema/editor/preview/PDF | -| Plan 15A independent review | `task_d4f4841355e2` | same Plan 15A worktree | ready; awaiting slot | full 70-file diff, raster/E2E reliability, schema/import/UI/PDF compatibility | +| Plan 15A independent review | `task_d4f4841355e2` / `ctx_467f293cf443` | same Plan 15A worktree | reviewing | full 70-file diff, raster/E2E reliability, schema/import/UI/PDF compatibility | | Plan 07 hosted review follow-up | `task_6e9bc84ca2d4` / `ctx_e31d0e345240` | `codex/issue-2722-postgres-docs` | no findings; pushed; worker released | commit `a7b8c4c`; five valid comments fixed, `--no-deps` removal rejected; six replies and zero unresolved threads | ## Existing PR and residual accounting diff --git a/docs/execution/briefs/review-plan-02-final.md b/docs/execution/briefs/review-plan-02-final.md new file mode 100644 index 000000000..6dab414e1 --- /dev/null +++ b/docs/execution/briefs/review-plan-02-final.md @@ -0,0 +1,19 @@ +# Final independent review: plan 02 serialized recovery comparator + +Review only. Read pinned approved plan 02, current `AGENTS.md`, RTK, applicable code-review skill, every Plan 02 report, +and complete `origin/main...00855fa1667b35502ec66d609a603716d647466d` four-file diff. Start fresh; prior churn is not evidence of correctness. + +Reproduce every prior P1/P2 bypass. Verify primitive-string guard runs before any object access/trap/getter/method; parsed +envelope validation is exact, non-coercing, finite-JSON-only, rejects unknown/missing keys and invalid/empty IDs/flag types; +valid false gates retain named reasons; target invariant and invalid source/target order are conservative; invalid manifests +are fresh and deterministic. Audit recursive validation/canonicalization for false identity, normalization, mutation, +exceptions, stack/size behavior appropriate to local synthetic tooling, and hash determinism. Ensure serialized-request +docs match actual API and do not claim raw-v4 support or real recovery. + +Run fresh base/live issue/PR state, all 36 comparator tests plus independent adversarial probes, API/auth tests/typechecks, +boundaries, narrow Biome/Markdown, import/no-output/diff/four-file scope. Review Standards and Spec axes, including whether +596-line tool/test diff remains proportionate and maintainable for approved procedure. + +Write `.orchestration/plan-02-final-review.md` with findings first and file/line evidence, exact head, commands/results, +skips, risks, and publication verdict. Do not edit tracked files, push, open PR, merge, mutate issues, or spawn subagents. +Final response at most ten lines.