Original
" }], + items: [{ id: "embedded-item", hidden: true, recipient: "Recipient
", content: "Original
" }], }, ]; - await getPool().query("UPDATE resume SET data=$1 WHERE id='alice-resume'", [source]); - const copy = await service.copyEmbedded({ - userId: "alice", - resumeId: "alice-resume", - sectionId: "embedded", - itemId: "embedded-item", - }); - expect(copy).toMatchObject({ - name: "Embedded Letter", + data.metadata.layout.pages = [{ fullWidth: true, main: ["experience", "embedded"], sidebar: [] }]; + const adopt = (input: typeof data) => + adoptEmbeddedLetters(fixture.db as never, { + userId: "alice", + resumeId: "alice-resume", + resumeName: "Frontend", + data: input, + }); + + const again = structuredClone(data); + await adopt(data); + expect(data.customSections).toEqual([]); + expect(data.metadata.layout.pages).toEqual([{ fullWidth: true, main: ["experience"], sidebar: [] }]); + + const letters = await service.list({ userId: "alice", limit: 20, offset: 0 }); + expect(letters.items).toHaveLength(1); + const [letter] = letters.items; + if (!letter) throw new Error("Missing letter."); + expect(letter).toMatchObject({ + name: "Frontend — Embedded Letter", + recipient: "Recipient
", content: "Original
", + layout: "freeform", + sourceResumeId: "alice-resume", + senderLinked: true, + designLinked: true, style: { sectionId: "embedded", itemId: "embedded-item" }, }); - await service.update({ userId: "alice", id: copy.id, expectedRevision: 1, content: "Changed independently" }); - const result = await getPool().query("SELECT data FROM resume WHERE id='alice-resume'"); - expect(result.rows[0].data).toEqual(source); - await expect( - service.copyEmbedded({ userId: "bob", resumeId: "alice-resume", sectionId: "embedded", itemId: "embedded-item" }), - ).rejects.toMatchObject({ code: "NOT_FOUND" }); + const versions = await getPool().query("SELECT kind FROM cover_letter_version WHERE cover_letter_id=$1", [ + letter.id, + ]); + expect(versions.rows).toEqual([{ kind: "created" }]); + + // The same section sent again (an older tab still open) doesn't save a second letter. + await adopt(again); + expect((await service.list({ userId: "alice", limit: 20, offset: 0 })).items).toHaveLength(1); }); it("isolates every read, mutation, export and context selection by account", async () => { diff --git a/packages/api/src/features/cover-letters/service.ts b/packages/api/src/features/cover-letters/service.ts index 26c27500d..4aacfa674 100644 --- a/packages/api/src/features/cover-letters/service.ts +++ b/packages/api/src/features/cover-letters/service.ts @@ -16,7 +16,7 @@ import { coverLetterDocumentSchema, coverLetterSchema, } from "@reactive-resume/schema/cover-letter/data"; -import { coverLetterItemSchema, resumeDataSchema } from "@reactive-resume/schema/resume/data"; +import { resumeDataSchema } from "@reactive-resume/schema/resume/data"; import { defaultResumeData } from "@reactive-resume/schema/resume/default"; import { resumeService } from "../resume/service"; import { sanitizeCoverLetterHtml } from "./html"; @@ -350,28 +350,6 @@ export const coverLetterService = { await assertUnlocked(input); throw new ORPCError("CONFLICT", { message: "This cover letter changed elsewhere. Reload it before deleting." }); }, - copyEmbedded: async (input: { - userId: string; - resumeId: string; - sectionId: string; - itemId: string; - name?: string | undefined; - }) => { - const resume = await resumeService.getById({ userId: input.userId, id: input.resumeId }); - const data = resumeDataSchema.parse(resume.data); - const section = data.customSections.find((item) => item.id === input.sectionId && item.type === "cover-letter"); - const item = section?.items.find((entry) => entry.id === input.itemId); - if (!item) throw new ORPCError("NOT_FOUND"); - const letter = coverLetterItemSchema.parse(item); - return insert({ - userId: input.userId, - name: input.name ?? (section?.title || "Cover Letter").slice(0, 100), - recipient: letter.recipient, - content: letter.content, - style: copyCoverLetterStyle(data, input.sectionId, input.itemId), - sourceResumeId: input.resumeId, - }); - }, export: async (input: OwnedId): PromiseHiring Manager
Sunrise Games Studio
Seattle, WA
hiring@sunrisegames.com
Dear Hiring Manager,
I'm excited to apply for the Senior Gameplay Engineer role at Sunrise Games Studio. Over the past five years, I have shipped cross-platform titles in Unity and Unreal Engine, leading core gameplay and tooling efforts that improved iteration speed and player experience. At Cascade Studios, I architected combat systems and optimized performance to maintain 60 FPS on console while partnering closely with design and art.
I thrive in collaborative, cross-disciplinary teams and enjoy mentoring junior engineers. I'd welcome the chance to bring my gameplay systems expertise and tooling focus to your next title.
Sincerely,
David Kowalski
Verified certification.
"; } + // Letters render through the same templates, as a cover-letter section; the fixture keeps one to cover it. + data.customSections.push(LETTER_SECTION); + data.metadata.layout.pages.push({ fullWidth: true, main: [LETTER_SECTION.id], sidebar: [] }); data.metadata.template = template; data.metadata.stylesheet = { mode: "semantic", diff --git a/packages/pdf/src/templates/shared/cover-letter.test.ts b/packages/pdf/src/templates/shared/cover-letter.test.ts index 0462a3cec..53bafdb98 100644 --- a/packages/pdf/src/templates/shared/cover-letter.test.ts +++ b/packages/pdf/src/templates/shared/cover-letter.test.ts @@ -1,25 +1,16 @@ import { describe, expect, it } from "vitest"; +import { copyCoverLetterStyle, createCoverLetterResumeData } from "@reactive-resume/resume/cover-letter"; import { sampleResumeData } from "@reactive-resume/schema/resume/sample"; import { shouldShowResumeHeader } from "./cover-letter"; -const createCoverLetterOnlyData = () => { - const data = structuredClone(sampleResumeData); - const coverLetter = data.customSections.find((section) => section.type === "cover-letter"); - - if (!coverLetter) throw new Error("sample resume must include a cover letter"); - - return { - ...data, - customSections: [coverLetter], - metadata: { - ...data.metadata, - layout: { - ...data.metadata.layout, - pages: [{ fullWidth: true, main: [coverLetter.id], sidebar: [] }], - }, - }, - }; -}; +// A letter's document: resume data with one cover-letter section, as the letter export builds it. +const createCoverLetterOnlyData = () => + createCoverLetterResumeData({ + name: "Cover Letter", + recipient: "Hiring Manager
", + content: "Dear Hiring Manager,
", + style: copyCoverLetterStyle(sampleResumeData, "letter-section", "letter-item"), + }); describe("shouldShowResumeHeader", () => { it("hides the header when every visible layout section is a cover letter", () => { diff --git a/packages/resume/src/cover-letter.test.ts b/packages/resume/src/cover-letter.test.ts index 53131552e..10ffbe53f 100644 --- a/packages/resume/src/cover-letter.test.ts +++ b/packages/resume/src/cover-letter.test.ts @@ -5,9 +5,43 @@ import { copyCoverLetterStyle, coverLetterTextToHtml, createCoverLetterResumeData, + detachEmbeddedLetters, greetingName, } from "./cover-letter"; +describe("detachEmbeddedLetters", () => { + it("takes letters out of the resume and its layout, and returns each one", () => { + const data = structuredClone(defaultResumeData); + const letter = createCoverLetterResumeData({ + name: "Letter", + recipient: "Acme
", + content: "Hello
", + style: copyCoverLetterStyle(data, "letters", "letter-1"), + }).customSections[0]; + if (!letter) throw new Error("Missing letter section."); + data.customSections = [ + { ...letter, items: [...letter.items, { ...letter.items[0], id: "letter-2", hidden: true } as never] }, + ]; + data.metadata.layout.pages = [ + { fullWidth: false, main: ["experience", "letters"], sidebar: ["letters", "skills"] }, + ]; + + expect(detachEmbeddedLetters(data)).toEqual([ + { sectionId: "letters", itemId: "letter-1", title: "Letter", recipient: "Acme
", content: "Hello
" }, + { sectionId: "letters", itemId: "letter-2", title: "Letter", recipient: "Acme
", content: "Hello
" }, + ]); + expect(data.customSections).toEqual([]); + expect(data.metadata.layout.pages).toEqual([{ fullWidth: false, main: ["experience"], sidebar: ["skills"] }]); + }); + + it("leaves a resume without letters as it is", () => { + const data = structuredClone(defaultResumeData); + const before = structuredClone(data); + expect(detachEmbeddedLetters(data)).toEqual([]); + expect(data).toEqual(before); + }); +}); + describe("independent cover letters", () => { it("copies sender and style without linking source mutations or retaining private notes", () => { const source = structuredClone(defaultResumeData); diff --git a/packages/resume/src/cover-letter.ts b/packages/resume/src/cover-letter.ts index 7793c6274..432404077 100644 --- a/packages/resume/src/cover-letter.ts +++ b/packages/resume/src/cover-letter.ts @@ -39,6 +39,46 @@ export function createCoverLetterResumeData( return data; } +/** A cover letter written inside a resume, as older versions of the app stored them. */ +export type EmbeddedLetter = { + sectionId: string; + itemId: string; + /** The section's title; empty when the template's default title was used. */ + title: string; + recipient: string; + content: string; +}; + +/** + * Letters are documents of their own; resumes no longer carry them. Takes every cover-letter section out of the + * resume (and out of its page layout) and returns the letters it held, so the caller can save them as letters. + * Mutates `data` in place; returns no letters, and changes nothing, for a resume without any. + */ +export function detachEmbeddedLetters(data: ResumeData): EmbeddedLetter[] { + const sections = data.customSections.filter((section) => section.type === "cover-letter"); + if (sections.length === 0) return []; + + const ids = new Set(sections.map((section) => section.id)); + data.customSections = data.customSections.filter((section) => !ids.has(section.id)); + for (const page of data.metadata.layout.pages) { + page.main = page.main.filter((id) => !ids.has(id)); + page.sidebar = page.sidebar.filter((id) => !ids.has(id)); + } + + return sections.flatMap((section) => + section.items.map((item) => { + const { recipient, content } = item as { recipient?: unknown; content?: unknown }; + return { + sectionId: section.id, + itemId: item.id, + title: section.title, + recipient: typeof recipient === "string" ? recipient : "", + content: typeof content === "string" ? content : "", + }; + }), + ); +} + const escapeHtml = (text: string) => text .replaceAll("&", "&") diff --git a/packages/resume/src/export-sections.test.ts b/packages/resume/src/export-sections.test.ts index 9cde8244a..62bd3facb 100644 --- a/packages/resume/src/export-sections.test.ts +++ b/packages/resume/src/export-sections.test.ts @@ -1,30 +1,44 @@ import { describe, expect, it } from "vitest"; import { defaultResumeData } from "@reactive-resume/schema/resume/default"; import { sampleResumeData } from "@reactive-resume/schema/resume/sample"; +import { copyCoverLetterStyle, createCoverLetterResumeData } from "./cover-letter"; import { getResumeExportData, resumeHasCoverLetter } from "./export-sections"; +// Letters render through the same templates: a letter's document is resume data with one cover-letter section. +// Here the sample resume carries one too, as resumes did before letters became documents of their own. +const LETTER_ID = "letter-section"; +const withLetter = () => { + const data = structuredClone(sampleResumeData); + const letter = createCoverLetterResumeData({ + name: "Cover Letter", + recipient: "Hiring Manager
", + content: "Dear Hiring Manager,
", + style: copyCoverLetterStyle(data, LETTER_ID, "letter-item"), + }); + data.customSections.push(...letter.customSections); + data.metadata.layout.pages.push({ fullWidth: true, main: [LETTER_ID], sidebar: [] }); + return data; +}; + describe("resume export sections", () => { it("detects visible cover letter sections", () => { expect(resumeHasCoverLetter(defaultResumeData)).toBe(false); - expect(resumeHasCoverLetter(sampleResumeData)).toBe(true); + expect(resumeHasCoverLetter(sampleResumeData)).toBe(false); + expect(resumeHasCoverLetter(withLetter())).toBe(true); }); it("removes cover letter sections from resume-only exports", () => { - const data = getResumeExportData(sampleResumeData, "resume"); + const data = getResumeExportData(withLetter(), "resume"); expect(data.customSections.some((section) => section.type === "cover-letter")).toBe(false); - expect(data.metadata.layout.pages.flatMap((page) => [...page.main, ...page.sidebar])).not.toContain( - "019bef5b-0b3d-7e2a-8a7c-12d9e23a4f6b", - ); + expect(data.metadata.layout.pages.flatMap((page) => [...page.main, ...page.sidebar])).not.toContain(LETTER_ID); }); it("keeps only cover letter sections for cover-letter exports", () => { - const data = getResumeExportData(sampleResumeData, "cover-letter"); + const data = getResumeExportData(withLetter(), "cover-letter"); expect(data.customSections).toHaveLength(1); expect(data.customSections[0]?.type).toBe("cover-letter"); - expect(data.metadata.layout.pages).toEqual([ - { fullWidth: true, main: ["019bef5b-0b3d-7e2a-8a7c-12d9e23a4f6b"], sidebar: [] }, - ]); + expect(data.metadata.layout.pages).toEqual([{ fullWidth: true, main: [LETTER_ID], sidebar: [] }]); }); }); diff --git a/packages/resume/src/markdown.test.ts b/packages/resume/src/markdown.test.ts index 0dc3ab931..9547cc9ac 100644 --- a/packages/resume/src/markdown.test.ts +++ b/packages/resume/src/markdown.test.ts @@ -1,8 +1,23 @@ import { describe, expect, it } from "vitest"; import { sampleResumeData } from "@reactive-resume/schema/resume/sample"; +import { copyCoverLetterStyle, createCoverLetterResumeData } from "./cover-letter"; import { getResumeExportData } from "./export-sections"; import { buildMarkdown, htmlToMarkdown } from "./markdown"; +// A letter's document, as the letter export builds it: resume data with one cover-letter section. +const withLetter = () => { + const data = structuredClone(sampleResumeData); + const letter = createCoverLetterResumeData({ + name: "Cover Letter", + recipient: "Hiring Manager
", + content: "Dear Hiring Manager,
I'm excited to apply.
", + style: copyCoverLetterStyle(data, "letter-section", "letter-item"), + }); + data.customSections.push(...letter.customSections); + data.metadata.layout.pages.push({ fullWidth: true, main: ["letter-section"], sidebar: [] }); + return data; +}; + describe("htmlToMarkdown", () => { it("converts the constrained tiptap tag set", () => { const html = "Led teams of engineers.
Hiring Manager
Sunrise Games Studio
Seattle, WA
hiring@sunrisegames.com
Dear Hiring Manager,
I'm excited to apply for the Senior Gameplay Engineer role at Sunrise Games Studio. Over the past five years, I have shipped cross-platform titles in Unity and Unreal Engine, leading core gameplay and tooling efforts that improved iteration speed and player experience. At Cascade Studios, I architected combat systems and optimized performance to maintain 60 FPS on console while partnering closely with design and art.
I thrive in collaborative, cross-disciplinary teams and enjoy mentoring junior engineers. I'd welcome the chance to bring my gameplay systems expertise and tooling focus to your next title.
Sincerely,
David Kowalski
Globex
", content: "Dear Globex team,
" }], + }); + data.metadata.layout.pages.push({ fullWidth: true, main: ["old-letter"], sidebar: [] }); + const path = testInfo.outputPath("with-letter.json"); + await writeFile(path, JSON.stringify(data)); + + await page.goto("/dashboard"); + await page.getByRole("button", { name: "New", exact: true }).click(); + await page.getByRole("dialog", { name: "New document" }).getByLabel("Choose a file to import").setInputFiles(path); + await page.getByRole("button", { name: "Open in editor" }).click(); + await page.waitForURL(/\/builder\/.+/); + await expect(page.getByText("Dear Globex team,")).toHaveCount(0); + + await page.goto("/dashboard"); + await page.getByRole("tab", { name: /^Letters/ }).click(); + await expect(page.getByRole("heading", { name: /— Letter to Globex$/ })).toHaveCount(1); +});