From 2e11e6488137452c1f16501a6d7d2b579427e547 Mon Sep 17 00:00:00 2001
From: y8a5y <git@d.camo.ovh>
Date: Sun, 21 Dec 2025 22:42:48 +0100
Subject: [PATCH] fix(Resume Controller): address CodeRabbit nitpick nb1

---
 apps/server/src/resume/resume.controller.ts | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/apps/server/src/resume/resume.controller.ts b/apps/server/src/resume/resume.controller.ts
index 33f7bf576..d7d6c8e59 100644
--- a/apps/server/src/resume/resume.controller.ts
+++ b/apps/server/src/resume/resume.controller.ts
@@ -100,8 +100,7 @@ export class ResumeController {
   ) {
     const resume = await this.resumeService.findOneByUsernameSlug(username, slug);
 
-    // Hide private notes from public resume API responses
-    set(resume.data as ResumeData, "metadata.notes", undefined);
+    redactPrivateNotes(resume as ResumeDto);
 
     return resume;
   }
@@ -115,8 +114,7 @@ export class ResumeController {
   ) {
     const resume = await this.resumeService.findOneByUsernameSlug(username, slug);
 
-    // Hide private notes from public resume API responses
-    set(resume.data as ResumeData, "metadata.notes", undefined);
+    redactPrivateNotes(resume as ResumeDto);
 
     if (!userId) {
       await this.resumeService.incrementViewCountForOne(resume.id);
@@ -173,3 +171,7 @@ export class ResumeController {
     }
   }
 }
+
+function redactPrivateNotes(resume: ResumeDto) {
+  set(resume.data, "metadata.notes", undefined);
+}