Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2026-07-24 08:54:05 +10:00
Code Issues Packages Projects Releases Wiki Activity

fix(Resume Controller): address CodeRabbit nitpick nb1

Browse Source
This commit is contained in:
y8a5y
2025-12-21 22:42:48 +01:00
parent db86f3275b
commit 2e11e64881
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/server/src/resume/resume.controller.ts
+6 -4
View File
@@ -100,8 +100,7 @@ export class ResumeController {
) {
const resume = await this.resumeService.findOneByUsernameSlug(username, slug);
// Hide private notes from public resume API responses
set(resume.data as ResumeData, "metadata.notes", undefined);
redactPrivateNotes(resume as ResumeDto);
return resume;
}
@@ -115,8 +114,7 @@ export class ResumeController {
) {
const resume = await this.resumeService.findOneByUsernameSlug(username, slug);
// Hide private notes from public resume API responses
set(resume.data as ResumeData, "metadata.notes", undefined);
redactPrivateNotes(resume as ResumeDto);
if (!userId) {
await this.resumeService.incrementViewCountForOne(resume.id);
@@ -173,3 +171,7 @@ export class ResumeController {
}
}
}
function redactPrivateNotes(resume: ResumeDto) {
set(resume.data, "metadata.notes", undefined);
}