diff --git a/docs/execution/approved-issue-plans-ledger.md b/docs/execution/approved-issue-plans-ledger.md index 453b0eae9..c1ed8ad03 100644 --- a/docs/execution/approved-issue-plans-ledger.md +++ b/docs/execution/approved-issue-plans-ledger.md @@ -41,7 +41,7 @@ state changes are outside scope. | 06 image storage delivery | #2684, #2778 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | coordinate 12/15/25 renderer/image fixtures | #2684 ACL cause fixed by merged #3432 (`35cecf9`); #2778 Browserless path obsolete; current topology unproved | #3432 hosted checks successful; audit storage/upload/PDF tests, typechecks, boundaries passed | #3432 merged before run | deployment retest plus shared real-encoding/backend/render fixture before repair | deployed digest; disposable S3/Garage/SeaweedFS/MinIO/proxy and browser/server raster matrix unavailable | | 07 AIO deployment | #2722 | reviewing | re-review `task_90a9a6b63782` / `ctx_2f1def9119d6` | `codex/issue-2722-postgres-docs` | `7a98f6662` → `b61ca1609` | none | fix scopes update commands to app service and requires separate major-pinned PostgreSQL procedure with verified backup restore | focused Compose/Markdown/link/diff gates green; independent full-diff re-review active | — | publish immediately if re-review and fresh verification pass | no AIO implementation; optional Unraid host smoke unavailable | | 08 root public resume | #2669 | plan amendment required before implementation | audit `task_9f27829ca50f` | planned `codex/issue-2669-root-resume` | `7a98f6662` → — | none | current password redirect rejects `/`; public view is slug-hook-bound; SSR canonical cannot import server env; expanded auth/canonical contract identified | audit focused API/web suites, typechecks, boundaries passed | — | amend ownership for identity-vs-return auth flow and server-derived canonical root, then dispatch coherent feature | engineering scope correction; feature remains narrower than arbitrary domain/TLS registry | -| 09 external version backup | #2705 | reviewing | implementation `task_e450ea143bfa`; review `task_129b49e32bc7` / `ctx_68b13c76cc72` | `codex/issue-2705-git-backup-docs` | `7a98f6662` → `d4ef67113` | none | two docs committed locally with export-shape distinctions, plain local Git workflow, privacy/image limits, import-as-new recovery | implementer reports API/import/schema/web tests, synthetic Git round trip, Markdown/diff/scope gates green; DB integration/E2E skipped; independent rerun active | — | resolve independent findings, fresh verify, publish unmerged PR | no automatic sync, remote, or whole-account restore | +| 09 external version backup | #2705 | implementing | review fix `task_8aa48854e7da` / `ctx_5aa2007ec136` | `codex/issue-2705-git-backup-docs` | `7a98f6662` → `d4ef67113` + pending | none | reviewer found embedded-cover-letter scope contradiction and incorrect independent template-checkpoint claim | functional/doc gates green; reviewer independently reproduced source semantics | — | fix two factual statements, re-review, publish unmerged PR | DB integration/E2E unavailable; no sync/remote/whole-account restore | | 10 legacy link routing | #2836 | pending implementation after brief correction | audit `task_9f27829ca50f` | planned `codex/issue-2836-retired-slug-notices` | `7a98f6662` → — | none | prospective same-username slug-attempt notice remains coherent; exact DB/API/UI/E2E owner set verified | audit focused API/web suites, DB/API/web typechecks, boundaries passed | — | correct final E2E target to `public-sharing.spec.ts`, then implement migration/API/owner UI atomically | historical cause absent; no redirects/emails/recovery; prospective partial coverage only | | 11 job search policy | #3010 | pending implementation | audit `task_9f27829ca50f` | planned `codex/issue-3010-jsearch-docs` | `7a98f6662` → — | none | history proves JSearch removed in v5.1.0; current provider-native search and supplied-description tailoring verified | audit agent/capability tests, markdown lint, typechecks, boundaries passed | — | make minimal three-file factual docs correction | removal motive unknown; JSearch not restored and live search remains provider/model-dependent | | 12 preview/export failures | #3323, #3290, #3033, #3007, #2609 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer ownership; share observation harness with 18 | zero drift; staged-preview/error-boundary baselines remain; reports cross persistence/font/PDF/viewer/deployment boundaries | audit focused web/PDF suites, affected typechecks, boundaries, build passed | — | isolate PT Sans, browser/config, and template-selection boundaries; no shared fix | exact JSON/output/browser/config/current reproduction missing | @@ -86,7 +86,8 @@ state changes are outside scope. | Plan 07 review fix | `task_8ea6cfc76ef4` / `ctx_0184e1101bca` | same Plan 07 worktree | complete | commit `b61ca1609`; app-only update recipe and separately pinned database upgrade path | | Plan 02 review fix | `task_5fe67c42d856` / `ctx_28ed501db631` | same Plan 02 worktree | implementing | strict validation, target invariant, exact v5-only documentation | | Plan 07 re-review | `task_90a9a6b63782` / `ctx_2f1def9119d6` | same Plan 07 worktree | reviewing | full-diff verification after update-safety fix | -| Plan 09 independent review | `task_129b49e32bc7` / `ctx_68b13c76cc72` | same Plan 09 worktree | reviewing | format/workflow/privacy review and independent validation | +| Plan 09 independent review | `task_129b49e32bc7` / `ctx_68b13c76cc72` | same Plan 09 worktree | complete; changes required | embedded-letter JSON contradiction; template-checkpoint overclaim | +| Plan 09 review fix | `task_8aa48854e7da` / `ctx_5aa2007ec136` | same Plan 09 worktree | implementing | correct rendered-export scope and throttled template snapshot wording | ## Existing PR and residual accounting diff --git a/docs/execution/briefs/fix-review-plan-09.md b/docs/execution/briefs/fix-review-plan-09.md new file mode 100644 index 000000000..b49b0eba2 --- /dev/null +++ b/docs/execution/briefs/fix-review-plan-09.md @@ -0,0 +1,18 @@ +# Address independent review: plan 09 + +Read `.orchestration/plan-09-review.md`, pinned plan 09, current `AGENTS.md`, RTK, and applicable +receiving-code-review/documentation skills. Verify two findings against current source before editing; both are provisionally +accepted. + +Edit only two approved guide files: + +- In export guide, scope “excludes cover letter sections” to rendered PDF/DOCX/Markdown output and state JSON retains + embedded cover-letter custom sections. Keep distinction from independent cover-letter JSON. +- In version-history guide, do not claim template changes create independent checkpoints. Describe template changes as + ordinary editing covered by throttled snapshots; retain accurate explicit import/AI/API/restore checkpoint statements. + +Do not alter local Git workflow, add runtime code, promise whole-account restore/sync, or widen scope. Rerun focused source +checks, API/import/schema/web tests if wording relies on them, Markdown lint, synthetic Git workflow as needed, +`git diff --check`, and two-file scope gate. Add normal follow-up commit. Write `.orchestration/plan-09-review-fix.md` with +exact commit/files, verified source facts, commands/results, skipped gates, and risks. Do not push/open PR/merge/mutate +issues/spawn subagents. Final response at most ten lines.