From 3b73dcf29d91bee3d5e0445faf41bf9b6effc02a Mon Sep 17 00:00:00 2001 From: Amruth Pillai Date: Sat, 11 Jan 2025 16:13:04 +0100 Subject: [PATCH] fix issues brought up by coderabbit --- apps/client/src/libs/lingui.ts | 6 +++--- apps/server/src/printer/printer.service.ts | 6 ++++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/apps/client/src/libs/lingui.ts b/apps/client/src/libs/lingui.ts index ab62ff76..bc445292 100644 --- a/apps/client/src/libs/lingui.ts +++ b/apps/client/src/libs/lingui.ts @@ -17,8 +17,8 @@ export async function dynamicActivate(locale: string) { if (dayjsLocales[locale]) { dayjs.locale(await dayjsLocales[locale]()); } - } catch (error) { - // eslint-disable-next-line no-console - console.error(error); + } catch { + // eslint-disable-next-line lingui/no-unlocalized-strings + throw new Error(`Failed to load messages for locale: ${locale}`); } } diff --git a/apps/server/src/printer/printer.service.ts b/apps/server/src/printer/printer.service.ts index 262a8999..18127079 100644 --- a/apps/server/src/printer/printer.service.ts +++ b/apps/server/src/printer/printer.service.ts @@ -204,8 +204,10 @@ export class PrinterService { return resumeUrl; } catch (error) { - // eslint-disable-next-line no-console - console.trace(error); + throw new InternalServerErrorException( + ErrorMessage.ResumePrinterError, + (error as Error).message, + ); } }