Builder test: changed some queries to use *ByRole

This commit is contained in:
gianantoniopini
2021-01-20 13:40:58 +01:00
parent 155cd499fb
commit 3d39576a90

View File

@ -94,12 +94,12 @@ describe('Builder', () => {
}); });
it('first and last name', () => { it('first and last name', () => {
expect(screen.getByLabelText(/first name/i)).toHaveDisplayValue( expect(
resume.profile.firstName, screen.getByRole('textbox', { name: /first name/i }),
); ).toHaveDisplayValue(resume.profile.firstName);
expect(screen.getByLabelText(/last name/i)).toHaveDisplayValue( expect(
resume.profile.lastName, screen.getByRole('textbox', { name: /last name/i }),
); ).toHaveDisplayValue(resume.profile.lastName);
expect( expect(
screen.getAllByText(new RegExp(resume.profile.firstName, 'i')).length, screen.getAllByText(new RegExp(resume.profile.firstName, 'i')).length,
).toBeTruthy(); ).toBeTruthy();
@ -127,16 +127,18 @@ describe('Builder', () => {
expect(languageElement).toHaveValue(italianLanguageCode); expect(languageElement).toHaveValue(italianLanguageCode);
expect(screen.queryByLabelText(/date of birth/i)).toBeNull(); expect(screen.queryByLabelText(/date of birth/i)).not.toBeInTheDocument();
expect(screen.getByLabelText(/data di nascita/i)).toBeInTheDocument(); expect(screen.getByLabelText(/data di nascita/i)).toBeInTheDocument();
const languageStorageItem = localStorage.getItem(languageStorageItemKey); const languageStorageItem = localStorage.getItem(languageStorageItemKey);
expect(languageStorageItem).toBe(italianLanguageCode); expect(languageStorageItem).toBe(italianLanguageCode);
await waitFor(() => mockDatabaseUpdateFunction.mock.calls[0][0], { await waitFor(
timeout: DebounceWaitTime, () => expect(mockDatabaseUpdateFunction).toHaveBeenCalledTimes(1),
}); {
expect(mockDatabaseUpdateFunction).toHaveBeenCalledTimes(1); timeout: DebounceWaitTime,
},
);
const mockDatabaseUpdateFunctionCallArgument = const mockDatabaseUpdateFunctionCallArgument =
mockDatabaseUpdateFunction.mock.calls[0][0]; mockDatabaseUpdateFunction.mock.calls[0][0];
expect(mockDatabaseUpdateFunctionCallArgument.id).toBe(resumeId); expect(mockDatabaseUpdateFunctionCallArgument.id).toBe(resumeId);
@ -160,7 +162,7 @@ describe('Builder', () => {
}); });
it('when input value is changed', async () => { it('when input value is changed', async () => {
const input = screen.getByLabelText(/address line 1/i); const input = screen.getByRole('textbox', { name: /address line 1/i });
const newInputValue = 'test street 123'; const newInputValue = 'test street 123';
const now = new Date().getTime(); const now = new Date().getTime();
@ -168,10 +170,12 @@ describe('Builder', () => {
expect(input.value).toBe(newInputValue); expect(input.value).toBe(newInputValue);
await waitFor(() => mockDatabaseUpdateFunction.mock.calls[0][0], { await waitFor(
timeout: DebounceWaitTime, () => expect(mockDatabaseUpdateFunction).toHaveBeenCalledTimes(1),
}); {
expect(mockDatabaseUpdateFunction).toHaveBeenCalledTimes(1); timeout: DebounceWaitTime,
},
);
const mockDatabaseUpdateFunctionCallArgument = const mockDatabaseUpdateFunctionCallArgument =
mockDatabaseUpdateFunction.mock.calls[0][0]; mockDatabaseUpdateFunction.mock.calls[0][0];
expect(mockDatabaseUpdateFunctionCallArgument.id).toBe(resumeId); expect(mockDatabaseUpdateFunctionCallArgument.id).toBe(resumeId);