FirebaseStub: refactoring

__mocks__/__tests__/gatsby-plugin-firebase.test.js

@@ -1,6 +1,10 @@
 import FirebaseStub from '../gatsby-plugin-firebase';
 
-describe('auth', () => {
+describe('FirebaseStub', () => {
+  const resumesPath = FirebaseStub.database().resumesPath;
+  const usersPath = FirebaseStub.database().usersPath;
+
+  describe('auth', () => {
     afterEach(() => {
       FirebaseStub.auth().dispose();
     });
@@ -53,9 +57,9 @@ describe('auth', () => {
 
       expect(FirebaseStub.auth().onAuthStateChangedObservers.length).toEqual(0);
     });
-});
+  });
 
-describe('database', () => {
+  describe('database', () => {
     it('reuses existing Database instance', () => {
       const database1 = FirebaseStub.database();
       const database2 = FirebaseStub.database();
@@ -66,8 +70,8 @@ describe('database', () => {
     });
 
     it('reuses existing Reference instance', () => {
-    const ref1 = FirebaseStub.database().ref('resumes/123');
-    const ref2 = FirebaseStub.database().ref('resumes/123');
+      const ref1 = FirebaseStub.database().ref(`${resumesPath}/123`);
+      const ref2 = FirebaseStub.database().ref(`${resumesPath}/123`);
 
       expect(ref1.uuid).toBeTruthy();
       expect(ref2.uuid).toBeTruthy();
@@ -83,7 +87,7 @@ describe('database', () => {
     });
 
     it("can spy on Reference 'update' function", async () => {
-    const referencePath = 'resumes/123456';
+      const referencePath = `${resumesPath}/123456`;
       const functionSpy = jest.spyOn(
         FirebaseStub.database().ref(referencePath),
         'update',
@@ -101,7 +105,7 @@ describe('database', () => {
     it('initializing data sets up resumes and users', async () => {
       FirebaseStub.database().initializeData();
 
-    const resumesRef = FirebaseStub.database().ref('resumes');
+      const resumesRef = FirebaseStub.database().ref(resumesPath);
       const resumesDataSnapshot = await resumesRef.once('value');
       const resumes = resumesDataSnapshot.val();
       expect(resumes).toBeTruthy();
@@ -113,7 +117,7 @@ describe('database', () => {
       expect(emptyResume).toBeTruthy();
       expect(emptyResume.id).toEqual(FirebaseStub.database().emptyResumeId);
 
-    const usersRef = FirebaseStub.database().ref('users');
+      const usersRef = FirebaseStub.database().ref(usersPath);
       const usersDataSnapshot = await usersRef.once('value');
       const users = usersDataSnapshot.val();
       expect(users).toBeTruthy();
@@ -128,7 +132,7 @@ describe('database', () => {
 
       const resume = (
         await FirebaseStub.database()
-        .ref(`resumes/${FirebaseStub.database().demoResumeId}`)
+          .ref(`${resumesPath}/${FirebaseStub.database().demoResumeId}`)
           .once('value')
       ).val();
 
@@ -141,7 +145,9 @@ describe('database', () => {
       const resumeId = 'invalidResumeId';
 
       const resume = (
-      await FirebaseStub.database().ref(`resumes/${resumeId}`).once('value')
+        await FirebaseStub.database()
+          .ref(`${resumesPath}/${resumeId}`)
+          .once('value')
       ).val();
 
       expect(resume).toBeNull();
@@ -152,7 +158,7 @@ describe('database', () => {
 
       const user = (
         await FirebaseStub.database()
-        .ref(`users/${FirebaseStub.database().anonymousUser.uid}`)
+          .ref(`${usersPath}/${FirebaseStub.database().anonymousUser.uid}`)
           .once('value')
       ).val();
 
@@ -165,9 +171,12 @@ describe('database', () => {
       const userId = 'invalidUserId';
 
       const user = (
-      await FirebaseStub.database().ref(`users/${userId}`).once('value')
+        await FirebaseStub.database()
+          .ref(`${usersPath}/${userId}`)
+          .once('value')
       ).val();
 
       expect(user).toBeNull();
     });
+  });
 });

__mocks__/gatsby-plugin-firebase.js

@@ -60,13 +60,13 @@ class Auth {
 }
 
 class Database {
-  static resumesPath = 'resumes';
-  static usersPath = 'users';
   static #instance = undefined;
   #uuid = '';
   #data = {};
   #references = {};
   #anonymousUser = undefined;
+  #demoResumeId = 'demore';
+  #emptyResumeId = 'mtre01';
 
   constructor() {
     if (Database.#instance) {
@@ -82,15 +82,23 @@ class Database {
     };
   }
 
+  get resumesPath() {
+    return Reference.resumesPath;
+  }
+
+  get usersPath() {
+    return Reference.usersPath;
+  }
+
   get anonymousUser() {
     return this.#anonymousUser;
   }
 
   get demoResumeId() {
-    return 'demore';
+    return this.#demoResumeId;
   }
   get emptyResumeId() {
-    return 'mtre01';
+    return this.#emptyResumeId;
   }
 
   get uuid() {
@@ -124,11 +132,11 @@ class Database {
       resume.createdAt = date.valueOf();
     }
 
-    this.#data[Database.resumesPath] = resumes;
+    this.#data[this.resumesPath] = resumes;
 
     const users = {};
     users[this.anonymousUser.uid] = this.anonymousUser;
-    this.#data[Database.usersPath] = users;
+    this.#data[this.usersPath] = users;
   }
 
   ref(path) {
@@ -144,6 +152,8 @@ class Database {
 }
 
 class Reference {
+  static resumesPath = 'resumes';
+  static usersPath = 'users';
   #rootPath = '.';
   #path = '';
   #uuid = '';
@@ -188,15 +198,15 @@ class Reference {
     }
 
     if (
-      this.#path === Database.resumesPath ||
-      this.#path === Database.usersPath
+      this.#path === Reference.resumesPath ||
+      this.#path === Reference.usersPath
     ) {
       return this.#path in databaseData ? databaseData[this.#path] : null;
     }
 
     if (
-      this.#path.startsWith(`${Database.resumesPath}/`) ||
-      this.#path.startsWith(`${Database.usersPath}/`)
+      this.#path.startsWith(`${Reference.resumesPath}/`) ||
+      this.#path.startsWith(`${Reference.usersPath}/`)
     ) {
       const databaseLocationId = this.#path.substring(
         this.#path.indexOf('/') + 1,

src/pages/app/__tests__/builder.test.js

@@ -26,6 +26,7 @@ beforeEach(() => {
 afterEach(cleanup);
 
 describe('builder', () => {
+  const resumesPath = FirebaseStub.database().resumesPath;
   let resumeId = null;
   let resume = null;
   let mockUpdateFunction = null;
@@ -34,10 +35,12 @@ describe('builder', () => {
   beforeEach(async () => {
     resumeId = FirebaseStub.database().demoResumeId;
     resume = (
-      await FirebaseStub.database().ref(`resumes/${resumeId}`).once('value')
+      await FirebaseStub.database()
+        .ref(`${resumesPath}/${resumeId}`)
+        .once('value')
     ).val();
     mockUpdateFunction = jest.spyOn(
-      FirebaseStub.database().ref(`resumes/${resumeId}`),
+      FirebaseStub.database().ref(`${resumesPath}/${resumeId}`),
       'update',
     );