From 4fe9ab2a0d822ba06e91565128ccc40e1dcd4039 Mon Sep 17 00:00:00 2001 From: Amruth Pillai Date: Sun, 6 Sep 2026 01:01:30 +0200 Subject: [PATCH] docs: queue plan 07 late review fix --- docs/execution/approved-issue-plans-ledger.md | 5 +++-- .../briefs/fix-review-plan-07-round2.md | 21 +++++++++++++++++++ 2 files changed, 24 insertions(+), 2 deletions(-) create mode 100644 docs/execution/briefs/fix-review-plan-07-round2.md diff --git a/docs/execution/approved-issue-plans-ledger.md b/docs/execution/approved-issue-plans-ledger.md index f7e0120b3..5377a38d1 100644 --- a/docs/execution/approved-issue-plans-ledger.md +++ b/docs/execution/approved-issue-plans-ledger.md @@ -39,7 +39,7 @@ state changes are outside scope. | 04 AI provider compatibility | #2732, #2766, #2723, #2708 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | serialize edits to AI service | zero drift; historical #2708 Responses path and #2766 structured Test path absent; remaining tuples differ | focused API 96 and full API suites/typecheck/boundaries passed in audit | — | select wire/state/import/base-path unit only after exact current tuple fails | provider/model/base URL/path/version/action/error tuple and allowed endpoint unavailable | | 05 AI provider migrations | #3152 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | coordinate DB/startup with 03 | zero drift; table schema, migration, startup ordering, Docker copy path coherent; `42P01` historical cause unresolved | audit API/server/DB tests, typechecks, boundaries passed; no real PostgreSQL migration fixture | — | choose config/packaging/startup/migration repair only after disposable reproduction | affected image layout/digest, working directory, DB schema/search path/journal, fresh+upgrade DB fixture | | 06 image storage delivery | #2684, #2778 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | coordinate 12/15/25 renderer/image fixtures | #2684 ACL cause fixed by merged #3432 (`35cecf9`); #2778 Browserless path obsolete; current topology unproved | #3432 hosted checks successful; audit storage/upload/PDF tests, typechecks, boundaries passed | #3432 merged before run | deployment retest plus shared real-encoding/backend/render fixture before repair | deployed digest; disposable S3/Garage/SeaweedFS/MinIO/proxy and browser/server raster matrix unavailable | -| 07 AIO deployment | #2722 | published | implementation/review chain complete | `codex/issue-2722-postgres-docs` | `7a98f6662` → `a7b8c4cc5` | none | hosted review corrections distinguish image/build paths, pin quickstart PostgreSQL 17, warn on host ports, require verified cross-host TLS; five comments fixed, one rejected with evidence | Compose dry-runs, disposable PostgreSQL 17.11 migrations, Markdown/link/diff/scope and all hosted checks green; approved; zero unresolved threads | [#3457](https://github.com/amruthpillai/reactive-resume/pull/3457) | keep unmerged; monitor only | no AIO implementation; optional Unraid host smoke unavailable | +| 07 AIO deployment | #2722 | published; late hosted fix queued | queued `task_6d0545ee43b1` | `codex/issue-2722-postgres-docs` | `7a98f6662` → `a7b8c4cc5` | none | late Greptile thread correctly notes repository-build users can reach image-service log command after taking alternative update path | existing head checks green/approved; one new unresolved thread needs bounded fix and rereview | [#3457](https://github.com/amruthpillai/reactive-resume/pull/3457) | add adjacent `reactive_resume` log path, verify, independently rereview, then push/reply/resolve | no AIO implementation; optional Unraid host smoke unavailable | | 08 root public resume | #2669 | plan amendment required before implementation | audit `task_9f27829ca50f` | planned `codex/issue-2669-root-resume` | `7a98f6662` → — | none | current password redirect rejects `/`; public view is slug-hook-bound; SSR canonical cannot import server env; expanded auth/canonical contract identified | audit focused API/web suites, typechecks, boundaries passed | — | amend ownership for identity-vs-return auth flow and server-derived canonical root, then dispatch coherent feature | engineering scope correction; feature remains narrower than arbitrary domain/TLS registry | | 09 external version backup | #2705 | published; hosted correction under final rereview | review `task_4af7ea4cfb3f` / `ctx_98b5a07f33d4` | `codex/issue-2705-git-backup-docs` | `7a98f6662` → published `6931d2cc4`; local `4ffdd96bd` | none | command-site prose now requires fresh/unused output filename; sentinel preservation and import-as-new recovery proved | 152 focused tests plus Markdown/commands/link/diff/scope green after fix; independent rereview active | [#3458](https://github.com/amruthpillai/reactive-resume/pull/3458) | clean rereview, push corrected head, resolve duplicate threads | DB integration/E2E unavailable; no sync/remote/whole-account restore | | 10 legacy link routing | #2836 | pending implementation after brief correction | audit `task_9f27829ca50f` | planned `codex/issue-2836-retired-slug-notices` | `7a98f6662` → — | none | prospective same-username slug-attempt notice remains coherent; exact DB/API/UI/E2E owner set verified | audit focused API/web suites, DB/API/web typechecks, boundaries passed | — | correct final E2E target to `public-sharing.spec.ts`, then implement migration/API/owner UI atomically | historical cause absent; no redirects/emails/recovery; prospective partial coverage only | @@ -108,6 +108,7 @@ state changes are outside scope. | Plan 15A independent review | `task_d4f4841355e2` / `ctx_467f293cf443` | same Plan 15A worktree | complete; changes required; worker released | medium: raster checks did not pin fit geometry; low: class coupling and duplicate props type | | Plan 15A review fix | `task_5a4afecb7d0d` / `ctx_43faac4f25eb` | same Plan 15A worktree | implementing | strengthen Cover/Contain geometry and behavioral assertions, consolidate props type, rerun raster E2E | | Plan 07 hosted review follow-up | `task_6e9bc84ca2d4` / `ctx_e31d0e345240` | `codex/issue-2722-postgres-docs` | no findings; pushed; worker released | commit `a7b8c4c`; five valid comments fixed, `--no-deps` removal rejected; six replies and zero unresolved threads | +| Plan 07 late hosted fix | `task_6d0545ee43b1` / queued | same Plan 07 worktree | ready | separate image/repository update paths through log inspection; address late Greptile thread without widening lifecycle scope | ## Existing PR and residual accounting @@ -125,7 +126,7 @@ state changes are outside scope. - Coordinator ledger: PR #3456 (`codex/issue-execution-ledger` → `main`), open and intentionally unmerged. - Plan 07: PR [#3457](https://github.com/amruthpillai/reactive-resume/pull/3457), open and intentionally unmerged; - current head `a7b8c4cc5754c1249534d0ed8993e67e57e2cb87`; all hosted checks green, approved, mergeable, zero unresolved threads. + current head `a7b8c4cc5754c1249534d0ed8993e67e57e2cb87`; hosted checks green, approved, mergeable; one late unresolved thread queued for correction. - Plan 09: PR [#3458](https://github.com/amruthpillai/reactive-resume/pull/3458), open and intentionally unmerged; published head `6931d2cc4a512e53dfd51575ad729bb9f6da5249` after clean re-review and fresh 152-test verification. - Plan 11: PR [#3459](https://github.com/amruthpillai/reactive-resume/pull/3459), open and intentionally unmerged; diff --git a/docs/execution/briefs/fix-review-plan-07-round2.md b/docs/execution/briefs/fix-review-plan-07-round2.md new file mode 100644 index 000000000..efc957e12 --- /dev/null +++ b/docs/execution/briefs/fix-review-plan-07-round2.md @@ -0,0 +1,21 @@ +# Plan 07 late hosted-review fix + +Work in `/Users/amruth/orca/workspaces/reactive-resume/issue-2722-postgres-docs` on +`codex/issue-2722-postgres-docs`. Current remote/local head should be +`a7b8c4cc5754c1249534d0ed8993e67e57e2cb87`; PR #3457 stays open and unmerged. + +Read current instructions, pinned approved Plan 07, all implementation/review reports, complete `origin/main...HEAD` +diff, and live PR thread `PRRT_kwDODuah5s6fnaBa` / comment `3942253797`. Revalidate current base/head/checks first. +Run root Intent inventory before edit. Do not spawn subagents. + +Finding: numbered update flow is correctly introduced as image-quickstart-only, and repository alternative already uses +`reactive_resume`; however repository users following that alternative can continue to image-only step 4 and run logs +against nonexistent `reactive-resume`. Make path separation unmistakable and provide correct repository log command +`docker compose logs -f reactive_resume` adjacent to its build update. Preserve image commands and app-only `--no-deps` +policy; do not widen into dependency lifecycle or PostgreSQL upgrade changes. + +Use minimal docs edit. Validate both Compose service names/commands against current files, run Compose dry-runs, +PostgreSQL/docs gates proportionate to changed claim, Markdown/link/command/diff/exact-scope checks. Commit locally with +normal message. Do not push, reply, resolve thread, mutate issue, or merge. Write +`.orchestration/plan-07-hosted-review-fix-round2.md` and send worker_done. +