Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2026-10-03 10:13:47 +10:00
Code Issues Packages Projects Releases Wiki Activity

fix(web): preserve dialogs opened during close animations

Browse Source 
Opening another dialog during the previous dialog's 300 ms close animation could clear the new dialog and its close handler. This caused the post-merge dashboard lifecycle test to lose the Duplicate Resume dialog after renaming a resume.

- Scope delayed cleanup to the original dialog and require it to remain closed.
- Add regression coverage for both open and closing replacement dialogs; both cases failed before the fix and pass afterward.
- Include the fix in the v5.3.1 release notes.

Validation: `pnpm check`, `pnpm typecheck`, `pnpm test`, and the focused dialog-store suite (12 passing tests).
This commit is contained in:
Amruth Pillai
2026-09-17 12:19:06 +02:00
committed by GitHub
parent 24d9e5fb5c
commit 582a6fb429
3 changed files with 30 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/changelog/index.mdx
+4
View File
@@ -11,6 +11,10 @@ rss: true
- **Manage your cover-letter library through MCP.** Connected assistants can now create, read, update, duplicate, delete, import, and export independent cover letters, refresh their styling from a resume, or copy an embedded letter into the library. Revision checks protect newer edits from being overwritten. Thanks to [@emanuelet](https://github.com/emanuelet). [e6a6bf0e6](https://github.com/reactive-resume/reactive-resume/commit/e6a6bf0e6)
- **Explore the redesigned homepage.** Try interactive resume, export, and ATS previews, browse templates, and discover supported languages before opening the builder. [6416da28a](https://github.com/reactive-resume/reactive-resume/commit/6416da28a)
## Resume Builder
- Fixed newly opened dialogs disappearing when another dialog had just closed, including duplicating a resume immediately after renaming it. [0c2d5ac9f](https://github.com/reactive-resume/reactive-resume/commit/0c2d5ac9f)
## PDF Export & Templates
- Fixed list indentation when an item continues onto another page, including nested lists and numbered lists with wider markers. Thanks to [@santhiprakash](https://github.com/santhiprakash). [51ac77295](https://github.com/reactive-resume/reactive-resume/commit/51ac77295)