From 591c9a6ccfe6db823db4feae80d2fe066d7570c3 Mon Sep 17 00:00:00 2001
From: Amruth Pillai <im.amruth@gmail.com>
Date: Mon, 13 Jul 2020 16:03:15 +0530
Subject: [PATCH] - remove eslint from functions project

---
 functions/.eslintrc.json | 123 ---------------------------------------
 functions/index.js       |   8 +--
 functions/package.json   |   4 --
 3 files changed, 4 insertions(+), 131 deletions(-)
 delete mode 100644 functions/.eslintrc.json

diff --git a/functions/.eslintrc.json b/functions/.eslintrc.json
deleted file mode 100644
index 6b6beb65..00000000
--- a/functions/.eslintrc.json
+++ /dev/null
@@ -1,123 +0,0 @@
-{
-  "parserOptions": {
-    // Required for certain syntax usages
-    "ecmaVersion": 2017
-  },
-  "plugins": [
-    "promise"
-  ],
-  "extends": "eslint:recommended",
-  "rules": {
-    // Removed rule "disallow the use of console" from recommended eslint rules
-    "no-console": "off",
-
-    // Removed rule "disallow multiple spaces in regular expressions" from recommended eslint rules
-    "no-regex-spaces": "off",
-
-    // Removed rule "disallow the use of debugger" from recommended eslint rules
-    "no-debugger": "off",
-
-    // Removed rule "disallow unused variables" from recommended eslint rules
-    "no-unused-vars": "off",
-
-    // Removed rule "disallow mixed spaces and tabs for indentation" from recommended eslint rules
-    "no-mixed-spaces-and-tabs": "off",
-
-    // Removed rule "disallow the use of undeclared variables unless mentioned in /*global */ comments" from recommended eslint rules
-    "no-undef": "off",
-
-    // Warn against template literal placeholder syntax in regular strings
-    "no-template-curly-in-string": 1,
-
-    // Warn if return statements do not either always or never specify values
-    "consistent-return": 1,
-
-    // Warn if no return statements in callbacks of array methods
-    "array-callback-return": 1,
-
-    // Require the use of === and !==
-    "eqeqeq": 2,
-
-    // Disallow the use of alert, confirm, and prompt
-    "no-alert": 2,
-
-    // Disallow the use of arguments.caller or arguments.callee
-    "no-caller": 2,
-
-    // Disallow null comparisons without type-checking operators
-    "no-eq-null": 2,
-
-    // Disallow the use of eval()
-    "no-eval": 2,
-
-    // Warn against extending native types
-    "no-extend-native": 1,
-
-    // Warn against unnecessary calls to .bind()
-    "no-extra-bind": 1,
-
-    // Warn against unnecessary labels    
-    "no-extra-label": 1,
-
-    // Disallow leading or trailing decimal points in numeric literals
-    "no-floating-decimal": 2,
-
-    // Warn against shorthand type conversions
-    "no-implicit-coercion": 1,
-
-    // Warn against function declarations and expressions inside loop statements
-    "no-loop-func": 1,
-
-    // Disallow new operators with the Function object
-    "no-new-func": 2,
-
-    // Warn against new operators with the String, Number, and Boolean objects
-    "no-new-wrappers": 1,
-
-    // Disallow throwing literals as exceptions
-    "no-throw-literal": 2,
-
-    // Require using Error objects as Promise rejection reasons
-    "prefer-promise-reject-errors": 2,
-
-    // Enforce “for” loop update clause moving the counter in the right direction
-    "for-direction": 2,
-
-    // Enforce return statements in getters
-    "getter-return": 2,
-
-    // Disallow await inside of loops
-    "no-await-in-loop": 2,
-
-    // Disallow comparing against -0
-    "no-compare-neg-zero": 2,
-
-    // Warn against catch clause parameters from shadowing variables in the outer scope
-    "no-catch-shadow": 1,
-
-    // Disallow identifiers from shadowing restricted names
-    "no-shadow-restricted-names": 2,
-
-    // Enforce return statements in callbacks of array methods
-    "callback-return": 2,
-
-    // Require error handling in callbacks
-    "handle-callback-err": 2,
-
-    // Warn against string concatenation with __dirname and __filename
-    "no-path-concat": 1,
-
-    // Prefer using arrow functions for callbacks
-    "prefer-arrow-callback": 1,
-
-    // Return inside each then() to create readable and reusable Promise chains.
-    // Forces developers to return console logs and http calls in promises. 
-    "promise/always-return": 2,
-
-    //Enforces the use of catch() on un-returned promises
-    "promise/catch-or-return": 2,
-
-    // Warn against nested then() or catch() statements
-    "promise/no-nesting": 1
-  }
-}
diff --git a/functions/index.js b/functions/index.js
index d7833f5e..75cc8d06 100644
--- a/functions/index.js
+++ b/functions/index.js
@@ -24,10 +24,10 @@ exports.printSinglePageResume = functions.https.onRequest((req, res) => {
     await timeout(5000);
     await page.emulateMediaType('print');
     const height = await page.evaluate(() => {
-      var body = document.body,
-        html = document.documentElement;
+      const { body } = document;
+      const html = document.documentElement;
 
-      var height = Math.max(
+      const maxHeight = Math.max(
         body.scrollHeight,
         body.offsetHeight,
         html.clientHeight,
@@ -35,7 +35,7 @@ exports.printSinglePageResume = functions.https.onRequest((req, res) => {
         html.offsetHeight,
       );
 
-      return height;
+      return maxHeight;
     });
     const pdf = await page.pdf({
       printBackground: true,
diff --git a/functions/package.json b/functions/package.json
index a37d6ed3..bed9f8e5 100644
--- a/functions/package.json
+++ b/functions/package.json
@@ -2,7 +2,6 @@
   "name": "functions",
   "description": "Cloud Functions for Firebase",
   "scripts": {
-    "lint": "eslint .",
     "serve": "firebase emulators:start --only functions",
     "shell": "firebase functions:shell",
     "start": "npm run shell",
@@ -14,13 +13,10 @@
   },
   "dependencies": {
     "cors": "^2.8.5",
-    "firebase-admin": "^8.13.0",
     "firebase-functions": "^3.7.0",
     "puppeteer": "^5.1.0"
   },
   "devDependencies": {
-    "eslint": "^7.4.0",
-    "eslint-plugin-promise": "^4.2.1",
     "firebase-functions-test": "^0.2.1"
   },
   "private": true