From 5c7d03b72dd35ff45fa67cc9edc465bdf3f673b6 Mon Sep 17 00:00:00 2001 From: Amruth Pillai Date: Sun, 6 Sep 2026 00:27:41 +0200 Subject: [PATCH] docs: track plan 11 hosted review follow-up --- docs/execution/approved-issue-plans-ledger.md | 3 ++- .../briefs/rereview-plan-11-hosted-comments.md | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 docs/execution/briefs/rereview-plan-11-hosted-comments.md diff --git a/docs/execution/approved-issue-plans-ledger.md b/docs/execution/approved-issue-plans-ledger.md index 85259353d..954f6b1df 100644 --- a/docs/execution/approved-issue-plans-ledger.md +++ b/docs/execution/approved-issue-plans-ledger.md @@ -43,7 +43,7 @@ state changes are outside scope. | 08 root public resume | #2669 | plan amendment required before implementation | audit `task_9f27829ca50f` | planned `codex/issue-2669-root-resume` | `7a98f6662` → — | none | current password redirect rejects `/`; public view is slug-hook-bound; SSR canonical cannot import server env; expanded auth/canonical contract identified | audit focused API/web suites, typechecks, boundaries passed | — | amend ownership for identity-vs-return auth flow and server-derived canonical root, then dispatch coherent feature | engineering scope correction; feature remains narrower than arbitrary domain/TLS registry | | 09 external version backup | #2705 | published; hosted correction under review | review `task_a44e374822b4` / `ctx_89e6769df19d` | `codex/issue-2705-git-backup-docs` | `7a98f6662` → published `6931d2cc4`; local `2d3ca10` | none | clean pre-publication review; hosted bots correctly found `HEAD` could not select earlier revision; selected-commit commands committed locally | 152 focused tests plus Markdown/diff/base/scope green; hosted correction Markdown/diff green | [#3458](https://github.com/amruthpillai/reactive-resume/pull/3458) | finish independent correction review, push, resolve duplicate threads | DB integration/E2E unavailable; no sync/remote/whole-account restore | | 10 legacy link routing | #2836 | pending implementation after brief correction | audit `task_9f27829ca50f` | planned `codex/issue-2836-retired-slug-notices` | `7a98f6662` → — | none | prospective same-username slug-attempt notice remains coherent; exact DB/API/UI/E2E owner set verified | audit focused API/web suites, DB/API/web typechecks, boundaries passed | — | correct final E2E target to `public-sharing.spec.ts`, then implement migration/API/owner UI atomically | historical cause absent; no redirects/emails/recovery; prospective partial coverage only | -| 11 job search policy | #3010 | published | implementation/review chain complete | `codex/issue-3010-jsearch-docs` | `7a98f6662` → `e05977007` | none | attachment overclaim removed, guidance deduplicated, and clean independent re-review completed | fresh 52 focused tests plus Markdown/diff/base/scope green | [#3459](https://github.com/amruthpillai/reactive-resume/pull/3459) | monitor hosted checks/review; keep unmerged | real provider/browser optional gate unavailable; removal motive unknown | +| 11 job search policy | #3010 | published; hosted wording correction queued | hosted re-review `task_a9d8b3e0a8a2` | `codex/issue-3010-jsearch-docs` | `7a98f6662` → published `e05977007`; local `1d03978` | none | clean independent publication review; two valid low-risk hosted wording comments corrected locally | 52 focused tests plus Markdown/diff/base/scope green; follow-up Markdown/link/diff green | [#3459](https://github.com/amruthpillai/reactive-resume/pull/3459) | independently review correction, push, resolve threads | real provider/browser optional gate unavailable; removal motive unknown | | 12 preview/export failures | #3323, #3290, #3033, #3007, #2609 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer ownership; share observation harness with 18 | zero drift; staged-preview/error-boundary baselines remain; reports cross persistence/font/PDF/viewer/deployment boundaries | audit focused web/PDF suites, affected typechecks, boundaries, build passed | — | isolate PT Sans, browser/config, and template-selection boundaries; no shared fix | exact JSON/output/browser/config/current reproduction missing | | 13 font/glyph/spacing | #3249, #3159, #3147, #3093, #3089, #2988 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize font sources with 14/27 | merged metrics/cache/Unicode fixes present and passing; residuals require per-font/per-symptom fixtures | audit focused PDF/font suites, affected typechecks, boundaries, build passed | — | retain regressions; create residual unit only from exact failing font fixture | missing Ropa Sans/source strings/font hashes/before-after artifacts | | 14 RTL export layout | #3275 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize renderer/fonts with 13/27 | merged canvas-direction fix remains; broader shaping/bidi cause unproved | audit RTL/preview suites, affected typechecks, boundaries, build passed | — | run controlled same-bytes export matrix against approved shaping oracle | exact JSON/font/version and known-good reference absent | @@ -96,6 +96,7 @@ state changes are outside scope. | Plan 11 independent review | `task_7d5d4c1417a9` / `ctx_17ee05faf9e7` | same Plan 11 worktree | complete; changes required | attachment-format overclaim and duplicated patch/restore guidance | | Plan 11 review fix | `task_351a96e90b69` / `ctx_e398c9128731` | same Plan 11 worktree | complete; worker released | commit `e05977007`; attachment promise removed and adjacent guidance deduplicated | | Plan 11 re-review | `task_86a66b578544` / `ctx_3bb8017e8676` | same Plan 11 worktree | complete; no findings; worker released | exact head `e05977007`; 52 focused tests and full diff verified before PR #3459 | +| Plan 11 hosted review follow-up | `task_a9d8b3e0a8a2` | same Plan 11 worktree | local fix committed; review queued | commit `1d03978`; sample wording plus heading/UI terminology alignment | | Plan 15A implementation | `task_557902c8adef` / `ctx_db6fae1b75c4` | `codex/issue-2782-picture-fit` | implementing | explicit cover/contain contract across schema/editor/preview/PDF | | Plan 07 hosted review follow-up | `task_6e9bc84ca2d4` / `ctx_e31d0e345240` | `codex/issue-2722-postgres-docs` | no findings; pushed; worker released | commit `a7b8c4c`; five valid comments fixed, `--no-deps` removal rejected; six replies and zero unresolved threads | diff --git a/docs/execution/briefs/rereview-plan-11-hosted-comments.md b/docs/execution/briefs/rereview-plan-11-hosted-comments.md new file mode 100644 index 000000000..b47432c17 --- /dev/null +++ b/docs/execution/briefs/rereview-plan-11-hosted-comments.md @@ -0,0 +1,15 @@ +# Independently re-review plan 11 hosted-review corrections + +Review only. Read pinned approved plan 11, current `AGENTS.md`, RTK, applicable code-review skill, all Plan 11 reports, +and two inline comments on PR #3459. Review complete `origin/main...HEAD` diff at current head. + +Verify both hosted wording corrections are coherent: user-facing example uses accessible “sample” terminology without +weakening fictional-data safety, and section/link text “Review edits and patches” aligns with exact **Review edits** UI +label while still covering patch inspection and restore. Verify anchor resolution and no stale `#review-patches` links. +Revalidate previous attachment, history, provider capability, isolated AI Draft, patch/restore, scope, and no-invented- +motive findings. + +Run fresh base/live PR/thread state, relevant source probes and focused tests, Markdown/link/diff/three-doc scope gates. +Write `.orchestration/plan-11-hosted-review-rereview.md` with findings first, exact head, commands/results, skipped gates, +risks, and push/thread-resolution verdict. Do not edit tracked files, push, merge, resolve threads, mutate issues, or spawn +subagents. Final response at most ten lines.