From 5d146ca86e28b6ad3030b74876421c01c6c5ac3b Mon Sep 17 00:00:00 2001 From: Samrat Saha Date: Fri, 2 Feb 2024 00:52:50 +0530 Subject: [PATCH] fix(#1750): fixed downloaded PDF have issue(s) with Typography options Typography option toggle class were added in DOM #root but when server is printing the resume, a child section of the DOM #root is cloned and inserted for pdf processing which miss out the Typography option toggle class in the parent DOM, resulting in bug, Thus, the same class were added to each cloned DOM node. --- apps/artboard/src/pages/artboard.tsx | 15 ++++----------- apps/artboard/src/styles/main.css | 4 ++-- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/apps/artboard/src/pages/artboard.tsx b/apps/artboard/src/pages/artboard.tsx index 0504b954..58a79bbb 100644 --- a/apps/artboard/src/pages/artboard.tsx +++ b/apps/artboard/src/pages/artboard.tsx @@ -49,17 +49,10 @@ export const ArtboardPage = () => { // Typography Options useEffect(() => { - if (metadata.typography.hideIcons) { - document.querySelector("#root")!.classList.add("hide-icons"); - } else { - document.querySelector("#root")!.classList.remove("hide-icons"); - } - - if (metadata.typography.underlineLinks) { - document.querySelector("#root")!.classList.add("underline-links"); - } else { - document.querySelector("#root")!.classList.remove("underline-links"); - } + document.querySelectorAll(`[data-page]`).forEach((el) => { + el.classList.toggle("hide-icons", metadata.typography.hideIcons); + el.classList.toggle("underline-links", metadata.typography.underlineLinks); + }); }, [metadata]); return ; diff --git a/apps/artboard/src/styles/main.css b/apps/artboard/src/styles/main.css index c6c95180..7903d7d8 100644 --- a/apps/artboard/src/styles/main.css +++ b/apps/artboard/src/styles/main.css @@ -12,11 +12,11 @@ @apply antialiased; } -#root.hide-icons .ph { +[data-page].hide-icons .ph { @apply hidden; } -#root.underline-links a { +[data-page].underline-links a { @apply underline underline-offset-2; }