Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2025-11-13 00:03:27 +10:00
Code Issues Packages Projects Releases Wiki Activity

fix(#1750): fixed downloaded PDF have issue(s) with Typography options

Browse Source 
Typography option toggle class were added in DOM #root but when server is printing the resume, a child section of the DOM #root is cloned and inserted for pdf processing which miss out the Typography option toggle class in the parent DOM, resulting in bug, Thus, the same class were added to each cloned DOM node.
This commit is contained in:
Samrat Saha
2024-02-02 00:52:50 +05:30
parent e9ec397663
commit 5d146ca86e
2 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
apps/artboard/src/pages/artboard.tsx
View File

@ -49,17 +49,10 @@ export const ArtboardPage = () => {
// Typography Options
useEffect(() => {
if (metadata.typography.hideIcons) {
document.querySelector("#root")!.classList.add("hide-icons");
} else {
document.querySelector("#root")!.classList.remove("hide-icons");
}
if (metadata.typography.underlineLinks) {
document.querySelector("#root")!.classList.add("underline-links");
} else {
document.querySelector("#root")!.classList.remove("underline-links");
}
document.querySelectorAll(`[data-page]`).forEach((el) => {
el.classList.toggle("hide-icons", metadata.typography.hideIcons);
el.classList.toggle("underline-links", metadata.typography.underlineLinks);
});
}, [metadata]);
return <Outlet />;

4
apps/artboard/src/styles/main.css
View File

@ -12,11 +12,11 @@
@apply antialiased;
}
#root.hide-icons .ph {
[data-page].hide-icons .ph {
@apply hidden;
}
#root.underline-links a {
[data-page].underline-links a {
@apply underline underline-offset-2;
}