From 5f53956fae50ad0ad2c8ec814071e37995724960 Mon Sep 17 00:00:00 2001 From: Amruth Pillai Date: Sun, 6 Sep 2026 01:15:51 +0200 Subject: [PATCH] docs: queue plan 15a final rereview --- docs/execution/approved-issue-plans-ledger.md | 5 ++-- docs/execution/briefs/rereview-plan-15a.md | 27 +++++++++++++++++++ 2 files changed, 30 insertions(+), 2 deletions(-) create mode 100644 docs/execution/briefs/rereview-plan-15a.md diff --git a/docs/execution/approved-issue-plans-ledger.md b/docs/execution/approved-issue-plans-ledger.md index 7ded7e09d..bc7109b74 100644 --- a/docs/execution/approved-issue-plans-ledger.md +++ b/docs/execution/approved-issue-plans-ledger.md @@ -47,7 +47,7 @@ state changes are outside scope. | 12 preview/export failures | #3323, #3290, #3033, #3007, #2609 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer ownership; share observation harness with 18 | zero drift; staged-preview/error-boundary baselines remain; reports cross persistence/font/PDF/viewer/deployment boundaries | audit focused web/PDF suites, affected typechecks, boundaries, build passed | — | isolate PT Sans, browser/config, and template-selection boundaries; no shared fix | exact JSON/output/browser/config/current reproduction missing | | 13 font/glyph/spacing | #3249, #3159, #3147, #3093, #3089, #2988 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize font sources with 14/27 | merged metrics/cache/Unicode fixes present and passing; residuals require per-font/per-symptom fixtures | audit focused PDF/font suites, affected typechecks, boundaries, build passed | — | retain regressions; create residual unit only from exact failing font fixture | missing Ropa Sans/source strings/font hashes/before-after artifacts | | 14 RTL export layout | #3275 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize renderer/fonts with 13/27 | merged canvas-direction fix remains; broader shaping/bidi cause unproved | audit RTL/preview suites, affected typechecks, boundaries, build passed | — | run controlled same-bytes export matrix against approved shaping oracle | exact JSON/font/version and known-good reference absent | -| 15 picture fitting/style | #3168, #3088, #2794, #2782 | fixing 15A review findings; other causes blocked | fix `task_5a4afecb7d0d` / `ctx_43faac4f25eb` | `codex/issue-2782-picture-fit` | `7a98f6662` → `d891afd66` | coordinate 06/25; schema/PDF owner exclusion | runtime Cover/Contain behavior passed review; geometry regression was too weak and UI tests coupled to Tailwind class | full repo tests; focused suites/typechecks/boundaries/build; 2 authenticated raster E2E green before test-strength finding | — | pin Cover/Contain geometry and behavioral CSS assertions, deduplicate props, then rereview | delivery/centering issues still lack source revisions/assets/expected crop | +| 15 picture fitting/style | #3168, #3088, #2794, #2782 | rereviewing 15A; other causes blocked | review `task_2b45ae3b4e98` / `ctx_695a139cd0b9` | `codex/issue-2782-picture-fit` | `7a98f6662` → `6145d5a59` | coordinate 06/25; schema/PDF owner exclusion | Cover/Contain geometry, computed CSS behavior, and shared props review findings fixed via mutation-tested TDD | full 19-task suite; affected typechecks/build/boundaries; docs/catalogs; 2 authenticated raster E2E green; rereview active | — | clean full-diff rereview, fresh coordinator verification, publish #2782-only PR | delivery/centering issues still lack source revisions/assets/expected crop | | 16 imported table borders | #3196 | implementing | `task_f3d05a6ebb86` / `ctx_686ba93fc8af` | `codex/issue-3196-editable-tables` | `7a98f6662` → work active | rich-text owner; must precede 19/31 | editor lacks table extensions; Q11 approves editable supported tables; atomic editor/HTML/PDF unit dispatched in isolated worktree | audit baseline green; implementation TDD and E2E running | — | complete atomic editor/HTML/PDF implementation, verify, commit, independently review | historical visual equivalence lacks reporter HTML/JSON but feature contract is approved | | 17 list/skill pagination | #2751, #3040 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer owner shared with 13/14/18 | merged ordered-marker/wrap/level-gap fixes present; current residual not reproduced | audit focused PDF suites, typecheck, boundaries, build passed | — | retain controls; add fix only from exact failing list/skill fixture | #2751 source absent; #3040 current fixture no longer proves residual clipping | | 18 preview/export geometry | #2683 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | share output-boundary harness with 12; viewer owner exclusion | current viewport/page-size/margin baselines pass; video alone cannot locate cause | audit page/preview tests, affected typechecks, boundaries, build passed | — | compare identical preview/download bytes, MediaBoxes, ink bounds, viewport, DPR | exact JSON/PDF/browser/DPR/zoom/page settings absent | @@ -107,7 +107,8 @@ state changes are outside scope. | Plan 11 hosted review follow-up | `task_a9d8b3e0a8a2` / `ctx_6b03ba8f389c` | same Plan 11 worktree | no findings; pushed; worker released | commit `1d03978`; sample wording plus heading/UI terminology alignment; all hosted checks green and both threads resolved | | Plan 15A implementation | `task_557902c8adef` / `ctx_db6fae1b75c4` | `codex/issue-2782-picture-fit` | complete; worker released | commit `d891afd66`; explicit cover/contain contract across schema/editor/preview/PDF | | Plan 15A independent review | `task_d4f4841355e2` / `ctx_467f293cf443` | same Plan 15A worktree | complete; changes required; worker released | medium: raster checks did not pin fit geometry; low: class coupling and duplicate props type | -| Plan 15A review fix | `task_5a4afecb7d0d` / `ctx_43faac4f25eb` | same Plan 15A worktree | implementing | strengthen Cover/Contain geometry and behavioral assertions, consolidate props type, rerun raster E2E | +| Plan 15A review fix | `task_5a4afecb7d0d` / `ctx_43faac4f25eb` | same Plan 15A worktree | complete; worker released | commit `6145d5a59`; all three findings fixed; full tests/build and authenticated raster E2E green | +| Plan 15A final rereview | `task_2b45ae3b4e98` / `ctx_695a139cd0b9` | same Plan 15A worktree | reviewing | full 70-file behavior, mutation-sensitive geometry, computed CSS, compatibility and issue scope | | Plan 07 hosted review follow-up | `task_6e9bc84ca2d4` / `ctx_e31d0e345240` | `codex/issue-2722-postgres-docs` | no findings; pushed; worker released | commit `a7b8c4c`; five valid comments fixed, `--no-deps` removal rejected; six replies and zero unresolved threads | | Plan 07 late hosted fix | `task_6d0545ee43b1` / `ctx_1d6a1e36def3` | same Plan 07 worktree | complete; worker released | commit `171637526`; separate image/repository build and log paths; Compose/docs gates green | | Plan 07 late fix rereview | `task_8ff818f3e95a` / `ctx_b73be2273e01` | same Plan 07 worktree | reviewing | independent full-diff and Compose validation before corrected head publication | diff --git a/docs/execution/briefs/rereview-plan-15a.md b/docs/execution/briefs/rereview-plan-15a.md new file mode 100644 index 000000000..cc0711bed --- /dev/null +++ b/docs/execution/briefs/rereview-plan-15a.md @@ -0,0 +1,27 @@ +# Independent rereview: Plan 15A picture fit + +Review only in `/Users/amruth/orca/workspaces/reactive-resume/issue-2782-picture-fit`. +Exact target head: `6145d5a5925373287b87dfaa30ab675ebc84e105`. +No PR or remote branch exists. Do not edit tracked files, commit, push, publish, merge, or mutate issues. + +Read current instructions, pinned approved Plan 15, complete `origin/main...HEAD` diff, implementation/review/fix reports, +live issue #2782 and open PR overlap. Refresh base and verify target head. Review all 70-file behavior, not only fix commit. + +Independently verify every prior finding: + +- Cover raster pins legacy centered crop geometry for landscape, portrait, and square control with explicit retained/cropped + edges and symmetric bounds; +- Contain asserts expected fitted bitmap dimensions and centering within one pixel, including border/shadow branches; +- mutation sensitivity proves wrong object-position or scale fails tests; +- sidebar and Playwright assert computed `object-fit`, not Tailwind class presence; +- props type duplication is removed without weakening named-props convention. + +Reconfirm Cover default, Contain original-file upload, schema/import compatibility, autosave/undo/error/cancel/lock flows, +all-template shared PDF consumption, semantic CSS precedence, locale/docs/reference completeness, exact issue #2782 scope, +and no claims for other Plan 15 issues. + +Run focused and full affected suites, affected typechecks, boundaries, narrow non-writing Biome, docs/catalog gates, +production build, and authenticated raster E2E with disposable DB/local storage. Inspect output geometry/artifacts. Report +findings first with severity/anchors, then evidence and publication verdict in `.orchestration/plan-15a-rereview.md`. +Send worker_done. No subagents. +