From 8202ca5461473234cb8887e2a02701ba47186d2d Mon Sep 17 00:00:00 2001
From: gianantoniopini <63844628+gianantoniopini@users.noreply.github.com>
Date: Mon, 4 Jan 2021 10:42:41 +0100
Subject: [PATCH] FirebaseStub refactoring

---
 .../__tests__/gatsby-plugin-firebase.test.js  | 22 +++++++++++-------
 __mocks__/gatsby-plugin-firebase.js           | 23 +++++++++++--------
 src/pages/app/__tests__/builder.test.js       |  2 +-
 src/templates/__tests__/Castform.test.js      |  2 +-
 4 files changed, 29 insertions(+), 20 deletions(-)

diff --git a/__mocks__/__tests__/gatsby-plugin-firebase.test.js b/__mocks__/__tests__/gatsby-plugin-firebase.test.js
index 3714eb23..624644bf 100644
--- a/__mocks__/__tests__/gatsby-plugin-firebase.test.js
+++ b/__mocks__/__tests__/gatsby-plugin-firebase.test.js
@@ -110,12 +110,18 @@ describe('FirebaseStub', () => {
       const resumes = resumesDataSnapshot.val();
       expect(resumes).toBeTruthy();
       expect(Object.keys(resumes).length).toEqual(2);
-      const demoResume = resumes[FirebaseStub.database().demoResumeId];
-      expect(demoResume).toBeTruthy();
-      expect(demoResume.id).toEqual(FirebaseStub.database().demoResumeId);
-      const emptyResume = resumes[FirebaseStub.database().emptyResumeId];
-      expect(emptyResume).toBeTruthy();
-      expect(emptyResume.id).toEqual(FirebaseStub.database().emptyResumeId);
+      const demoStateResume =
+        resumes[FirebaseStub.database().demoStateResumeId];
+      expect(demoStateResume).toBeTruthy();
+      expect(demoStateResume.id).toEqual(
+        FirebaseStub.database().demoStateResumeId,
+      );
+      const initialStateResume =
+        resumes[FirebaseStub.database().initialStateResumeId];
+      expect(initialStateResume).toBeTruthy();
+      expect(initialStateResume.id).toEqual(
+        FirebaseStub.database().initialStateResumeId,
+      );
 
       const usersRef = FirebaseStub.database().ref(usersPath);
       const usersDataSnapshot = await usersRef.once('value');
@@ -132,12 +138,12 @@ describe('FirebaseStub', () => {
 
       const resume = (
         await FirebaseStub.database()
-          .ref(`${resumesPath}/${FirebaseStub.database().demoResumeId}`)
+          .ref(`${resumesPath}/${FirebaseStub.database().demoStateResumeId}`)
           .once('value')
       ).val();
 
       expect(resume).toBeTruthy();
-      expect(resume.id).toEqual(FirebaseStub.database().demoResumeId);
+      expect(resume.id).toEqual(FirebaseStub.database().demoStateResumeId);
     });
 
     it('retrieves null if resume does not exist', async () => {
diff --git a/__mocks__/gatsby-plugin-firebase.js b/__mocks__/gatsby-plugin-firebase.js
index eece5f36..8678a132 100644
--- a/__mocks__/gatsby-plugin-firebase.js
+++ b/__mocks__/gatsby-plugin-firebase.js
@@ -65,8 +65,8 @@ class Database {
   #data = {};
   #references = {};
   #anonymousUser = undefined;
-  #demoResumeId = 'demore';
-  #emptyResumeId = 'mtre01';
+  #demoStateResumeId = 'demost';
+  #initialStateResumeId = 'initst';
 
   constructor() {
     if (Database.#instance) {
@@ -94,11 +94,12 @@ class Database {
     return this.#anonymousUser;
   }
 
-  get demoResumeId() {
-    return this.#demoResumeId;
+  get demoStateResumeId() {
+    return this.#demoStateResumeId;
   }
-  get emptyResumeId() {
-    return this.#emptyResumeId;
+
+  get initialStateResumeId() {
+    return this.#initialStateResumeId;
   }
 
   get uuid() {
@@ -114,10 +115,12 @@ class Database {
 
   initializeData() {
     const resumes = {};
-    const demoResume = Database.readFile('../src/data/demoState.json');
-    resumes[this.demoResumeId] = demoResume;
-    const emptyResume = Database.readFile('../src/data/initialState.json');
-    resumes[this.emptyResumeId] = emptyResume;
+    const demoStateResume = Database.readFile('../src/data/demoState.json');
+    resumes[this.demoStateResumeId] = demoStateResume;
+    const initialStateResume = Database.readFile(
+      '../src/data/initialState.json',
+    );
+    resumes[this.initialStateResumeId] = initialStateResume;
 
     for (var key in resumes) {
       const resume = resumes[key];
diff --git a/src/pages/app/__tests__/builder.test.js b/src/pages/app/__tests__/builder.test.js
index 295f359c..45ceaec6 100644
--- a/src/pages/app/__tests__/builder.test.js
+++ b/src/pages/app/__tests__/builder.test.js
@@ -33,7 +33,7 @@ describe('builder', () => {
   let container = null;
 
   beforeEach(async () => {
-    resumeId = FirebaseStub.database().demoResumeId;
+    resumeId = FirebaseStub.database().demoStateResumeId;
     resume = (
       await FirebaseStub.database()
         .ref(`${resumesPath}/${resumeId}`)
diff --git a/src/templates/__tests__/Castform.test.js b/src/templates/__tests__/Castform.test.js
index e035bf3f..b5779be5 100644
--- a/src/templates/__tests__/Castform.test.js
+++ b/src/templates/__tests__/Castform.test.js
@@ -11,7 +11,7 @@ describe('Castform', () => {
   beforeEach(async () => {
     FirebaseStub.database().initializeData();
     const resumesPath = FirebaseStub.database().resumesPath;
-    const resumeId = FirebaseStub.database().emptyResumeId;
+    const resumeId = FirebaseStub.database().initialStateResumeId;
     resume = (
       await FirebaseStub.database()
         .ref(`${resumesPath}/${resumeId}`)