FirebaseStub refactoring

This commit is contained in:
gianantoniopini
2021-01-04 10:42:41 +01:00
parent 2e346c93eb
commit 8202ca5461
4 changed files with 29 additions and 20 deletions

View File

@ -110,12 +110,18 @@ describe('FirebaseStub', () => {
const resumes = resumesDataSnapshot.val(); const resumes = resumesDataSnapshot.val();
expect(resumes).toBeTruthy(); expect(resumes).toBeTruthy();
expect(Object.keys(resumes).length).toEqual(2); expect(Object.keys(resumes).length).toEqual(2);
const demoResume = resumes[FirebaseStub.database().demoResumeId]; const demoStateResume =
expect(demoResume).toBeTruthy(); resumes[FirebaseStub.database().demoStateResumeId];
expect(demoResume.id).toEqual(FirebaseStub.database().demoResumeId); expect(demoStateResume).toBeTruthy();
const emptyResume = resumes[FirebaseStub.database().emptyResumeId]; expect(demoStateResume.id).toEqual(
expect(emptyResume).toBeTruthy(); FirebaseStub.database().demoStateResumeId,
expect(emptyResume.id).toEqual(FirebaseStub.database().emptyResumeId); );
const initialStateResume =
resumes[FirebaseStub.database().initialStateResumeId];
expect(initialStateResume).toBeTruthy();
expect(initialStateResume.id).toEqual(
FirebaseStub.database().initialStateResumeId,
);
const usersRef = FirebaseStub.database().ref(usersPath); const usersRef = FirebaseStub.database().ref(usersPath);
const usersDataSnapshot = await usersRef.once('value'); const usersDataSnapshot = await usersRef.once('value');
@ -132,12 +138,12 @@ describe('FirebaseStub', () => {
const resume = ( const resume = (
await FirebaseStub.database() await FirebaseStub.database()
.ref(`${resumesPath}/${FirebaseStub.database().demoResumeId}`) .ref(`${resumesPath}/${FirebaseStub.database().demoStateResumeId}`)
.once('value') .once('value')
).val(); ).val();
expect(resume).toBeTruthy(); expect(resume).toBeTruthy();
expect(resume.id).toEqual(FirebaseStub.database().demoResumeId); expect(resume.id).toEqual(FirebaseStub.database().demoStateResumeId);
}); });
it('retrieves null if resume does not exist', async () => { it('retrieves null if resume does not exist', async () => {

View File

@ -65,8 +65,8 @@ class Database {
#data = {}; #data = {};
#references = {}; #references = {};
#anonymousUser = undefined; #anonymousUser = undefined;
#demoResumeId = 'demore'; #demoStateResumeId = 'demost';
#emptyResumeId = 'mtre01'; #initialStateResumeId = 'initst';
constructor() { constructor() {
if (Database.#instance) { if (Database.#instance) {
@ -94,11 +94,12 @@ class Database {
return this.#anonymousUser; return this.#anonymousUser;
} }
get demoResumeId() { get demoStateResumeId() {
return this.#demoResumeId; return this.#demoStateResumeId;
} }
get emptyResumeId() {
return this.#emptyResumeId; get initialStateResumeId() {
return this.#initialStateResumeId;
} }
get uuid() { get uuid() {
@ -114,10 +115,12 @@ class Database {
initializeData() { initializeData() {
const resumes = {}; const resumes = {};
const demoResume = Database.readFile('../src/data/demoState.json'); const demoStateResume = Database.readFile('../src/data/demoState.json');
resumes[this.demoResumeId] = demoResume; resumes[this.demoStateResumeId] = demoStateResume;
const emptyResume = Database.readFile('../src/data/initialState.json'); const initialStateResume = Database.readFile(
resumes[this.emptyResumeId] = emptyResume; '../src/data/initialState.json',
);
resumes[this.initialStateResumeId] = initialStateResume;
for (var key in resumes) { for (var key in resumes) {
const resume = resumes[key]; const resume = resumes[key];

View File

@ -33,7 +33,7 @@ describe('builder', () => {
let container = null; let container = null;
beforeEach(async () => { beforeEach(async () => {
resumeId = FirebaseStub.database().demoResumeId; resumeId = FirebaseStub.database().demoStateResumeId;
resume = ( resume = (
await FirebaseStub.database() await FirebaseStub.database()
.ref(`${resumesPath}/${resumeId}`) .ref(`${resumesPath}/${resumeId}`)

View File

@ -11,7 +11,7 @@ describe('Castform', () => {
beforeEach(async () => { beforeEach(async () => {
FirebaseStub.database().initializeData(); FirebaseStub.database().initializeData();
const resumesPath = FirebaseStub.database().resumesPath; const resumesPath = FirebaseStub.database().resumesPath;
const resumeId = FirebaseStub.database().emptyResumeId; const resumeId = FirebaseStub.database().initialStateResumeId;
resume = ( resume = (
await FirebaseStub.database() await FirebaseStub.database()
.ref(`${resumesPath}/${resumeId}`) .ref(`${resumesPath}/${resumeId}`)