From 82037d4cfee7f9790f5ffc8550cbc8ba6e0f303a Mon Sep 17 00:00:00 2001
From: Amruth Pillai <im.amruth@gmail.com>
Date: Mon, 30 Mar 2020 14:12:31 +0530
Subject: [PATCH] update and remove unnecessary translation strings

---
 src/components/LeftSidebar/tabs/Education.js         |  2 +-
 src/components/LeftSidebar/tabs/Profile.js           |  8 ++++----
 src/components/LeftSidebar/tabs/References.js        |  4 ++--
 src/components/RightSidebar/tabs/Templates.js        |  7 ++-----
 src/i18n/resources/en/app/app.json                   |  4 ++--
 src/i18n/resources/en/leftSidebar/awards.json        |  2 +-
 .../resources/en/leftSidebar/certifications.json     |  2 +-
 src/i18n/resources/en/leftSidebar/education.json     |  3 +--
 src/i18n/resources/en/leftSidebar/profile.json       | 12 ++++--------
 src/i18n/resources/en/leftSidebar/references.json    |  6 ++----
 src/i18n/resources/en/rightSidebar/templates.json    |  8 +-------
 src/templates/index.js                               |  4 ++++
 12 files changed, 25 insertions(+), 37 deletions(-)

diff --git a/src/components/LeftSidebar/tabs/Education.js b/src/components/LeftSidebar/tabs/Education.js
index 75c5675b..7a646937 100644
--- a/src/components/LeftSidebar/tabs/Education.js
+++ b/src/components/LeftSidebar/tabs/Education.js
@@ -78,7 +78,7 @@ const Form = ({ item, onChange, identifier = '' }) => {
       <TextField
         className="mb-6"
         label={t('education.grade.label')}
-        placeholder={t('education.grade.placeholder')}
+        placeholder="7.2 CGPA"
         value={item.grade}
         onChange={v => onChange(`${identifier}grade`, v)}
       />
diff --git a/src/components/LeftSidebar/tabs/Profile.js b/src/components/LeftSidebar/tabs/Profile.js
index 6f6fd3f0..3d0565e7 100644
--- a/src/components/LeftSidebar/tabs/Profile.js
+++ b/src/components/LeftSidebar/tabs/Profile.js
@@ -11,7 +11,7 @@ const ProfileTab = ({ data, onChange }) => {
       <TextField
         className="mb-6"
         label={t('profile.photoUrl.label')}
-        placeholder={t('profile.photoUrl.placeholder')}
+        placeholder="https://i.imgur.com/..."
         value={data.profile.photo}
         onChange={v => onChange('data.profile.photo', v)}
       />
@@ -73,7 +73,7 @@ const ProfileTab = ({ data, onChange }) => {
       <TextField
         className="mb-6"
         label={t('profile.phone.label')}
-        placeholder={t('profile.phone.placeholder')}
+        placeholder="+1 541 754 3010"
         value={data.profile.phone}
         onChange={v => onChange('data.profile.phone', v)}
       />
@@ -81,7 +81,7 @@ const ProfileTab = ({ data, onChange }) => {
       <TextField
         className="mb-6"
         label={t('profile.website.label')}
-        placeholder={t('profile.website.placeholder')}
+        placeholder="google.com"
         value={data.profile.website}
         onChange={v => onChange('data.profile.website', v)}
       />
@@ -89,7 +89,7 @@ const ProfileTab = ({ data, onChange }) => {
       <TextField
         className="mb-6"
         label={t('profile.email.label')}
-        placeholder={t('profile.email.placeholder')}
+        placeholder="john.doe@example.com"
         value={data.profile.email}
         onChange={v => onChange('data.profile.email', v)}
       />
diff --git a/src/components/LeftSidebar/tabs/References.js b/src/components/LeftSidebar/tabs/References.js
index 2a4c3db8..80e09c33 100644
--- a/src/components/LeftSidebar/tabs/References.js
+++ b/src/components/LeftSidebar/tabs/References.js
@@ -98,7 +98,7 @@ const Form = ({ item, onChange, identifier = '' }) => {
       <TextField
         className="mb-6"
         label={t('references.phone.label')}
-        placeholder={t('references.phone.placeholder')}
+        placeholder="+1 541 754 3010"
         value={item.phone}
         onChange={v => onChange(`${identifier}phone`, v)}
       />
@@ -106,7 +106,7 @@ const Form = ({ item, onChange, identifier = '' }) => {
       <TextField
         className="mb-6"
         label={t('references.email.label')}
-        placeholder={t('references.email.placeholder')}
+        placeholder="richard@piedpiper.com"
         value={item.email}
         onChange={v => onChange(`${identifier}email`, v)}
       />
diff --git a/src/components/RightSidebar/tabs/Templates.js b/src/components/RightSidebar/tabs/Templates.js
index 747b3a87..22106c75 100644
--- a/src/components/RightSidebar/tabs/Templates.js
+++ b/src/components/RightSidebar/tabs/Templates.js
@@ -1,11 +1,8 @@
 import React from 'react';
-import { useTranslation } from 'react-i18next';
 
 import templates from '../../../templates';
 
 const TemplatesTab = ({ theme, onChange }) => {
-  const { t } = useTranslation('rightSidebar');
-
   return (
     <div className="grid grid-cols-2 gap-6">
       {templates.map(x => (
@@ -17,9 +14,9 @@ const TemplatesTab = ({ theme, onChange }) => {
                 : 'border-transparent '
             } hover:border-gray-500 cursor-pointer`}
             src={x.preview}
-            alt={t(`templates.templates.${x.key}`)}
+            alt={x.name}
           />
-          <p className="mt-1 text-sm font-medium">{t(`templates.templates.${x.key}`)}</p>
+          <p className="mt-1 text-sm font-medium">{x.name}</p>
         </div>
       ))}
     </div>
diff --git a/src/i18n/resources/en/app/app.json b/src/i18n/resources/en/app/app.json
index 9d6d8981..60cace76 100644
--- a/src/i18n/resources/en/app/app.json
+++ b/src/i18n/resources/en/app/app.json
@@ -10,7 +10,7 @@
     },
     "endDate": {
       "label": "End Date",
-      "placeholder": "current"
+      "placeholder": "March 2020"
     },
     "description": {
       "label": "Description"
@@ -21,5 +21,5 @@
       "label": "Add"
     }
   },
-  "markdownHelpText": "You can use <1>GitHub Flavored Markdown</1> to style this section of text."
+  "markdownHelpText": "You can use <1>GitHub Flavored Markdown</1> to style this section of the text."
 }
diff --git a/src/i18n/resources/en/leftSidebar/awards.json b/src/i18n/resources/en/leftSidebar/awards.json
index 0b9b3820..4222ec12 100644
--- a/src/i18n/resources/en/leftSidebar/awards.json
+++ b/src/i18n/resources/en/leftSidebar/awards.json
@@ -8,6 +8,6 @@
     "placeholder": "First Place, International Level"
   },
   "description": {
-    "placeholder": ""
+    "placeholder": "You can write about what qualities made you succeed in getting this award."
   }
 }
diff --git a/src/i18n/resources/en/leftSidebar/certifications.json b/src/i18n/resources/en/leftSidebar/certifications.json
index 8d8fc36d..2763082a 100644
--- a/src/i18n/resources/en/leftSidebar/certifications.json
+++ b/src/i18n/resources/en/leftSidebar/certifications.json
@@ -8,6 +8,6 @@
     "placeholder": "Udacity"
   },
   "description": {
-    "placeholder": ""
+    "placeholder": "You can write about what you learnt from your certification program."
   }
 }
diff --git a/src/i18n/resources/en/leftSidebar/education.json b/src/i18n/resources/en/leftSidebar/education.json
index 39284881..231004b2 100644
--- a/src/i18n/resources/en/leftSidebar/education.json
+++ b/src/i18n/resources/en/leftSidebar/education.json
@@ -8,8 +8,7 @@
     "placeholder": "Masters in Computer Science"
   },
   "grade": {
-    "label": "Grade",
-    "placeholder": "7.2 CGPA"
+    "label": "Grade"
   },
   "description": {
     "placeholder": "You can write about projects or special credit classes that you took while studying at this school."
diff --git a/src/i18n/resources/en/leftSidebar/profile.json b/src/i18n/resources/en/leftSidebar/profile.json
index 07e84ab0..b7f889c2 100644
--- a/src/i18n/resources/en/leftSidebar/profile.json
+++ b/src/i18n/resources/en/leftSidebar/profile.json
@@ -1,7 +1,6 @@
 {
   "photoUrl": {
-    "label": "Photo URL",
-    "placeholder": "https://i.imgur.com/..."
+    "label": "Photo URL"
   },
   "firstName": {
     "label": "First Name",
@@ -30,15 +29,12 @@
     }
   },
   "phone": {
-    "label": "Phone Number",
-    "placeholder": "+1 541 754 3010"
+    "label": "Phone Number"
   },
   "website": {
-    "label": "Website",
-    "placeholder": "google.com"
+    "label": "Website"
   },
   "email": {
-    "label": "Email Address",
-    "placeholder": "john.doe@example.com"
+    "label": "Email Address"
   }
 }
diff --git a/src/i18n/resources/en/leftSidebar/references.json b/src/i18n/resources/en/leftSidebar/references.json
index 1cb5db52..88241575 100644
--- a/src/i18n/resources/en/leftSidebar/references.json
+++ b/src/i18n/resources/en/leftSidebar/references.json
@@ -8,12 +8,10 @@
     "placeholder": "CEO, Pied Piper"
   },
   "phone": {
-    "label": "Phone Number",
-    "placeholder": "+1 123 456 7890"
+    "label": "Phone Number"
   },
   "email": {
-    "label": "Email Address",
-    "placeholder": "richard@piedpiper.com"
+    "label": "Email Address"
   },
   "description": {
     "placeholder": "You can write about how you and the reference contact worked together and which projects you were a part of."
diff --git a/src/i18n/resources/en/rightSidebar/templates.json b/src/i18n/resources/en/rightSidebar/templates.json
index f2501798..89fd528d 100644
--- a/src/i18n/resources/en/rightSidebar/templates.json
+++ b/src/i18n/resources/en/rightSidebar/templates.json
@@ -1,9 +1,3 @@
 {
-  "title": "Templates",
-  "templates": {
-    "onyx": "Onyx",
-    "pikachu": "Pikaaachu",
-    "gengar": "Gengar",
-    "castform": "Castform"
-  }
+  "title": "Templates"
 }
diff --git a/src/templates/index.js b/src/templates/index.js
index 261fe54d..5b42cad5 100644
--- a/src/templates/index.js
+++ b/src/templates/index.js
@@ -6,21 +6,25 @@ import Castform, { Image as CastformPreview } from './castform';
 export default [
   {
     key: 'onyx',
+    name: 'Onyx',
     component: Onyx,
     preview: OnyxPreview,
   },
   {
     key: 'pikachu',
+    name: 'Pikachu',
     component: Pikachu,
     preview: PikachuPreview,
   },
   {
     key: 'gengar',
+    name: 'Gengar',
     component: Gengar,
     preview: GengarPreview,
   },
   {
     key: 'castform',
+    name: 'Castform',
     component: Castform,
     preview: CastformPreview,
   },