mirror of
https://github.com/AmruthPillai/Reactive-Resume.git
synced 2026-08-24 15:22:20 +10:00
chore: integrate improve-integration
This commit is contained in:
@@ -26,6 +26,13 @@ describe("shouldShowResumeHeader", () => {
|
||||
expect(shouldShowResumeHeader(createCoverLetterOnlyData(), 0)).toBe(false);
|
||||
});
|
||||
|
||||
it("can keep the first-page header for cover letter documents", () => {
|
||||
const data = { ...createCoverLetterOnlyData(), renderOptions: { includeCoverLetterHeader: true } };
|
||||
|
||||
expect(shouldShowResumeHeader(data, 0)).toBe(true);
|
||||
expect(shouldShowResumeHeader(data, 1)).toBe(false);
|
||||
});
|
||||
|
||||
it("keeps the first-page header for normal resume documents", () => {
|
||||
expect(shouldShowResumeHeader(sampleResumeData, 0)).toBe(true);
|
||||
expect(shouldShowResumeHeader(sampleResumeData, 1)).toBe(false);
|
||||
|
||||
@@ -1,6 +1,11 @@
|
||||
import type { ResumeData } from "@reactive-resume/schema/resume/data";
|
||||
import type { ResumeRenderOptions } from "../../context";
|
||||
import { filterSections } from "./filtering";
|
||||
|
||||
type HeaderResumeData = ResumeData & {
|
||||
renderOptions?: ResumeRenderOptions;
|
||||
};
|
||||
|
||||
const isCoverLetterSection = (data: ResumeData, sectionId: string) =>
|
||||
data.customSections.some((section) => section.id === sectionId && section.type === "cover-letter");
|
||||
|
||||
@@ -12,5 +17,5 @@ const isCoverLetterOnlyDocument = (data: ResumeData) => {
|
||||
return visibleSections.length > 0 && visibleSections.every((sectionId) => isCoverLetterSection(data, sectionId));
|
||||
};
|
||||
|
||||
export const shouldShowResumeHeader = (data: ResumeData, pageIndex: number) =>
|
||||
pageIndex === 0 && !isCoverLetterOnlyDocument(data);
|
||||
export const shouldShowResumeHeader = (data: HeaderResumeData, pageIndex: number) =>
|
||||
pageIndex === 0 && (data.renderOptions?.includeCoverLetterHeader || !isCoverLetterOnlyDocument(data));
|
||||
|
||||
Reference in New Issue
Block a user