Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2026-08-24 23:32:19 +10:00
Code Issues Packages Projects Releases Wiki Activity

refactor(stylesheet): move Semantic CSS to the browser (#3329)

Browse Source
This commit is contained in:
Amruth Pillai
2026-08-16 16:50:27 +02:00
committed by GitHub
parent f848e57436
commit 9509b5bc2e
203 changed files with 11838 additions and 14842 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/pdf/src/server.test.tsx
+7 -22
View File
@@ -108,31 +108,16 @@ describe("createResumePdfFile", () => {
);
});
it("returns semantic diagnostics without rendering an invalid applied source", async () => {
it("renders with base styles when the source is fatal", async () => {
const data = structuredClone(sampleResumeData);
const invalid = { languageVersion: 1, text: "@version 1; section { color: ; }" };
data.metadata.stylesheet = { mode: "semantic", source: invalid, applied: invalid };
const { createResumePdfFileResult } = await import("./server");
const result = await createResumePdfFileResult({ data, filename: "resume.pdf" });
expect(result).toMatchObject({
ok: false,
diagnostics: [expect.objectContaining({ severity: "error" })],
});
expect(rendererMock.renderToBuffer).not.toHaveBeenCalled();
});
it("rejects unchecked rendering instead of producing an unstyled PDF for semantic errors", async () => {
const data = structuredClone(sampleResumeData);
const invalid = { languageVersion: 1, text: "@version 1; section { color: ; }" };
data.metadata.stylesheet = { mode: "semantic", source: invalid, applied: invalid };
data.metadata.stylesheet = { mode: "semantic", source: { languageVersion: 2, text: "@version 2;" } };
const { createResumePdfFile } = await import("./server");
await expect(createResumePdfFile({ data, filename: "resume.pdf" })).rejects.toMatchObject({
cause: [expect.objectContaining({ severity: "error" })],
});
expect(rendererMock.renderToBuffer).not.toHaveBeenCalled();
await expect(createResumePdfFile({ data, filename: "resume.pdf" })).resolves.toHaveProperty(
"type",
"application/pdf",
);
expect(rendererMock.renderToBuffer).toHaveBeenCalledTimes(1);
});
it("rejects renderer-unsafe data at the server boundary before React PDF dispatch", async () => {