Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2026-08-24 23:32:19 +10:00
Code Issues Packages Projects Releases Wiki Activity

Show experience position with role progression (#3116)

Browse Source
This commit is contained in:
Amruth Pillai
2026-05-28 13:51:02 +02:00
committed by GitHub
parent 1d761be05b
commit 9ce5bacd22
2 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/pdf/src/templates/shared/sections.test.ts
+15
View File
@@ -0,0 +1,15 @@
import { readFileSync } from "node:fs";
import { fileURLToPath } from "node:url";
import { describe, expect, it } from "vitest";
const source = readFileSync(fileURLToPath(new URL("./sections.tsx", import.meta.url)), "utf8");
describe("ExperienceSection", () => {
it("does not hide the item position header when role progression is present", () => {
expect(source).not.toContain("item.roles.length === 0 && (hasPosition || hasSplitRowText(headerPeriod))");
});
it("does not repeat the summary period after rendering it in a role-progression header", () => {
expect(source).not.toContain("item.roles.length > 0 && <Text>{item.period}</Text>");
});
});
packages/pdf/src/templates/shared/sections.tsx
+1 -3
View File
@@ -415,7 +415,7 @@ const ExperienceSection = ({ sectionId = "experience", sectionData }: ItemSectio
{hasSplitRowText(headerLocation) && <Text style={composeStyles(alignEndStyle)}>{headerLocation}</Text>}
</View>
{item.roles.length === 0 && (hasPosition || hasSplitRowText(headerPeriod)) && (
{(hasPosition || hasSplitRowText(headerPeriod)) && (
<View style={composeStyles(splitRowStyle)}>
{hasPosition && <Text>{item.position}</Text>}
{hasSplitRowText(headerPeriod) && <Text style={composeStyles(alignEndStyle)}>{headerPeriod}</Text>}
@@ -428,8 +428,6 @@ const ExperienceSection = ({ sectionId = "experience", sectionData }: ItemSectio
<SectionItem key={item.id}>
<SectionItemHeader>{inlineItemHeader ? renderInlineHeader() : renderSplitHeader()}</SectionItemHeader>
{item.roles.length > 0 && <Text>{item.period}</Text>}
{item.roles.map((role) => (
<View key={role.id}>
<View style={composeStyles(splitRowStyle)}>