From ad97b8a88c7a8cab17eafa003b2cab10bfe5d39e Mon Sep 17 00:00:00 2001 From: Amruth Pillai Date: Sun, 6 Sep 2026 00:14:02 +0200 Subject: [PATCH] docs: record second published unit and review fixes --- docs/execution/approved-issue-plans-ledger.md | 20 +++++++++++------- .../briefs/fix-review-plan-02-round2.md | 21 +++++++++++++++++++ docs/execution/briefs/fix-review-plan-11.md | 18 ++++++++++++++++ 3 files changed, 52 insertions(+), 7 deletions(-) create mode 100644 docs/execution/briefs/fix-review-plan-02-round2.md create mode 100644 docs/execution/briefs/fix-review-plan-11.md diff --git a/docs/execution/approved-issue-plans-ledger.md b/docs/execution/approved-issue-plans-ledger.md index c5799afeb..26b4e91fa 100644 --- a/docs/execution/approved-issue-plans-ledger.md +++ b/docs/execution/approved-issue-plans-ledger.md @@ -34,20 +34,20 @@ state changes are outside scope. | Unit | Issues | Status / current validity | Owner | Worktree / branch | Base → head | Dependencies | Evidence | Tests | PR | Next action | Blockers | | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- | | 01 account login/recovery | #3166, #3164, #3078, #3046, #2897, #2837 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | none | zero drift; live issues remain split; #3046/#3078 have merged #3095 candidate only | auth 42, email 6, focused/full API/server suites and affected typechecks/boundaries passed in audit | — | select exact auth/mail/API boundary only after current sanitized trace | current cloud digest, provider/account method, request/status trace, controlled mailbox | -| 02 hosted v4 recovery | #3181, #2760 | reviewing | re-review `task_5bffa8e386f2` / `ctx_57fe2ac671f8` | `codex/issue-3181-recovery-procedure` | `7a98f6662` → `6af21121b` | #2760 identity branch depends on 01 evidence | strict validation, target-state invariant, v5-only wording, and hash-limit corrections committed with new regressions | focused tooling/API/auth/typechecks/boundaries/Biome/Markdown/diff green; independent re-review active | — | publish after clean re-review and fresh verification | real recovery still needs verified owner, snapshot, mapping, private delivery | +| 02 hosted v4 recovery | #3181, #2760 | implementing review correction | fix `task_eb3b8c09aef2` / `ctx_3d3e5f7d2496` | `codex/issue-3181-recovery-procedure` | `7a98f6662` → `6af21121b` | #2760 identity branch depends on 01 evidence | first fixes closed four findings; re-review proved boxed/custom-serialized object input can still normalize before validation | prior focused gates green; second strict-TDD correction active | — | validate original object before serialization, then clean independent re-review | real recovery still needs verified owner, snapshot, mapping, private delivery | | 03 MCP registration | #3398, #3153 | no-change | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | coordinate DB/startup with 05 | merged #3421 (`fe9b59e`) present on main; current schema/startup/auth contracts match plan | #3421 hosted checks successful; audit auth/server/API/DB tests, typechecks, boundaries passed | #3421 merged before run | deployment verification only | deployed digest/log correlation and exact Codex/Claude DCR/consent/PKCE/MCP retest unavailable | | 04 AI provider compatibility | #2732, #2766, #2723, #2708 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | serialize edits to AI service | zero drift; historical #2708 Responses path and #2766 structured Test path absent; remaining tuples differ | focused API 96 and full API suites/typecheck/boundaries passed in audit | — | select wire/state/import/base-path unit only after exact current tuple fails | provider/model/base URL/path/version/action/error tuple and allowed endpoint unavailable | | 05 AI provider migrations | #3152 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | coordinate DB/startup with 03 | zero drift; table schema, migration, startup ordering, Docker copy path coherent; `42P01` historical cause unresolved | audit API/server/DB tests, typechecks, boundaries passed; no real PostgreSQL migration fixture | — | choose config/packaging/startup/migration repair only after disposable reproduction | affected image layout/digest, working directory, DB schema/search path/journal, fresh+upgrade DB fixture | | 06 image storage delivery | #2684, #2778 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | coordinate 12/15/25 renderer/image fixtures | #2684 ACL cause fixed by merged #3432 (`35cecf9`); #2778 Browserless path obsolete; current topology unproved | #3432 hosted checks successful; audit storage/upload/PDF tests, typechecks, boundaries passed | #3432 merged before run | deployment retest plus shared real-encoding/backend/render fixture before repair | deployed digest; disposable S3/Garage/SeaweedFS/MinIO/proxy and browser/server raster matrix unavailable | | 07 AIO deployment | #2722 | published | implementation/review chain complete | `codex/issue-2722-postgres-docs` | `7a98f6662` → `b61ca1609` | none | two-doc supported-topology guidance; review-found PostgreSQL update hazard fixed; clean independent re-review | fresh Compose config, Markdown lint, runtime claims, links, diff/scope passed at published head | [#3457](https://github.com/amruthpillai/reactive-resume/pull/3457) | monitor hosted checks/review; keep unmerged | no AIO implementation; optional Unraid host smoke unavailable | | 08 root public resume | #2669 | plan amendment required before implementation | audit `task_9f27829ca50f` | planned `codex/issue-2669-root-resume` | `7a98f6662` → — | none | current password redirect rejects `/`; public view is slug-hook-bound; SSR canonical cannot import server env; expanded auth/canonical contract identified | audit focused API/web suites, typechecks, boundaries passed | — | amend ownership for identity-vs-return auth flow and server-derived canonical root, then dispatch coherent feature | engineering scope correction; feature remains narrower than arbitrary domain/TLS registry | -| 09 external version backup | #2705 | reviewing | re-review `task_1bd82b008a77` / `ctx_ca2a0176b52f` | `codex/issue-2705-git-backup-docs` | `7a98f6662` → `6931d2cc4` | none | JSON cover-letter scope and throttled template snapshot wording corrected | 152 focused tests, Markdown/diff/scope green; independent re-review active | — | publish after clean re-review and fresh verification | DB integration/E2E unavailable; no sync/remote/whole-account restore | +| 09 external version backup | #2705 | published | implementation/review chain complete | `codex/issue-2705-git-backup-docs` | `7a98f6662` → `6931d2cc4` | none | JSON cover-letter scope and throttled template snapshot wording corrected; clean independent re-review | fresh 152 focused tests, Markdown/diff/exact-base/scope green | [#3458](https://github.com/amruthpillai/reactive-resume/pull/3458) | monitor hosted checks/review; keep unmerged | DB integration/E2E unavailable; no sync/remote/whole-account restore | | 10 legacy link routing | #2836 | pending implementation after brief correction | audit `task_9f27829ca50f` | planned `codex/issue-2836-retired-slug-notices` | `7a98f6662` → — | none | prospective same-username slug-attempt notice remains coherent; exact DB/API/UI/E2E owner set verified | audit focused API/web suites, DB/API/web typechecks, boundaries passed | — | correct final E2E target to `public-sharing.spec.ts`, then implement migration/API/owner UI atomically | historical cause absent; no redirects/emails/recovery; prospective partial coverage only | -| 11 job search policy | #3010 | reviewing | implementation `task_58d76423d364`; review `task_7d5d4c1417a9` / `ctx_17ee05faf9e7` | `codex/issue-3010-jsearch-docs` | `7a98f6662` → `cb011841c` | none | three docs committed with v5.1.0 history, supplied-description workflow, and provider-native capability boundary | implementer reports 16 focused tests, Markdown/diff/scope green; independent review active | — | resolve findings, fresh verify, publish unmerged PR | real provider/browser optional gate unavailable; removal motive unknown | +| 11 job search policy | #3010 | implementing review correction | fix `task_351a96e90b69` / `ctx_e398c9128731` | `codex/issue-3010-jsearch-docs` | `7a98f6662` → `cb011841c` | none | review found unqualified attachment promise and adjacent restore-guidance duplication; bounded docs fix active | implementation tests/Markdown/diff/scope green; rerun after fix | — | clean re-review, fresh verify, publish unmerged PR | real provider/browser optional gate unavailable; removal motive unknown | | 12 preview/export failures | #3323, #3290, #3033, #3007, #2609 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer ownership; share observation harness with 18 | zero drift; staged-preview/error-boundary baselines remain; reports cross persistence/font/PDF/viewer/deployment boundaries | audit focused web/PDF suites, affected typechecks, boundaries, build passed | — | isolate PT Sans, browser/config, and template-selection boundaries; no shared fix | exact JSON/output/browser/config/current reproduction missing | | 13 font/glyph/spacing | #3249, #3159, #3147, #3093, #3089, #2988 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize font sources with 14/27 | merged metrics/cache/Unicode fixes present and passing; residuals require per-font/per-symptom fixtures | audit focused PDF/font suites, affected typechecks, boundaries, build passed | — | retain regressions; create residual unit only from exact failing font fixture | missing Ropa Sans/source strings/font hashes/before-after artifacts | | 14 RTL export layout | #3275 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize renderer/fonts with 13/27 | merged canvas-direction fix remains; broader shaping/bidi cause unproved | audit RTL/preview suites, affected typechecks, boundaries, build passed | — | run controlled same-bytes export matrix against approved shaping oracle | exact JSON/font/version and known-good reference absent | -| 15 picture fitting/style | #3168, #3088, #2794, #2782 | pending implementation 15A; other causes blocked | unassigned | planned `codex/issue-2782-picture-fit` | `7a98f6662` → — | coordinate 06/25; schema/PDF owner exclusion | verified contract gap: no fit field; editor/web/PDF force cover; 15A cover/contain is ready | audit picture suites, schema/web/PDF typechecks, boundaries, build passed | — | implement explicit cover/contain with cover compatibility and cross-output geometry tests | delivery/centering issues still lack source revisions/assets/expected crop | +| 15 picture fitting/style | #3168, #3088, #2794, #2782 | implementing 15A; other causes blocked | `task_557902c8adef` / `ctx_db6fae1b75c4` | `codex/issue-2782-picture-fit` | `7a98f6662` → — | coordinate 06/25; schema/PDF owner exclusion | verified contract gap: no fit field; editor/web/PDF force cover; 15A cover/contain dispatched | audit picture suites, schema/web/PDF typechecks, boundaries, build passed | — | implement explicit cover/contain with cover compatibility and cross-output geometry tests | delivery/centering issues still lack source revisions/assets/expected crop | | 16 imported table borders | #3196 | pending implementation | unassigned | planned `codex/issue-3196-editable-tables` | `7a98f6662` → — | rich-text owner; must precede 19/31 | editor lacks table extensions; Q11 approves editable supported tables; atomic editor/HTML/PDF unit ready | audit current table/rich-input regressions, affected typechecks, boundaries, build passed | — | implement via TDD, including persistence, undo/redo, borders, and lossless unsupported fallback | historical visual equivalence lacks reporter HTML/JSON but feature contract is approved | | 17 list/skill pagination | #2751, #3040 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer owner shared with 13/14/18 | merged ordered-marker/wrap/level-gap fixes present; current residual not reproduced | audit focused PDF suites, typecheck, boundaries, build passed | — | retain controls; add fix only from exact failing list/skill fixture | #2751 source absent; #3040 current fixture no longer proves residual clipping | | 18 preview/export geometry | #2683 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | share output-boundary harness with 12; viewer owner exclusion | current viewport/page-size/margin baselines pass; video alone cannot locate cause | audit page/preview tests, affected typechecks, boundaries, build passed | — | compare identical preview/download bytes, MediaBoxes, ink bounds, viewport, DPR | exact JSON/PDF/browser/DPR/zoom/page settings absent | @@ -88,9 +88,13 @@ state changes are outside scope. | Plan 07 re-review | `task_90a9a6b63782` / `ctx_2f1def9119d6` | same Plan 07 worktree | complete; no findings | full-diff verification after update-safety fix | | Plan 09 independent review | `task_129b49e32bc7` / `ctx_68b13c76cc72` | same Plan 09 worktree | complete; changes required | embedded-letter JSON contradiction; template-checkpoint overclaim | | Plan 09 review fix | `task_8aa48854e7da` / `ctx_5aa2007ec136` | same Plan 09 worktree | complete | commit `6931d2cc4`; correct rendered-export scope and throttled template snapshot wording | -| Plan 02 re-review | `task_5bffa8e386f2` / `ctx_57fe2ac671f8` | same Plan 02 worktree | reviewing | reproduce prior findings and review full fixed diff | -| Plan 09 re-review | `task_1bd82b008a77` / `ctx_ca2a0176b52f` | same Plan 09 worktree | reviewing | verify both factual corrections and full diff | -| Plan 11 independent review | `task_7d5d4c1417a9` / `ctx_17ee05faf9e7` | same Plan 11 worktree | reviewing | history/runtime/workflow accuracy and independent validation | +| Plan 02 re-review | `task_5bffa8e386f2` / `ctx_57fe2ac671f8` | same Plan 02 worktree | complete; changes required | original object still serialized before validation; boxed string reproduced false no-op | +| Plan 02 second review fix | `task_eb3b8c09aef2` / `ctx_3d3e5f7d2496` | same Plan 02 worktree | implementing | original-form object validation plus boxed-string/custom-`toJSON` regressions | +| Plan 09 re-review | `task_1bd82b008a77` / `ctx_ca2a0176b52f` | same Plan 09 worktree | complete; no findings; worker released | full diff and both factual corrections verified before PR #3458 | +| Plan 11 independent review | `task_7d5d4c1417a9` / `ctx_17ee05faf9e7` | same Plan 11 worktree | complete; changes required | attachment-format overclaim and duplicated patch/restore guidance | +| Plan 11 review fix | `task_351a96e90b69` / `ctx_e398c9128731` | same Plan 11 worktree | implementing | qualify workflow and remove adjacent duplication | +| Plan 15A implementation | `task_557902c8adef` / `ctx_db6fae1b75c4` | `codex/issue-2782-picture-fit` | implementing | explicit cover/contain contract across schema/editor/preview/PDF | +| Plan 07 hosted review follow-up | coordinator | `codex/issue-2722-postgres-docs` | fix committed; re-review pending | commit `a7b8c4c`; quickstart major pin, exact image/build update paths, host-port warning, verified-TLS guidance | ## Existing PR and residual accounting @@ -109,3 +113,5 @@ state changes are outside scope. - Coordinator ledger: PR #3456 (`codex/issue-execution-ledger` → `main`), open and intentionally unmerged. - Plan 07: PR [#3457](https://github.com/amruthpillai/reactive-resume/pull/3457), open and intentionally unmerged; published head `b61ca16096a37ef3ba14f8a706cf1bbe34440e40` after clean re-review and fresh verification. +- Plan 09: PR [#3458](https://github.com/amruthpillai/reactive-resume/pull/3458), open and intentionally unmerged; + published head `6931d2cc4a512e53dfd51575ad729bb9f6da5249` after clean re-review and fresh 152-test verification. diff --git a/docs/execution/briefs/fix-review-plan-02-round2.md b/docs/execution/briefs/fix-review-plan-02-round2.md new file mode 100644 index 000000000..998976682 --- /dev/null +++ b/docs/execution/briefs/fix-review-plan-02-round2.md @@ -0,0 +1,21 @@ +# Address second independent review: plan 02 + +Read `.orchestration/plan-02-rereview.md`, pinned approved plan 02, current `AGENTS.md`, RTK, and applicable +receiving-code-review/TDD/documentation skills. Reproduce the remaining finding before editing. + +Use strict TDD. Add failing regressions first, then make the smallest conservative fix within the original four-file scope: + +- For non-string object input, validate the supplied object in its original form before any serialization. Schema-invalid + objects must return a deterministic blocked manifest and must never produce `no-op`. +- Cover at least a boxed string (`new String("")`) that serializes to a valid primitive and a schema-invalid object with a + custom `toJSON`. Assert the latter is not executed before validation when the input is invalid. +- Keep JSON-text behavior: parse text, validate the parsed value exactly, and retain raw-versus-parsed normalization checks. +- Preserve target presence invariants, strict source/target validation, deterministic hashes and reasons, pure/non-networked/ + non-writing behavior, and existing documentation claims. Change docs only if implementation makes a current sentence false. + +Do not access private data, add DB/filesystem writes, implement legacy conversion, widen scope, or rewrite prior reports. +Run focused RED/GREEN tests, tooling typecheck, relevant API/auth checks, boundaries, narrow Biome/Markdown when applicable, +diff and four-file scope gates. Add a normal follow-up commit. + +Write `.orchestration/plan-02-review-fix-round2.md` with reproduction, RED/GREEN, exact commit/files, commands/results, +skipped gates, and remaining risks. Do not push/open PR/merge/mutate issues/spawn subagents. Final response at most ten lines. diff --git a/docs/execution/briefs/fix-review-plan-11.md b/docs/execution/briefs/fix-review-plan-11.md new file mode 100644 index 000000000..5a08f976d --- /dev/null +++ b/docs/execution/briefs/fix-review-plan-11.md @@ -0,0 +1,18 @@ +# Address independent review: plan 11 + +Read `.orchestration/plan-11-review.md`, pinned approved plan 11, current `AGENTS.md`, RTK, and applicable +receiving-code-review/documentation skills. Verify both findings against current source before editing. + +Make smallest documentation-only corrections within existing three-file scope: + +- Remove unqualified attachment promise from changelog. Prefer saying users can paste a job description there; keep exact + supported attachment details in guide where current MIME/direct-file qualifications already exist. +- Remove adjacent duplication of review/restore/rollback guidance in `using-ai-agent.mdx`. Keep concise workflow step and + point to existing `Review patches` section, retaining full behavior explanation only once. + +Preserve verified history, current provider capability boundary, isolated AI Draft behavior, no invented removal motive, +and no promise of paid JSearch restoration. Run focused source probes, Markdown lint, relevant targeted tests if claims +changed, link/diff/three-file scope gates. Add normal follow-up commit. + +Write `.orchestration/plan-11-review-fix.md` with finding verification, exact commit/files, commands/results, skipped gates, +and remaining risks. Do not push/open PR/merge/mutate issues/spawn subagents. Final response at most ten lines.