diff --git a/docs/execution/approved-issue-plans-ledger.md b/docs/execution/approved-issue-plans-ledger.md index cef944a29..d75f26051 100644 --- a/docs/execution/approved-issue-plans-ledger.md +++ b/docs/execution/approved-issue-plans-ledger.md @@ -47,12 +47,12 @@ state changes are outside scope. | 12 preview/export failures | #3323, #3290, #3033, #3007, #2609 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer ownership; share observation harness with 18 | zero drift; staged-preview/error-boundary baselines remain; reports cross persistence/font/PDF/viewer/deployment boundaries | audit focused web/PDF suites, affected typechecks, boundaries, build passed | — | isolate PT Sans, browser/config, and template-selection boundaries; no shared fix | exact JSON/output/browser/config/current reproduction missing | | 13 font/glyph/spacing | #3249, #3159, #3147, #3093, #3089, #2988 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize font sources with 14/27 | merged metrics/cache/Unicode fixes present and passing; residuals require per-font/per-symptom fixtures | audit focused PDF/font suites, affected typechecks, boundaries, build passed | — | retain regressions; create residual unit only from exact failing font fixture | missing Ropa Sans/source strings/font hashes/before-after artifacts | | 14 RTL export layout | #3275 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize renderer/fonts with 13/27 | merged canvas-direction fix remains; broader shaping/bidi cause unproved | audit RTL/preview suites, affected typechecks, boundaries, build passed | — | run controlled same-bytes export matrix against approved shaping oracle | exact JSON/font/version and known-good reference absent | -| 15 picture fitting/style | #3168, #3088, #2794, #2782 | rereviewing 15A; other causes blocked | review `task_2b45ae3b4e98` / `ctx_695a139cd0b9` | `codex/issue-2782-picture-fit` | `7a98f6662` → `6145d5a59` | coordinate 06/25; schema/PDF owner exclusion | Cover/Contain geometry, computed CSS behavior, and shared props review findings fixed via mutation-tested TDD | full 19-task suite; affected typechecks/build/boundaries; docs/catalogs; 2 authenticated raster E2E green; rereview active | — | clean full-diff rereview, fresh coordinator verification, publish #2782-only PR | delivery/centering issues still lack source revisions/assets/expected crop | -| 16 imported table borders | #3196 | implementing | `task_f3d05a6ebb86` / `ctx_686ba93fc8af` | `codex/issue-3196-editable-tables` | `7a98f6662` → work active | rich-text owner; must precede 19/31 | editor lacks table extensions; Q11 approves editable supported tables; atomic editor/HTML/PDF unit dispatched in isolated worktree | audit baseline green; implementation TDD and E2E running | — | complete atomic editor/HTML/PDF implementation, verify, commit, independently review | historical visual equivalence lacks reporter HTML/JSON but feature contract is approved | +| 15 picture fitting/style | #3168, #3088, #2794, #2782 | 15A published; other causes blocked | coordinator after clean independent review | `codex/issue-2782-picture-fit` | `7a98f6662` → `6145d5a59` | coordinate 06/25; schema/PDF owner exclusion | Cover/Contain geometry, computed CSS behavior, and shared props review findings fixed via mutation-tested TDD; final rereview found no issues | fresh coordinator 130 focused tests, four affected typechecks, boundaries, and production build green; full suite and 2 authenticated raster E2E green in independent review | [#3461](https://github.com/amruthpillai/reactive-resume/pull/3461) | monitor exact-head hosted checks and review; keep unmerged | delivery/centering issues still lack source revisions/assets/expected crop | +| 16 imported table borders | #3196 | independently reviewing | review `task_e52d01cff964` / `ctx_63c00e7abb56` | `codex/issue-3196-editable-tables` | `7a98f6662` → `83aca184e` | rich-text owner; must precede 19/31 | supported tables are editable; unsupported table markup has lossless read-only fallback; explicit plain-text conversion and shared PDF border geometry included | implementation focused/full tests, typechecks, boundaries, build, and E2E green; independent review active | — | adjudicate independent findings, fix or publish exact reviewed head | historical visual equivalence lacks reporter HTML/JSON but feature contract is approved | | 17 list/skill pagination | #2751, #3040 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer owner shared with 13/14/18 | merged ordered-marker/wrap/level-gap fixes present; current residual not reproduced | audit focused PDF suites, typecheck, boundaries, build passed | — | retain controls; add fix only from exact failing list/skill fixture | #2751 source absent; #3040 current fixture no longer proves residual clipping | | 18 preview/export geometry | #2683 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | share output-boundary harness with 12; viewer owner exclusion | current viewport/page-size/margin baselines pass; video alone cannot locate cause | audit page/preview tests, affected typechecks, boundaries, build passed | — | compare identical preview/download bytes, MediaBoxes, ink bounds, viewport, DPR | exact JSON/PDF/browser/DPR/zoom/page settings absent | | 19 literal rich-text whitespace | #3397 | pending after 16 | unassigned | planned `codex/issue-3397-literal-whitespace` | `7a98f6662` → — | stack/rebase after 16; coordinate DOCX/PDF/editor with 31 | verified current marked-policy gap; approved marker contract and four-space tabs remain implementation-ready | audit whitespace/indentation suites, affected typechecks, boundaries, build passed | — | implement web/PDF/DOCX atomically after table seam stabilizes | no product blocker; serialized file ownership only | -| 20 section restoration | #3378, #3265, #2921 | pending split implementation | audit `task_47ed7eb02d48` | `codex-audit-builder-20-34` | `7a98f6662` → no source change | 20A before 21/31; placement semantics before 29 | 20A hidden recovery ready; 20B defensive unplaced recovery ready after helper contract; reporter causes remain unproved | audit focused web/resume tests, affected typechecks, boundaries passed | — | implement 20A first, then separately assess 20B | #3378/#3265 need version/action/sanitized JSON; defensive fix cannot close them | +| 20 section restoration | #3378, #3265, #2921 | 20A implementing; residuals split | `task_4237c974827a` / `ctx_00770ded7b0d` | `codex/issue-3378-hidden-section-recovery` | `7a98f6662` → work active | 20A before 21/31; placement semantics before 29 | 20A hidden recovery ready and executing; 20B defensive unplaced recovery waits for helper contract; reporter causes remain unproved | audit focused web/resume tests, affected typechecks, boundaries passed; implementation tests running | — | complete and independently review 20A; then separately assess 20B | #3378/#3265 need version/action/sanitized JSON; defensive fix cannot close them | | 21 section heading visibility | #3060 | pending after 20A | audit `task_47ed7eb02d48` | `codex-audit-builder-20-34` | `7a98f6662` → no source change | 20A → 21 → 31 | runtime PDF seam exists; persisted schema/menu/DOCX/accessibility contract absent; Q1–Q3 make unit ready | audit schema/web/PDF/DOCX/resume suites and typechecks/boundaries passed | — | add migration-safe flag, menu, PDF/DOCX visual behavior, retained semantic label | serialize shared section/schema files | | 22 skill keyword presentation | #2785 | pending implementation | audit `task_47ed7eb02d48` | `codex-audit-builder-20-34` | `7a98f6662` → no source change | must precede/serialize 34 | array currently comma-joined; inline/list contract ready for built-in and custom Skills | audit schema/web/PDF/DOCX suites and typechecks/boundaries passed | — | select explicit Skills-specific schema trait; implement inline compatibility and semantic list mode | exact schema owner chosen during implementation; no product gate | | 23 pagination controls | #3350, #3090 | pending 23A/23B; 23C blocked | audit `task_47ed7eb02d48` | `codex-audit-builder-20-34` | `7a98f6662` → no source change | 23B → possible 23C | 23A authored-vs-physical page guidance ready; renderer clips oversized `wrap=false` section; item policy unproved | audit focused PDF/web suites and typechecks/boundaries passed | — | publish 23A; build short/boundary/oversized matrix in 23B before item control | safe oversized-item fallback and widow/orphan UI remain unresolved | @@ -110,11 +110,13 @@ state changes are outside scope. | Plan 15A implementation | `task_557902c8adef` / `ctx_db6fae1b75c4` | `codex/issue-2782-picture-fit` | complete; worker released | commit `d891afd66`; explicit cover/contain contract across schema/editor/preview/PDF | | Plan 15A independent review | `task_d4f4841355e2` / `ctx_467f293cf443` | same Plan 15A worktree | complete; changes required; worker released | medium: raster checks did not pin fit geometry; low: class coupling and duplicate props type | | Plan 15A review fix | `task_5a4afecb7d0d` / `ctx_43faac4f25eb` | same Plan 15A worktree | complete; worker released | commit `6145d5a59`; all three findings fixed; full tests/build and authenticated raster E2E green | -| Plan 15A final rereview | `task_2b45ae3b4e98` / `ctx_695a139cd0b9` | same Plan 15A worktree | reviewing | full 70-file behavior, mutation-sensitive geometry, computed CSS, compatibility and issue scope | +| Plan 15A final rereview | `task_2b45ae3b4e98` / `ctx_695a139cd0b9` | same Plan 15A worktree | complete; no findings; worker released | exact head `6145d5a59`; full 70-file behavior, mutation-sensitive geometry, computed CSS, compatibility, scope, full suites, build, and E2E approved before PR #3461 | | Plan 07 hosted review follow-up | `task_6e9bc84ca2d4` / `ctx_e31d0e345240` | `codex/issue-2722-postgres-docs` | no findings; pushed; worker released | commit `a7b8c4c`; five valid comments fixed, `--no-deps` removal rejected; six replies and zero unresolved threads | | Plan 07 late hosted fix | `task_6d0545ee43b1` / `ctx_1d6a1e36def3` | same Plan 07 worktree | complete; worker released | commit `171637526`; separate image/repository build and log paths; Compose/docs gates green | | Plan 07 late fix rereview | `task_8ff818f3e95a` / `ctx_b73be2273e01` | same Plan 07 worktree | complete; no findings; pushed; worker released | exact head `171637526`; full-diff/Compose review and fresh coordinator gates green; hosted checks rerunning | -| Plan 16 implementation | `task_f3d05a6ebb86` / `ctx_686ba93fc8af` | `codex/issue-3196-editable-tables` | implementing | atomic editable supported tables, lossless unsupported fallback, PDF border geometry, persistence/E2E | +| Plan 16 implementation | `task_f3d05a6ebb86` / `ctx_686ba93fc8af` | `codex/issue-3196-editable-tables` | complete; worker released | commit `83aca184e`; atomic editable supported tables, lossless unsupported fallback, PDF border geometry, persistence/E2E | +| Plan 16 independent review | `task_e52d01cff964` / `ctx_63c00e7abb56` | same Plan 16 worktree | reviewing | full implementation/spec/standards review; explicitly inspect committed orchestration-report scope hygiene | +| Plan 20A implementation | `task_4237c974827a` / `ctx_00770ded7b0d` | `codex/issue-3378-hidden-section-recovery` | implementing | hidden-section recovery unit from current `origin/main`; test, commit, and report without publication | ## Existing PR and residual accounting @@ -122,6 +124,7 @@ state changes are outside scope. | --- | --- | --- | --- | --- | | PR #3453 | open, non-draft, mergeable, approved | `ccd111da894cf7d44cc3dee06c937f70d91fef24` | live 2026-09-05: E2E/autofix/Codacy/CodeRabbit/Greptile successful on exact head | monitor only; keep unmerged | | PR #3454 | open, non-draft, mergeable, approved | `80b0d3ab02cc4292f8a4514db8c2516adc1f9dc3` | live 2026-09-05: E2E/autofix/Codacy/CodeRabbit/Greptile successful on exact head | monitor only; keep unmerged | +| PR #3461 | open, non-draft; hosted checks running | `6145d5a5925373287b87dfaa30ab675ebc84e105` | clean independent rereview; fresh coordinator focused tests, affected typechecks, boundaries, and production build green | monitor exact-head hosted checks/review; keep unmerged | | Residual #2828 | pending product direction | — | stale whole-document concurrent-tab overwrite reproduced in Chromium/PostgreSQL; excluded from 63 | account for separately; do not implement conflict UI until product policy selected | ## Rulings and blockers log diff --git a/docs/execution/briefs/review-plan-16.md b/docs/execution/briefs/review-plan-16.md new file mode 100644 index 000000000..c914210ea --- /dev/null +++ b/docs/execution/briefs/review-plan-16.md @@ -0,0 +1,25 @@ +# Independent review: Plan 16 editable imported tables + +Review only in `/Users/amruth/orca/workspaces/reactive-resume/issue-3196-editable-tables`. +Exact target head: `83aca184e`. Do not edit tracked files, commit, push, publish, merge, or mutate issues. + +Read current instructions, pinned approved Plan 16, implementation report, full `origin/main...HEAD` diff, live issue +issue #3196, merged #3438, open PR overlap, and relevant editor/PDF/import domain docs. Refresh base and verify exact head. +Run root Intent inventory and load matching review skill if any; no subagents. + +Review Standards and Spec. Independently verify: + +- supported 2x3 tables parse as structured Tiptap nodes; mount and unrelated prop updates emit no destructive change; +- named-cell edit, paste, spans, multiple paragraphs, inline marks, undo/redo, save/reload, and HTML round-trip remain lossless; +- unsupported markup is detected before normalization, exact original HTML is preserved, accessible read-only notice works, + ordinary/locked/keyboard/reopen/cancel flows cannot overwrite it, and confirmed plain-text conversion is explicit; +- CSS declaration precedence, widths/spans/borders and borderless behavior hold without unsafe HTML widening; +- PDF tests prove six cell coordinates, exact border operators, and fixed-DPI pixels in legacy/semantic modes; +- synthetic import E2E covers editor persistence, unrelated edit, browser/server PDF and cleanup; +- Tiptap dependency/lockfile delta is minimal, compatible, licensed, and boundary-safe; +- no regression to #3438, non-table rich input, SSR, accessibility, or package ownership; +- `.orchestration/plan-16-implementation.md` presence in product commit is intentional or report as scope hygiene finding. + +Run RED-evidence sanity review; focused table/indent/PDF suites plus broader affected web/PDF tests, typechecks, boundaries, +frozen install, build, narrow non-writing Biome, diff/scope gates, and dedicated DB/local-storage E2E. Report findings first +with severity/anchors and publication verdict in `.orchestration/plan-16-review.md`; send worker_done.