diff --git a/docs/execution/approved-issue-plans-ledger.md b/docs/execution/approved-issue-plans-ledger.md index d7e754afe..b4ba4623d 100644 --- a/docs/execution/approved-issue-plans-ledger.md +++ b/docs/execution/approved-issue-plans-ledger.md @@ -73,8 +73,8 @@ state changes are outside scope. | Plans 07–11, 35 | `task_9f27829ca50f` / `ctx_11f7d7cf6d17` | `codex-audit-backend-07-11-35` | complete; worker release pending | 07/09/10/11 ready after named brief corrections; 08 needs engineering scope amendment; 35 diagnostic-only | | Plans 12–19 | `task_1c6582ccdeae` / `ctx_795fced595ef` | `codex-audit-rendering-12-19` | complete; worker release pending | 15A/16/19 implementation-ready; remaining causes split into diagnostics with named evidence gates | | Plans 20–34 | `task_47ed7eb02d48` / `ctx_50d8257459ab` | `codex-audit-builder-20-34` | complete; worker release pending | ready: 20A, 21, 22, 23A, 28 diagnostics, 32, 34; remaining plans split at evidence/design gates | -| Plan 07 implementation | `task_aee702e37eae` / not dispatched | planned `codex/issue-2722-postgres-docs` | waits on plans 07–11 audit | two-file docs change, verification, commit, independent review | -| Plan 09 implementation | `task_e450ea143bfa` / not dispatched | planned `codex/issue-2705-git-backup-docs` | waits on plans 07–11 audit | two-file docs change, synthetic local-Git validation, commit, independent review | +| Plan 07 implementation | `task_aee702e37eae` / `ctx_ed134b1d79ce` | `issue-2722-postgres-docs`; target `codex/issue-2722-postgres-docs` | starting | two-file docs change, verification, commit, independent review | +| Plan 09 implementation | `task_e450ea143bfa` / `ctx_3b575cf1d5c7` | `issue-2705-git-backup-docs`; target `codex/issue-2705-git-backup-docs` | starting | two-file docs change, synthetic local-Git validation, commit, independent review | | Plan 11 implementation | `task_58d76423d364` / not dispatched | planned `codex/issue-3010-jsearch-docs` | waits on plans 07–11 audit | three-file docs change, source/test validation, commit, independent review | | Plan 02 synthetic recovery | `task_bae016c4d1f2` / `ctx_303f5d1f1031` | `issue-3181-recovery-procedure`; target `codex/issue-3181-recovery-procedure` | implementing | pure deterministic compare tool, safeguards docs, TDD evidence, commit, independent review | diff --git a/docs/execution/briefs/implement-plan-15a.md b/docs/execution/briefs/implement-plan-15a.md new file mode 100644 index 000000000..0e4de45d5 --- /dev/null +++ b/docs/execution/briefs/implement-plan-15a.md @@ -0,0 +1,34 @@ +# Implement plan 15A: opt-in picture cover/contain + +Read entire approved plan first from +`/Users/amruth/orca/workspaces/reactive-resume/planning-pr-3455/plans/15-picture-fitting-and-style.md`; portable fallback: +`git show a2557b2ad40e06e1e63eb655f286e6a78fe6bf0d:plans/15-picture-fitting-and-style.md`. Read current `AGENTS.md`, +RTK, issue/domain instructions, ADRs, and applicable skills. Run root Intent inventory and load matching local skill before +source edits. Do not spawn subagents. Do not touch ledger, mutate issues, merge, push, or create PR. + +Start from refreshed `origin/main`, require clean worktree, rename branch `codex/issue-2782-picture-fit`, revalidate live +#2782 and all open implementation PRs, and run plan drift check. Stop on overlapping implementation or contradicted picture +contract. Historical #3168/#3088/#2794 causes remain outside this implementation and must not be claimed fixed. + +Strict TDD and bounded scope: + +- First add failing schema compatibility and picture-fit geometry/UI tests. Record exact RED output before implementation. +- Add `fit: z.enum(["cover", "contain"]).catch("cover")` to picture schema and `fit: "cover"` to defaults/required + fixtures. Old and invalid JSON parse as cover; contain round-trips. No DB migration. +- Add named Cover/Contain control through existing form/draft path. Cover retains crop flow. Contain uploads selected full file + via existing endpoint without cropped-canvas construction. Preserve validation, cancel/error/locked behavior, save/reload, + and undo. Explain that switching cannot restore pixels already cropped; no asset history or new endpoint. +- Make sidebar preview and shared PDF renderer consume selected fit. Preserve frame/aspect/border/shadow/rotation and normal + Semantic CSS precedence. Inspect every template image consumer; change only paths that bypass shared fit. +- Use synthetic marked square/landscape/portrait images. Assert contain retains all edges and centers within one pixel; cover + preserves old crop geometry; test border/shadow branches and semantic `object-fit: cover` override. +- Add/extend authenticated synthetic E2E for full-image upload, persistence, JSON/browser/server PDF parity when environment + supports it. Never use reporter/private assets. + +Run focused schema/web/PDF tests, affected typechecks, boundaries, full build, and plan E2E against dedicated disposable DB. +Use narrow non-writing Biome inspection; if `pnpm check` runs, disclose it is write-capable and inspect diff. Run +`git diff --check` and scope/name-only checks. Commit locally with normal message; leave for independent review. + +Write `.orchestration/plan-15a-implementation.md`: verified facts vs uncertainty, live/drift state, RED/GREEN evidence, exact +commit/files, tests/results, skipped gates, visual/raster evidence, risks, issue coverage, PR `not created`. Final response at +most ten lines. diff --git a/docs/execution/briefs/implement-plan-16.md b/docs/execution/briefs/implement-plan-16.md new file mode 100644 index 000000000..913c3a41a --- /dev/null +++ b/docs/execution/briefs/implement-plan-16.md @@ -0,0 +1,36 @@ +# Implement plan 16: editable imported rich-text tables + +Read entire approved plan first from +`/Users/amruth/orca/workspaces/reactive-resume/planning-pr-3455/plans/16-imported-table-borders.md`; portable fallback: +`git show a2557b2ad40e06e1e63eb655f286e6a78fe6bf0d:plans/16-imported-table-borders.md`. Read current `AGENTS.md`, RTK, +issue/domain instructions, ADRs, and applicable skills, including test-driven-development. Run root Intent inventory and load +matching local skill before source edits. Do not spawn subagents. Do not touch ledger, mutate issues, merge, push, or open PR. + +Start from refreshed `origin/main`, require clean worktree, rename branch `codex/issue-3196-editable-tables`, revalidate live +#3196 and open PRs, and run exact drift check. Preserve merged #3438. Historical screenshot equivalence remains unverified +without source, but Q11 independently approves supported table editing. + +Implement one atomic TDD unit across editor/HTML/PDF: + +- Add failing `rich-input.table` tests first and record exact RED output: supported 2x3 table parses as structured Tiptap + JSON; mount emits no change; named-cell edit affects one cell; undo/redo and remount retain rows/cells/text; HTML reimports + equivalently. Include colspan/rowspan, multiple paragraphs, inline marks, paste, and unrelated prop updates. +- Register native Tiptap table/row/header/cell support with smallest required dependencies and frozen lockfile changes. + Preserve supported widths/spans/borders and existing `emitUpdate: false` behavior. +- Detect unsupported structured markup before destructive normalization. Retain exact original HTML, expose accessible read-only + notice, and prevent ordinary edits from overwriting it. Cover locked, keyboard, reopen, and cancellation behavior. Stop if + implementation needs broader HTML security policy or arbitrary editor extensions. +- Keep explicit CSS precedence and borderless tables borderless. Legacy HTML `border` mapping is outside initial scope unless + an exact fixture proves it is first failure; then stop and report fork rather than widening silently. +- Extend actual PDF integration: assert six cell coordinates plus exact horizontal/vertical border operators and fixed-DPI + pixels for supported CSS borders in legacy/semantic modes. Unsupported fallback must remain lossless. Text-only assertion + cannot pass. +- Add focused synthetic import E2E covering edit, undo/redo, save/reload, unrelated edit, browser/server PDF. No private data. + +Run initial RED, focused web/PDF GREEN suites including existing #3438 test, web/PDF typechecks, boundaries, full build, and +plan E2E against dedicated disposable DB. Use narrow non-writing Biome; disclose/inspect any write-capable `pnpm check`. +Run `git diff --check` and scope inspection. Commit locally with normal message; no push/PR before independent review. + +Write `.orchestration/plan-16-implementation.md`: verified facts vs uncertainty, live/drift state, exact RED/GREEN evidence, +dependency/lockfile changes, commit/files, commands/results, skipped gates, risks, historical issue limitation, PR `not +created`. Final response at most ten lines.