From d251d602fb55c8ba4e4a81bf838039a123dfba36 Mon Sep 17 00:00:00 2001
From: brone1323 <59184559+brone1323@users.noreply.github.com>
Date: Tue, 12 May 2026 17:02:16 -0600
Subject: [PATCH] fix(pdf): increase headerNameLineHeight to 1.3 to prevent
 descender clipping (#3050)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

All Heading elements apply overflow:hidden via safeTextStyle in primitives.tsx.
At 1.5× heading font size with lineHeight 1.2, the line box is too tight to
fully render descenders (g, p, y, etc.) in the resume header name field,
causing them to appear visually cut off.

Raising headerNameLineHeight from 1.2 to 1.3 adds enough vertical room for
descenders across all 13 templates that share this constant.

Fixes #3042
---
 packages/pdf/src/templates/shared/styles.ts | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/packages/pdf/src/templates/shared/styles.ts b/packages/pdf/src/templates/shared/styles.ts
index e69aad133..1e68b42ec 100644
--- a/packages/pdf/src/templates/shared/styles.ts
+++ b/packages/pdf/src/templates/shared/styles.ts
@@ -21,7 +21,11 @@ export const mergeStyles = (...styles: StyleInput[]): Style => Object.assign({},
 
 export const mergeLinkStyles = (...styles: StyleInput[]): Style => mergeStyles(...styles, linkUnderlineStyle);
 
-export const headerNameLineHeight = 1.2;
+// Increased from 1.2 to 1.3 to prevent descenders (g, p, y, etc.) from being
+// clipped by the overflow:hidden applied in safeTextStyle on all Heading elements.
+// At 1.5× heading font size, a lineHeight of 1.2 leaves insufficient room for
+// the descender depth of many fonts, causing letters to appear visually cut off.
+export const headerNameLineHeight = 1.3;
 
 export type ResolvePlacementColorOptions = {
 	placement: TemplatePlacement;