Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2026-08-23 23:02:17 +10:00
Code Issues Packages Projects Releases Wiki Activity

refactor(docx): getBaseRun helper, hoist mainConfig, derive sections, remove dead OL code

Browse Source 
- Add getBaseRun() next to getHtmlStyle() and replace 8 inline baseRun spreads (~27 lines).
- Hoist one mainConfig object in buildDocument; sidebar call spreads only the two
  differing color keys (~17 lines).
- Remove BUILT_IN_SECTIONS Set; derive membership via `sectionId in data.sections` (~14 lines).
- Delete unreachable ordered-list numbering machinery in html-to-docx.ts: numberingRef is
  always undefined through all call paths, so isOrdered && numberingRef is always false (~15 lines).

Claude-Session: https://claude.ai/code/session_012Bnvt1MghwHj4qQRxuQUGa
This commit is contained in:
Amruth Pillai
2026-07-04 19:27:01 +02:00
parent 439ae114f9
commit dfe75390cd
3 changed files with 39 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/docx/src/section-renderers.ts
+17 -41
View File
@@ -43,6 +43,15 @@ function getHtmlStyle(): HtmlStyleConfig {
};
}
/** Base TextRun properties (font, size, color) shared across all section renderers. */
function getBaseRun() {
return {
...(bodyFont ? { font: bodyFont } : {}),
...(bodySize ? { size: bodySize } : {}),
...(textColor ? { color: textColor } : {}),
};
}
/**
* Creates a section heading paragraph with primary color and bottom border.
* Uses the heading typography set via `setRenderConfig`.
@@ -70,11 +79,7 @@ function sectionHeading(title: string, colorHex: string): Paragraph {
}
function titleAndSubtitle(primary: string, secondary: string, rightText?: string): Paragraph {
const baseRun = {
...(bodyFont ? { font: bodyFont } : {}),
...(bodySize ? { size: bodySize } : {}),
...(textColor ? { color: textColor } : {}),
};
const baseRun = getBaseRun();
const children: (TextRun | ExternalHyperlink)[] = [new TextRun({ text: primary, bold: true, ...baseRun })];
if (secondary) {
@@ -151,12 +156,7 @@ function renderExperience(section: Sections["experience"], colorHex: string): Pa
if (section.hidden || items.length === 0) return [];
const paragraphs: Paragraph[] = [sectionHeading(section.title, colorHex)];
const baseRun = {
...(bodyFont ? { font: bodyFont } : {}),
...(bodySize ? { size: bodySize } : {}),
...(textColor ? { color: textColor } : {}),
};
const baseRun = getBaseRun();
for (const item of items) {
if (item.roles && item.roles.length > 0) {
@@ -202,11 +202,7 @@ function renderEducation(section: Sections["education"], colorHex: string): Para
if (section.hidden || items.length === 0) return [];
const paragraphs: Paragraph[] = [sectionHeading(section.title, colorHex)];
const baseRun = {
...(bodyFont ? { font: bodyFont } : {}),
...(bodySize ? { size: bodySize } : {}),
...(textColor ? { color: textColor } : {}),
};
const baseRun = getBaseRun();
for (const item of items) {
const degreeArea = [item.degree, item.area].filter(Boolean).join(", ");
@@ -259,11 +255,7 @@ function renderSkills(section: Sections["skills"], colorHex: string): Paragraph[
if (section.hidden || items.length === 0) return [];
const paragraphs: Paragraph[] = [sectionHeading(section.title, colorHex)];
const baseRun = {
...(bodyFont ? { font: bodyFont } : {}),
...(bodySize ? { size: bodySize } : {}),
...(textColor ? { color: textColor } : {}),
};
const baseRun = getBaseRun();
for (const item of items) {
const children: TextRun[] = [new TextRun({ text: item.name, bold: true, ...baseRun })];
@@ -287,11 +279,7 @@ function renderLanguages(section: Sections["languages"], colorHex: string): Para
if (section.hidden || items.length === 0) return [];
const paragraphs: Paragraph[] = [sectionHeading(section.title, colorHex)];
const baseRun = {
...(bodyFont ? { font: bodyFont } : {}),
...(bodySize ? { size: bodySize } : {}),
...(textColor ? { color: textColor } : {}),
};
const baseRun = getBaseRun();
for (const item of items) {
const children: TextRun[] = [new TextRun({ text: item.language, bold: true, ...baseRun })];
@@ -311,11 +299,7 @@ function renderInterests(section: Sections["interests"], colorHex: string): Para
if (section.hidden || items.length === 0) return [];
const paragraphs: Paragraph[] = [sectionHeading(section.title, colorHex)];
const baseRun = {
...(bodyFont ? { font: bodyFont } : {}),
...(bodySize ? { size: bodySize } : {}),
...(textColor ? { color: textColor } : {}),
};
const baseRun = getBaseRun();
for (const item of items) {
const children: TextRun[] = [new TextRun({ text: item.name, bold: true, ...baseRun })];
@@ -418,11 +402,7 @@ function renderReferences(section: Sections["references"], colorHex: string): Pa
if (section.hidden || items.length === 0) return [];
const paragraphs: Paragraph[] = [sectionHeading(section.title, colorHex)];
const baseRun = {
...(bodyFont ? { font: bodyFont } : {}),
...(bodySize ? { size: bodySize } : {}),
...(textColor ? { color: textColor } : {}),
};
const baseRun = getBaseRun();
for (const item of items) {
const children: TextRun[] = [new TextRun({ text: item.name, bold: true, ...baseRun })];
@@ -457,11 +437,7 @@ function renderProfiles(section: Sections["profiles"], colorHex: string): Paragr
if (section.hidden || items.length === 0) return [];
const paragraphs: Paragraph[] = [sectionHeading(section.title, colorHex)];
const baseRun = {
...(bodyFont ? { font: bodyFont } : {}),
...(bodySize ? { size: bodySize } : {}),
...(textColor ? { color: textColor } : {}),
};
const baseRun = getBaseRun();
for (const item of items) {
const children: (TextRun | ExternalHyperlink)[] = [new TextRun({ text: item.network, bold: true, ...baseRun })];