Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2025-11-11 04:52:36 +10:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1909 from DemaPy/patch-1

Browse Source 
fix(client): fix Type Error in Picture Configuration Options
This commit is contained in:
Amruth Pillai
2024-06-10 07:46:35 +02:00
committed by GitHub
parent f0ede57786 2409a5786a
commit e3b4105424
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
apps/client/src/pages/builder/sidebars/left/sections/picture/options.tsx
View File

@ -52,6 +52,7 @@ export const PictureOptions = () => {
}, [picture.aspectRatio]); }, [picture.aspectRatio]);
const onAspectRatioChange = (value: AspectRatio) => { const onAspectRatioChange = (value: AspectRatio) => {
if (!value) return
setValue("basics.picture.aspectRatio", stringToRatioMap[value]); setValue("basics.picture.aspectRatio", stringToRatioMap[value]);
}; };
@ -117,6 +118,8 @@ export const PictureOptions = () => {
id="picture.aspectRatio" id="picture.aspectRatio"
value={picture.aspectRatio} value={picture.aspectRatio}
onChange={(event) => { onChange={(event) => {
if (!event.target.valueAsNumber) return
if (isNaN(event.target.valueAsNumber)) return
setValue("basics.picture.aspectRatio", event.target.valueAsNumber); setValue("basics.picture.aspectRatio", event.target.valueAsNumber);
}} }}
/> />