Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2026-08-24 15:22:20 +10:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): throw NOT_FOUND on lock/password mutations for missing resume

Browse Source
This commit is contained in:
Amruth Pillai
2026-07-08 15:53:20 +02:00
parent 373c95733c
commit e47cf6e775
2 changed files with 18 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/api/src/features/resume/service.test.ts
+15 -12
View File
@@ -187,12 +187,13 @@ describe("setLocked", () => {
expect(publishResumeUpdatedMock).toHaveBeenCalledWith(expect.objectContaining({ mutation: "lock" })); expect(publishResumeUpdatedMock).toHaveBeenCalledWith(expect.objectContaining({ mutation: "lock" }));
}); });
// Characterizes current behavior: silent no-op when no row matches. Plan 003 flips this to // Plan 003: no matching row now rejects with NOT_FOUND (previously a silent resolve).
// reject with NOT_FOUND (that test diff is the intended signal the behavior changed). it("throws NOT_FOUND when no row matches, without notifying", async () => {
it("silently resolves undefined when no row matches, without notifying", async () => {
dbMock.update.mockReturnValueOnce(createUpdateChain([]).chain); dbMock.update.mockReturnValueOnce(createUpdateChain([]).chain);
await expect(resumeService.setLocked({ id: "r1", userId: "u1", isLocked: true })).resolves.toBeUndefined(); await expect(resumeService.setLocked({ id: "r1", userId: "u1", isLocked: true })).rejects.toMatchObject({
code: "NOT_FOUND",
});
expect(publishResumeUpdatedMock).not.toHaveBeenCalled(); expect(publishResumeUpdatedMock).not.toHaveBeenCalled();
}); });
}); });
@@ -210,12 +211,13 @@ describe("setPassword", () => {
expect(publishResumeUpdatedMock).toHaveBeenCalledWith(expect.objectContaining({ mutation: "password" })); expect(publishResumeUpdatedMock).toHaveBeenCalledWith(expect.objectContaining({ mutation: "password" }));
}); });
// Characterizes current behavior: silent no-op when no row matches. Plan 003 flips this to // Plan 003: no matching row now rejects with NOT_FOUND (previously a silent resolve).
// reject with NOT_FOUND (that test diff is the intended signal the behavior changed). it("throws NOT_FOUND when no row matches, without notifying", async () => {
it("silently resolves undefined when no row matches, without notifying", async () => {
dbMock.update.mockReturnValueOnce(createUpdateChain([]).chain); dbMock.update.mockReturnValueOnce(createUpdateChain([]).chain);
await expect(resumeService.setPassword({ id: "r1", userId: "u1", password: "secret" })).resolves.toBeUndefined(); await expect(resumeService.setPassword({ id: "r1", userId: "u1", password: "secret" })).rejects.toMatchObject({
code: "NOT_FOUND",
});
expect(publishResumeUpdatedMock).not.toHaveBeenCalled(); expect(publishResumeUpdatedMock).not.toHaveBeenCalled();
}); });
}); });
@@ -232,12 +234,13 @@ describe("removePassword", () => {
expect(publishResumeUpdatedMock).toHaveBeenCalledWith(expect.objectContaining({ mutation: "password" })); expect(publishResumeUpdatedMock).toHaveBeenCalledWith(expect.objectContaining({ mutation: "password" }));
}); });
// Characterizes current behavior: silent no-op when no row matches. Plan 003 flips this to // Plan 003: no matching row now rejects with NOT_FOUND (previously a silent resolve).
// reject with NOT_FOUND (that test diff is the intended signal the behavior changed). it("throws NOT_FOUND when no row matches, without notifying", async () => {
it("silently resolves undefined when no row matches, without notifying", async () => {
dbMock.update.mockReturnValueOnce(createUpdateChain([]).chain); dbMock.update.mockReturnValueOnce(createUpdateChain([]).chain);
await expect(resumeService.removePassword({ id: "r1", userId: "u1" })).resolves.toBeUndefined(); await expect(resumeService.removePassword({ id: "r1", userId: "u1" })).rejects.toMatchObject({
code: "NOT_FOUND",
});
expect(publishResumeUpdatedMock).not.toHaveBeenCalled(); expect(publishResumeUpdatedMock).not.toHaveBeenCalled();
}); });
}); });
packages/api/src/features/resume/service.ts
+3 -3
View File
@@ -667,7 +667,7 @@ export const resumeService = {
.where(and(eq(schema.resume.id, input.id), eq(schema.resume.userId, input.userId))) .where(and(eq(schema.resume.id, input.id), eq(schema.resume.userId, input.userId)))
.returning({ id: schema.resume.id, updatedAt: schema.resume.updatedAt }); .returning({ id: schema.resume.id, updatedAt: schema.resume.updatedAt });
if (!resume) return; if (!resume) throw new ORPCError("NOT_FOUND");
await notifyResumeUpdated({ await notifyResumeUpdated({
type: "resume.updated", type: "resume.updated",
@@ -687,7 +687,7 @@ export const resumeService = {
.where(and(eq(schema.resume.id, input.id), eq(schema.resume.userId, input.userId))) .where(and(eq(schema.resume.id, input.id), eq(schema.resume.userId, input.userId)))
.returning({ id: schema.resume.id, updatedAt: schema.resume.updatedAt }); .returning({ id: schema.resume.id, updatedAt: schema.resume.updatedAt });
if (!resume) return; if (!resume) throw new ORPCError("NOT_FOUND");
await notifyResumeUpdated({ await notifyResumeUpdated({
type: "resume.updated", type: "resume.updated",
@@ -730,7 +730,7 @@ export const resumeService = {
.where(and(eq(schema.resume.id, input.id), eq(schema.resume.userId, input.userId))) .where(and(eq(schema.resume.id, input.id), eq(schema.resume.userId, input.userId)))
.returning({ id: schema.resume.id, updatedAt: schema.resume.updatedAt }); .returning({ id: schema.resume.id, updatedAt: schema.resume.updatedAt });
if (!resume) return; if (!resume) throw new ORPCError("NOT_FOUND");
await notifyResumeUpdated({ await notifyResumeUpdated({
type: "resume.updated", type: "resume.updated",