Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2025-11-14 16:51:33 +10:00
Code Issues Packages Projects Releases Wiki Activity

Fix server crash when non-zip file is uploaded

Browse Source
This commit is contained in:
Krisjanis Lejejs
2022-10-25 22:03:18 +03:00
parent 9b1f3eda05
commit e9e595f0d0
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
server/src/integrations/integrations.service.ts
View File

@ -35,6 +35,7 @@ export class IntegrationsService {
async linkedIn(userId: number, path: string): Promise<ResumeEntity> { async linkedIn(userId: number, path: string): Promise<ResumeEntity> {
let archive: StreamZip.StreamZipAsync; let archive: StreamZip.StreamZipAsync;
let isArchiveValid = false;
try { try {
archive = new StreamZip.async({ file: path }); archive = new StreamZip.async({ file: path });
@ -48,6 +49,9 @@ export class IntegrationsService {
slug: `imported-from-linkedin-${timestamp}`, slug: `imported-from-linkedin-${timestamp}`,
}); });
// Check if archive is valid
isArchiveValid = await archive.entries().then((entries) => Object.keys(entries).length > 0);
// Profile // Profile
try { try {
const profileCSV = (await archive.entryData('Profile.csv')).toString(); const profileCSV = (await archive.entryData('Profile.csv')).toString();
@ -261,7 +265,7 @@ export class IntegrationsService {
throw new HttpException('You must upload a valid zip archive downloaded from LinkedIn.', HttpStatus.BAD_REQUEST); throw new HttpException('You must upload a valid zip archive downloaded from LinkedIn.', HttpStatus.BAD_REQUEST);
} finally { } finally {
await unlink(path); await unlink(path);
!isEmpty(archive) && archive.close(); isArchiveValid && archive.close();
} }
} }