Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2026-10-03 18:23:47 +10:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): preserve literal rich-text whitespace (#3472)

Browse Source 
* fix(web): preserve imported rich-text tables

* fix(web): harden imported table preservation

* fix(web): fail closed on lossy table markup

* chore: remove plan 16 evidence reports

* fix(web): close imported table preservation gaps

* fix(editor): preserve literal rich-text whitespace

* chore: remove plan 19 evidence report

* fix: preserve literal whitespace through layout and editor transforms

* fix: preserve whitespace in bare table cells

* chore: keep orchestration evidence untracked
This commit is contained in:
Amruth Pillai
2026-09-05 19:57:50 -07:00
committed by GitHub
parent a6057abd79
commit ea97de5ec4
16 changed files with 1141 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
patches/@react-pdf__textkit.patch
+28 -6
View File
@@ -1,8 +1,8 @@
diff --git a/lib/textkit.js b/lib/textkit.js
index 2c0ec95..3683493 100644
index 7bfe0d9a119a8bd1ec98ff0f4827bd6cb3a967a4..92821b761893c6a5132a722f72bc86c1d1e9ec89 100644
--- a/lib/textkit.js
+++ b/lib/textkit.js
@@ -709,6 +709,28 @@ const omit = (value, run) => {
@@ -715,6 +715,28 @@ const omit = (value, run) => {
return Object.assign({}, run, { attributes });
};
@@ -31,7 +31,7 @@ index 2c0ec95..3683493 100644
/**
* Get run ascent
*
@@ -718,7 +743,7 @@ const omit = (value, run) => {
@@ -724,7 +746,7 @@ const omit = (value, run) => {
const ascent$1 = (run) => {
const { font, attachment } = run.attributes;
const attachmentHeight = attachment?.height || 0;
@@ -40,7 +40,7 @@ index 2c0ec95..3683493 100644
return Math.max(attachmentHeight, fontAscent * scale(run));
};
@@ -730,7 +755,7 @@ const ascent$1 = (run) => {
@@ -736,7 +758,7 @@ const ascent$1 = (run) => {
*/
const descent = (run) => {
const font = run.attributes?.font;
@@ -49,7 +49,7 @@ index 2c0ec95..3683493 100644
return scale(run) * fontDescent;
};
@@ -742,8 +767,8 @@ const descent = (run) => {
@@ -748,8 +770,8 @@ const descent = (run) => {
*/
const lineGap = (run) => {
const font = run.attributes?.font;
@@ -60,7 +60,7 @@ index 2c0ec95..3683493 100644
};
/**
@@ -754,7 +779,8 @@ const lineGap = (run) => {
@@ -760,7 +782,8 @@ const lineGap = (run) => {
*/
const height$1 = (run) => {
const lineHeight = run.attributes?.lineHeight;
@@ -70,3 +70,25 @@ index 2c0ec95..3683493 100644
};
/**
@@ -1680,8 +1703,11 @@ const getOverflowRight = (line) => {
* @returns Line
*/
const adjustOverflow = (line) => {
- const overflowLeft = getOverflowLeft(line);
- const overflowRight = getOverflowRight(line);
+ // Preserve literal edge advances after bidi reordering. Other Text nodes
+ // retain textkit's HTML-style hanging whitespace alignment.
+ const preserveWhitespace = line.runs.some((run) => run.attributes.preserveWhitespace);
+ const overflowLeft = preserveWhitespace ? 0 : getOverflowLeft(line);
+ const overflowRight = preserveWhitespace ? 0 : getOverflowRight(line);
const x = line.box.x - overflowLeft;
const width = line.box.width + overflowLeft + overflowRight;
const box = Object.assign({}, line.box, { x, width });
@@ -1842,6 +1868,7 @@ const applyAttributes = (a) => {
opacity: a.opacity,
paddingTop: a.paddingTop || a.padding || 0,
paragraphSpacing: a.paragraphSpacing || 0,
+ preserveWhitespace: a.preserveWhitespace === true,
script: a.script || null,
shrinkFactor: a.shrinkFactor || 0,
strike: a.strike || false,