diff --git a/docs/execution/approved-issue-plans-ledger.md b/docs/execution/approved-issue-plans-ledger.md index b1506585a..9af9b4392 100644 --- a/docs/execution/approved-issue-plans-ledger.md +++ b/docs/execution/approved-issue-plans-ledger.md @@ -39,15 +39,15 @@ state changes are outside scope. | 04 AI provider compatibility | #2732, #2766, #2723, #2708 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | serialize edits to AI service | zero drift; historical #2708 Responses path and #2766 structured Test path absent; remaining tuples differ | focused API 96 and full API suites/typecheck/boundaries passed in audit | — | select wire/state/import/base-path unit only after exact current tuple fails | provider/model/base URL/path/version/action/error tuple and allowed endpoint unavailable | | 05 AI provider migrations | #3152 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | coordinate DB/startup with 03 | zero drift; table schema, migration, startup ordering, Docker copy path coherent; `42P01` historical cause unresolved | audit API/server/DB tests, typechecks, boundaries passed; no real PostgreSQL migration fixture | — | choose config/packaging/startup/migration repair only after disposable reproduction | affected image layout/digest, working directory, DB schema/search path/journal, fresh+upgrade DB fixture | | 06 image storage delivery | #2684, #2778 | blocked | audit `task_855fbee0a803` | `codex-audit-backend-01-06` | `7a98f6662` → no source change | coordinate 12/15/25 renderer/image fixtures | #2684 ACL cause fixed by merged #3432 (`35cecf9`); #2778 Browserless path obsolete; current topology unproved | #3432 hosted checks successful; audit storage/upload/PDF tests, typechecks, boundaries passed | #3432 merged before run | deployment retest plus shared real-encoding/backend/render fixture before repair | deployed digest; disposable S3/Garage/SeaweedFS/MinIO/proxy and browser/server raster matrix unavailable | -| 07 AIO deployment | #2722 | published; hosted follow-up pushed | implementation/review chain complete | `codex/issue-2722-postgres-docs` | `7a98f6662` → `a7b8c4cc5` | none | hosted review corrections distinguish image/build paths, pin quickstart PostgreSQL 17, warn on host ports, require verified cross-host TLS; five comments fixed, one rejected with evidence | Compose dry-runs, disposable PostgreSQL 17.11 migrations, Markdown/link/diff/scope green; zero unresolved threads; hosted checks rerunning | [#3457](https://github.com/amruthpillai/reactive-resume/pull/3457) | monitor exact-head checks/re-review; keep unmerged | no AIO implementation; optional Unraid host smoke unavailable | +| 07 AIO deployment | #2722 | published | implementation/review chain complete | `codex/issue-2722-postgres-docs` | `7a98f6662` → `a7b8c4cc5` | none | hosted review corrections distinguish image/build paths, pin quickstart PostgreSQL 17, warn on host ports, require verified cross-host TLS; five comments fixed, one rejected with evidence | Compose dry-runs, disposable PostgreSQL 17.11 migrations, Markdown/link/diff/scope and all hosted checks green; approved; zero unresolved threads | [#3457](https://github.com/amruthpillai/reactive-resume/pull/3457) | keep unmerged; monitor only | no AIO implementation; optional Unraid host smoke unavailable | | 08 root public resume | #2669 | plan amendment required before implementation | audit `task_9f27829ca50f` | planned `codex/issue-2669-root-resume` | `7a98f6662` → — | none | current password redirect rejects `/`; public view is slug-hook-bound; SSR canonical cannot import server env; expanded auth/canonical contract identified | audit focused API/web suites, typechecks, boundaries passed | — | amend ownership for identity-vs-return auth flow and server-derived canonical root, then dispatch coherent feature | engineering scope correction; feature remains narrower than arbitrary domain/TLS registry | | 09 external version backup | #2705 | published; hosted correction being completed | fix `task_8605c30ca032` / `ctx_2e0aa7be1312` | `codex/issue-2705-git-backup-docs` | `7a98f6662` → published `6931d2cc4`; local `2d3ca10` | none | selected commit lookup fixed; re-review proved commands still lacked explicit non-destructive recovered-file creation | 152 focused tests plus Markdown/diff/base/scope green; new synthetic file-output regression active | [#3458](https://github.com/amruthpillai/reactive-resume/pull/3458) | add recovered-file command, clean re-review, push, resolve duplicate threads | DB integration/E2E unavailable; no sync/remote/whole-account restore | | 10 legacy link routing | #2836 | pending implementation after brief correction | audit `task_9f27829ca50f` | planned `codex/issue-2836-retired-slug-notices` | `7a98f6662` → — | none | prospective same-username slug-attempt notice remains coherent; exact DB/API/UI/E2E owner set verified | audit focused API/web suites, DB/API/web typechecks, boundaries passed | — | correct final E2E target to `public-sharing.spec.ts`, then implement migration/API/owner UI atomically | historical cause absent; no redirects/emails/recovery; prospective partial coverage only | -| 11 job search policy | #3010 | published; hosted wording correction queued | hosted re-review `task_a9d8b3e0a8a2` | `codex/issue-3010-jsearch-docs` | `7a98f6662` → published `e05977007`; local `1d03978` | none | clean independent publication review; two valid low-risk hosted wording comments corrected locally | 52 focused tests plus Markdown/diff/base/scope green; follow-up Markdown/link/diff green | [#3459](https://github.com/amruthpillai/reactive-resume/pull/3459) | independently review correction, push, resolve threads | real provider/browser optional gate unavailable; removal motive unknown | +| 11 job search policy | #3010 | published; hosted wording correction under review | review `task_a9d8b3e0a8a2` / `ctx_6b03ba8f389c` | `codex/issue-3010-jsearch-docs` | `7a98f6662` → published `e05977007`; local `1d03978` | none | clean independent publication review; two valid low-risk hosted wording comments corrected locally | 52 focused tests plus Markdown/diff/base/scope green; follow-up Markdown/link/diff green | [#3459](https://github.com/amruthpillai/reactive-resume/pull/3459) | finish independent correction review, push, resolve threads | real provider/browser optional gate unavailable; removal motive unknown | | 12 preview/export failures | #3323, #3290, #3033, #3007, #2609 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer ownership; share observation harness with 18 | zero drift; staged-preview/error-boundary baselines remain; reports cross persistence/font/PDF/viewer/deployment boundaries | audit focused web/PDF suites, affected typechecks, boundaries, build passed | — | isolate PT Sans, browser/config, and template-selection boundaries; no shared fix | exact JSON/output/browser/config/current reproduction missing | | 13 font/glyph/spacing | #3249, #3159, #3147, #3093, #3089, #2988 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize font sources with 14/27 | merged metrics/cache/Unicode fixes present and passing; residuals require per-font/per-symptom fixtures | audit focused PDF/font suites, affected typechecks, boundaries, build passed | — | retain regressions; create residual unit only from exact failing font fixture | missing Ropa Sans/source strings/font hashes/before-after artifacts | | 14 RTL export layout | #3275 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize renderer/fonts with 13/27 | merged canvas-direction fix remains; broader shaping/bidi cause unproved | audit RTL/preview suites, affected typechecks, boundaries, build passed | — | run controlled same-bytes export matrix against approved shaping oracle | exact JSON/font/version and known-good reference absent | -| 15 picture fitting/style | #3168, #3088, #2794, #2782 | implementing 15A; other causes blocked | `task_557902c8adef` / `ctx_db6fae1b75c4` | `codex/issue-2782-picture-fit` | `7a98f6662` → — | coordinate 06/25; schema/PDF owner exclusion | verified contract gap: no fit field; editor/web/PDF force cover; 15A cover/contain dispatched | audit picture suites, schema/web/PDF typechecks, boundaries, build passed | — | implement explicit cover/contain with cover compatibility and cross-output geometry tests | delivery/centering issues still lack source revisions/assets/expected crop | +| 15 picture fitting/style | #3168, #3088, #2794, #2782 | pending independent review 15A; other causes blocked | implementation complete `task_557902c8adef`; review queued `task_d4f4841355e2` | `codex/issue-2782-picture-fit` | `7a98f6662` → `d891afd66` | coordinate 06/25; schema/PDF owner exclusion | explicit Cover/Contain across schema, import, builder, shared PDF, docs/catalogs and raster E2E committed | full repo tests; schema/web/PDF/import suites; typechecks/boundaries/build; 2 authenticated raster E2E green | — | independent full-diff/raster review before publication | delivery/centering issues still lack source revisions/assets/expected crop | | 16 imported table borders | #3196 | pending implementation | unassigned | planned `codex/issue-3196-editable-tables` | `7a98f6662` → — | rich-text owner; must precede 19/31 | editor lacks table extensions; Q11 approves editable supported tables; atomic editor/HTML/PDF unit ready | audit current table/rich-input regressions, affected typechecks, boundaries, build passed | — | implement via TDD, including persistence, undo/redo, borders, and lossless unsupported fallback | historical visual equivalence lacks reporter HTML/JSON but feature contract is approved | | 17 list/skill pagination | #2751, #3040 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer owner shared with 13/14/18 | merged ordered-marker/wrap/level-gap fixes present; current residual not reproduced | audit focused PDF suites, typecheck, boundaries, build passed | — | retain controls; add fix only from exact failing list/skill fixture | #2751 source absent; #3040 current fixture no longer proves residual clipping | | 18 preview/export geometry | #2683 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | share output-boundary harness with 12; viewer owner exclusion | current viewport/page-size/margin baselines pass; video alone cannot locate cause | audit page/preview tests, affected typechecks, boundaries, build passed | — | compare identical preview/download bytes, MediaBoxes, ink bounds, viewport, DPR | exact JSON/PDF/browser/DPR/zoom/page settings absent | @@ -98,8 +98,9 @@ state changes are outside scope. | Plan 11 independent review | `task_7d5d4c1417a9` / `ctx_17ee05faf9e7` | same Plan 11 worktree | complete; changes required | attachment-format overclaim and duplicated patch/restore guidance | | Plan 11 review fix | `task_351a96e90b69` / `ctx_e398c9128731` | same Plan 11 worktree | complete; worker released | commit `e05977007`; attachment promise removed and adjacent guidance deduplicated | | Plan 11 re-review | `task_86a66b578544` / `ctx_3bb8017e8676` | same Plan 11 worktree | complete; no findings; worker released | exact head `e05977007`; 52 focused tests and full diff verified before PR #3459 | -| Plan 11 hosted review follow-up | `task_a9d8b3e0a8a2` | same Plan 11 worktree | local fix committed; review queued | commit `1d03978`; sample wording plus heading/UI terminology alignment | -| Plan 15A implementation | `task_557902c8adef` / `ctx_db6fae1b75c4` | `codex/issue-2782-picture-fit` | implementing | explicit cover/contain contract across schema/editor/preview/PDF | +| Plan 11 hosted review follow-up | `task_a9d8b3e0a8a2` / `ctx_6b03ba8f389c` | same Plan 11 worktree | reviewing | commit `1d03978`; sample wording plus heading/UI terminology alignment | +| Plan 15A implementation | `task_557902c8adef` / `ctx_db6fae1b75c4` | `codex/issue-2782-picture-fit` | complete; worker released | commit `d891afd66`; explicit cover/contain contract across schema/editor/preview/PDF | +| Plan 15A independent review | `task_d4f4841355e2` | same Plan 15A worktree | ready; awaiting slot | full 70-file diff, raster/E2E reliability, schema/import/UI/PDF compatibility | | Plan 07 hosted review follow-up | `task_6e9bc84ca2d4` / `ctx_e31d0e345240` | `codex/issue-2722-postgres-docs` | no findings; pushed; worker released | commit `a7b8c4c`; five valid comments fixed, `--no-deps` removal rejected; six replies and zero unresolved threads | ## Existing PR and residual accounting @@ -118,7 +119,7 @@ state changes are outside scope. - Coordinator ledger: PR #3456 (`codex/issue-execution-ledger` → `main`), open and intentionally unmerged. - Plan 07: PR [#3457](https://github.com/amruthpillai/reactive-resume/pull/3457), open and intentionally unmerged; - current head `a7b8c4cc5754c1249534d0ed8993e67e57e2cb87` after independently reviewed hosted-comment corrections; checks rerunning. + current head `a7b8c4cc5754c1249534d0ed8993e67e57e2cb87`; all hosted checks green, approved, mergeable, zero unresolved threads. - Plan 09: PR [#3458](https://github.com/amruthpillai/reactive-resume/pull/3458), open and intentionally unmerged; published head `6931d2cc4a512e53dfd51575ad729bb9f6da5249` after clean re-review and fresh 152-test verification. - Plan 11: PR [#3459](https://github.com/amruthpillai/reactive-resume/pull/3459), open and intentionally unmerged; diff --git a/docs/execution/briefs/review-plan-15a.md b/docs/execution/briefs/review-plan-15a.md new file mode 100644 index 000000000..a7561c2be --- /dev/null +++ b/docs/execution/briefs/review-plan-15a.md @@ -0,0 +1,24 @@ +# Independently review plan 15A picture fitting + +Review only. Read pinned approved plan 15, current `AGENTS.md`, RTK, applicable code-review skill, implementation report, +and complete `origin/main...d891afd667dc571dcee642d54f851f6bde45fad8` diff. Revalidate live issue/PR/base state. + +Review Standards and Spec axes. Verify: + +- schema/default/sample/v4 import compatibility defaults missing/invalid fit to Cover without corrupting data; +- Cover retains current crop dialog, cancel/error/locked/autosave/undo behavior; Contain uploads full selected file through + existing validated storage path and never implies already-cropped pixels can be restored; +- sidebar and every PDF template route through one shared fit contract; semantic CSS precedence and borders/shadows stay + correct; Cover output remains backward compatible; +- controls are named, accessible, localized through correct catalog workflow, and generated docs/skill schema match source; +- tests assert behavior rather than implementation, raster tolerances are meaningful, E2E does not add brittle global + state, hardcoded local assumptions, unsafe cleanup, production-only dependencies, or a hidden network requirement; +- exact issue #2782 scope; no claims for #3168/#3088/#2794 and no unrelated generated artifacts. + +Run fresh base/live checks, focused schema/web/PDF/import tests, affected typechecks, boundaries, narrow Biome/catalog/docs, +diff/scope. Inspect E2E source and run dedicated raster E2E when disposable DB/ports are safely available; otherwise state +exact gate. Do not accept implementation report as proof without independent commands/probes. + +Write `.orchestration/plan-15a-review.md` with findings first and file/line evidence, exact head, commands/results, skips, +risks, and publication verdict. Do not edit tracked files, push, open PR, merge, mutate issues, or spawn subagents. Final +response at most ten lines.