Reactive-Resume

5,708 Commits 4 Branches 139 Tags

3 Commits

Include renames

Author	SHA1	Message	Date
Kaushik N MrTig-afk Amruth Pillai	bad431b2fc	fix(import): auto-detect JSON format and show readable errors (#1 ) (#3296 ) * fix(import): auto-detect JSON format and show readable errors (#1) Readable import errors, a fail-soft v4 parser, and auto-detect of the JSON format so uploads just work. The format dropdown becomes an optional override. PDF and DOCX (AI) paths are untouched. * fix(import): address review feedback on the v4 guard and error message - reactive-resume-v4-json.tsx: reject arrays in isRecord so array-valued basics, sections, or metadata no longer pass the v4 shape guard. - reactive-resume-v4-json.tsx: reuse the guard's error instance in the catch arm instead of allocating a duplicate NOT_V4_MESSAGE. - error.ts: use a singular "Problem" label for root-level Zod issues so the message stays grammatical. - add a regression test for array-valued v4 branches. * fix(import): preserve selected JSON format * test(import): cover selected JSON parser --------- Co-authored-by: MrTig-afk <MrTig-afk@users.noreply.github.com> Co-authored-by: Amruth Pillai <im.amruth@gmail.com>	2026-08-13 23:01:06 +02:00
Amruth Pillai	afd734dd61	refactor(import): add v4section/v4url aliases, inline clamp wrappers, replace classes with fns Finding 5: Introduce V4Url + V4Section<T> type aliases in reactive-resume-v4-json.tsx; collapse 310-line V4ResumeData type (13x 5-field section header, 11x {label,href}) into typed aliases. Inferred shape is structurally identical. Finding 6: Remove 9 single-caller clamp/pxToPt wrappers; replace compile-time constants (rotation=0, sidebarWidth=35, shadowWidth=0, gapX=4, gapY=6) with literals; inline dynamic calls (clamp(x, 32, 512) etc.) at the two body/heading typography call sites. Finding 7: Convert three stateless single-method importer classes to plain functions. Extract shared rethrowAsImportError() to error.ts, replacing triplicated ZodError catch blocks. Update web import dialog + all in-package test files to use function API. Claude-Session: https://claude.ai/code/session_012Bnvt1MghwHj4qQRxuQUGa	2026-07-04 21:02:17 +02:00
Nicolas Oddo	fa38f3e84a	fix: correct v4 to v5 import for custom sections, skill levels, and hidden items (#3013 )	2026-05-09 18:48:21 +02:00

Author

SHA1

Message

Date

bad431b2fc

fix(import): auto-detect JSON format and show readable errors (#1 ) (#3296 )

* fix(import): auto-detect JSON format and show readable errors (#1)

Readable import errors, a fail-soft v4 parser, and auto-detect of the JSON format so uploads just work. The format dropdown becomes an optional override. PDF and DOCX (AI) paths are untouched.

* fix(import): address review feedback on the v4 guard and error message

- reactive-resume-v4-json.tsx: reject arrays in isRecord so array-valued
  basics, sections, or metadata no longer pass the v4 shape guard.
- reactive-resume-v4-json.tsx: reuse the guard's error instance in the
  catch arm instead of allocating a duplicate NOT_V4_MESSAGE.
- error.ts: use a singular "Problem" label for root-level Zod issues so
  the message stays grammatical.
- add a regression test for array-valued v4 branches.

* fix(import): preserve selected JSON format

* test(import): cover selected JSON parser

---------

Co-authored-by: MrTig-afk <MrTig-afk@users.noreply.github.com>
Co-authored-by: Amruth Pillai <im.amruth@gmail.com>

2026-08-13 23:01:06 +02:00

Amruth Pillai

afd734dd61

refactor(import): add v4section/v4url aliases, inline clamp wrappers, replace classes with fns

Finding 5: Introduce V4Url + V4Section<T> type aliases in reactive-resume-v4-json.tsx; collapse
310-line V4ResumeData type (13x 5-field section header, 11x {label,href}) into typed aliases.
Inferred shape is structurally identical.

Finding 6: Remove 9 single-caller clamp/pxToPt wrappers; replace compile-time constants
(rotation=0, sidebarWidth=35, shadowWidth=0, gapX=4, gapY=6) with literals; inline dynamic
calls (clamp(x, 32, 512) etc.) at the two body/heading typography call sites.

Finding 7: Convert three stateless single-method importer classes to plain functions.
Extract shared rethrowAsImportError() to error.ts, replacing triplicated ZodError catch blocks.
Update web import dialog + all in-package test files to use function API.

Claude-Session: https://claude.ai/code/session_012Bnvt1MghwHj4qQRxuQUGa

2026-07-04 21:02:17 +02:00

Nicolas Oddo

fa38f3e84a

fix: correct v4 to v5 import for custom sections, skill levels, and hidden items (#3013 )

2026-05-09 18:48:21 +02:00