mirror of
https://github.com/Shadowfita/docmost.git
synced 2025-11-18 10:41:04 +10:00
fix space member count
* fix space added_by_id * rename user role change endpoints
This commit is contained in:
@ -147,7 +147,7 @@ export class SpaceMemberService {
|
||||
spaceId: dto.spaceId,
|
||||
userId: user.id,
|
||||
role: dto.role,
|
||||
creatorId: authUser.id,
|
||||
addedById: authUser.id,
|
||||
});
|
||||
}
|
||||
|
||||
@ -157,7 +157,7 @@ export class SpaceMemberService {
|
||||
spaceId: dto.spaceId,
|
||||
groupId: group.id,
|
||||
role: dto.role,
|
||||
creatorId: authUser.id,
|
||||
addedById: authUser.id,
|
||||
});
|
||||
}
|
||||
|
||||
@ -172,7 +172,6 @@ export class SpaceMemberService {
|
||||
|
||||
async removeMemberFromSpace(
|
||||
dto: RemoveSpaceMemberDto,
|
||||
authUser: User, // Todo: permissions check
|
||||
workspaceId: string,
|
||||
): Promise<void> {
|
||||
const space = await this.spaceRepo.findById(dto.spaceId, workspaceId);
|
||||
@ -218,7 +217,6 @@ export class SpaceMemberService {
|
||||
|
||||
async updateSpaceMemberRole(
|
||||
dto: UpdateSpaceMemberRoleDto,
|
||||
authUser: User,
|
||||
workspaceId: string,
|
||||
): Promise<void> {
|
||||
const space = await this.spaceRepo.findById(dto.spaceId, workspaceId);
|
||||
|
||||
@ -147,15 +147,11 @@ export class SpaceController {
|
||||
throw new ForbiddenException();
|
||||
}
|
||||
|
||||
return this.spaceMemberService.removeMemberFromSpace(
|
||||
dto,
|
||||
user,
|
||||
workspace.id,
|
||||
);
|
||||
return this.spaceMemberService.removeMemberFromSpace(dto, workspace.id);
|
||||
}
|
||||
|
||||
@HttpCode(HttpStatus.OK)
|
||||
@Post('members/role')
|
||||
@Post('members/change-role')
|
||||
async updateSpaceMemberRole(
|
||||
@Body() dto: UpdateSpaceMemberRoleDto,
|
||||
@AuthUser() user: User,
|
||||
@ -168,11 +164,7 @@ export class SpaceController {
|
||||
throw new ForbiddenException();
|
||||
}
|
||||
|
||||
return this.spaceMemberService.updateSpaceMemberRole(
|
||||
dto,
|
||||
user,
|
||||
workspace.id,
|
||||
);
|
||||
return this.spaceMemberService.updateSpaceMemberRole(dto, workspace.id);
|
||||
}
|
||||
|
||||
validateIds(dto: RemoveSpaceMemberDto | UpdateSpaceMemberRoleDto) {
|
||||
|
||||
@ -91,7 +91,7 @@ export class WorkspaceController {
|
||||
ability.can(Action.Manage, 'WorkspaceUser'),
|
||||
)
|
||||
@HttpCode(HttpStatus.OK)
|
||||
@Post('members/role')
|
||||
@Post('members/change-role')
|
||||
async updateWorkspaceMemberRole(
|
||||
@Body() workspaceUserRoleDto: UpdateWorkspaceUserRoleDto,
|
||||
@AuthUser() authUser: User,
|
||||
|
||||
Reference in New Issue
Block a user