Allow creation of space

* other fixes and cleanups

apps/server/src/core/space/dto/create-space.dto.ts

@@ -2,7 +2,7 @@ import { IsOptional, IsString, MaxLength, MinLength } from 'class-validator';
 
 export class CreateSpaceDto {
   @MinLength(2)
-  @MaxLength(64)
+  @MaxLength(50)
   @IsString()
   name: string;
 
@@ -11,7 +11,7 @@ export class CreateSpaceDto {
   description?: string;
 
   @MinLength(2)
-  @MaxLength(64)
+  @MaxLength(50)
   @IsString()
   slug: string;
 }

apps/server/src/core/space/services/space.service.ts

@@ -6,14 +6,54 @@ import {
 import { CreateSpaceDto } from '../dto/create-space.dto';
 import { PaginationOptions } from '@docmost/db/pagination/pagination-options';
 import { SpaceRepo } from '@docmost/db/repos/space/space.repo';
-import { KyselyTransaction } from '@docmost/db/types/kysely.types';
-import { Space } from '@docmost/db/types/entity.types';
+import { KyselyDB, KyselyTransaction } from '@docmost/db/types/kysely.types';
+import { Space, User } from '@docmost/db/types/entity.types';
 import { PaginationResult } from '@docmost/db/pagination/pagination';
 import { UpdateSpaceDto } from '../dto/update-space.dto';
+import { executeTx } from '@docmost/db/utils';
+import { InjectKysely } from 'nestjs-kysely';
+import { SpaceMemberService } from './space-member.service';
+import { SpaceRole } from '../../../common/helpers/types/permission';
 
 @Injectable()
 export class SpaceService {
-  constructor(private spaceRepo: SpaceRepo) {}
+  constructor(
+    private spaceRepo: SpaceRepo,
+    private spaceMemberService: SpaceMemberService,
+    @InjectKysely() private readonly db: KyselyDB,
+  ) {}
+
+  async createSpace(
+    authUser: User,
+    workspaceId: string,
+    createSpaceDto: CreateSpaceDto,
+    trx?: KyselyTransaction,
+  ): Promise<Space> {
+    let space = null;
+
+    await executeTx(
+      this.db,
+      async (trx) => {
+        space = await this.create(
+          authUser.id,
+          workspaceId,
+          createSpaceDto,
+          trx,
+        );
+
+        await this.spaceMemberService.addUserToSpace(
+          authUser.id,
+          space.id,
+          SpaceRole.ADMIN,
+          workspaceId,
+          trx,
+        );
+      },
+      trx,
+    );
+
+    return { ...space, memberCount: 1 };
+  }
 
   async create(
     userId: string,
@@ -28,7 +68,7 @@ export class SpaceService {
     );
     if (slugExists) {
       throw new BadRequestException(
-        'Slug exists. Please use a unique space slug',
+        'Space slug exists. Please use a unique space slug',
       );
     }
 

apps/server/src/core/space/space.controller.ts

@@ -28,6 +28,12 @@ import {
 import { UpdateSpaceDto } from './dto/update-space.dto';
 import { findHighestUserSpaceRole } from '@docmost/db/repos/space/utils';
 import { SpaceMemberRepo } from '@docmost/db/repos/space/space-member.repo';
+import {
+  WorkspaceCaslAction,
+  WorkspaceCaslSubject,
+} from '../casl/interfaces/workspace-ability.type';
+import WorkspaceAbilityFactory from '../casl/abilities/workspace-ability.factory';
+import { CreateSpaceDto } from './dto/create-space.dto';
 
 @UseGuards(JwtAuthGuard)
 @Controller('spaces')
@@ -37,6 +43,7 @@ export class SpaceController {
     private readonly spaceMemberService: SpaceMemberService,
     private readonly spaceMemberRepo: SpaceMemberRepo,
     private readonly spaceAbility: SpaceAbilityFactory,
+    private readonly workspaceAbility: WorkspaceAbilityFactory,
   ) {}
 
   @HttpCode(HttpStatus.OK)
@@ -86,6 +93,22 @@ export class SpaceController {
     return { ...space, membership };
   }
 
+  @HttpCode(HttpStatus.OK)
+  @Post('create')
+  createGroup(
+    @Body() createSpaceDto: CreateSpaceDto,
+    @AuthUser() user: User,
+    @AuthWorkspace() workspace: Workspace,
+  ) {
+    const ability = this.workspaceAbility.createForUser(user, workspace);
+    if (
+      ability.cannot(WorkspaceCaslAction.Manage, WorkspaceCaslSubject.Space)
+    ) {
+      throw new ForbiddenException();
+    }
+    return this.spaceService.createSpace(user, workspace.id, createSpaceDto);
+  }
+
   @HttpCode(HttpStatus.OK)
   @Post('update')
   async updateGroup(