throw early

This commit is contained in:
Philipinho
2025-07-14 03:53:07 -07:00
parent f4082171ec
commit 5f5f1484db

View File

@ -146,7 +146,6 @@ export class PageController {
return this.pageService.getRecentPages(user.id, pagination); return this.pageService.getRecentPages(user.id, pagination);
} }
// TODO: scope to workspaces
@HttpCode(HttpStatus.OK) @HttpCode(HttpStatus.OK)
@Post('/history') @Post('/history')
async getPageHistory( async getPageHistory(
@ -155,6 +154,10 @@ export class PageController {
@AuthUser() user: User, @AuthUser() user: User,
) { ) {
const page = await this.pageRepo.findById(dto.pageId); const page = await this.pageRepo.findById(dto.pageId);
if (!page) {
throw new NotFoundException('Page not found');
}
const ability = await this.spaceAbility.createForUser(user, page.spaceId); const ability = await this.spaceAbility.createForUser(user, page.spaceId);
if (ability.cannot(SpaceCaslAction.Read, SpaceCaslSubject.Page)) { if (ability.cannot(SpaceCaslAction.Read, SpaceCaslSubject.Page)) {
throw new ForbiddenException(); throw new ForbiddenException();