Ryan/docmost
1
0
Fork 0
mirror of https://github.com/docmost/docmost.git synced 2026-07-14 09:46:43 +10:00
Code Issues Packages Projects Releases Wiki Activity

WIP 5

Browse Source
This commit is contained in:
Philipinho
2025-12-31 10:16:54 +00:00
parent 0c3901abf5
commit 8eb698648e
3 changed files with 22 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/server/src/core/comment/comment.controller.ts
+5 -16
View File
@@ -49,12 +49,6 @@ export class CommentController {
throw new NotFoundException('Page not found');
}
const ability = await this.spaceAbility.createForUser(user, page.spaceId);
if (ability.cannot(SpaceCaslAction.Create, SpaceCaslSubject.Page)) {
throw new ForbiddenException();
}
// Check page-level edit permission (comments require edit access)
await this.pageAccessService.validateCanEdit(page, user);
return this.commentService.create(
@@ -80,9 +74,6 @@ export class CommentController {
throw new NotFoundException('Page not found');
}
//
// Checks both space-level and page-level permissions
await this.pageAccessService.validateCanView(page, user);
return this.commentService.findByPageId(page.id, pagination);
@@ -101,7 +92,6 @@ export class CommentController {
throw new NotFoundException('Page not found');
}
// Checks both space-level and page-level permissions
await this.pageAccessService.validateCanView(page, user);
return comment;
@@ -120,7 +110,6 @@ export class CommentController {
throw new NotFoundException('Page not found');
}
// Checks both space-level and page-level edit permissions
await this.pageAccessService.validateCanEdit(page, user);
return this.commentService.update(comment, dto, user);
@@ -142,11 +131,6 @@ export class CommentController {
// Check page-level edit permission first
await this.pageAccessService.validateCanEdit(page, user);
const ability = await this.spaceAbility.createForUser(
user,
comment.spaceId,
);
// Check if user is the comment owner
const isOwner = comment.creatorId === user.id;
@@ -155,6 +139,11 @@ export class CommentController {
return;
}
const ability = await this.spaceAbility.createForUser(
user,
comment.spaceId,
);
// Space admin can delete any comment
if (ability.cannot(SpaceCaslAction.Manage, SpaceCaslSubject.Settings)) {
throw new ForbiddenException(