From e7b4f2110f2833bc0c1feb82f50f798b548c0954 Mon Sep 17 00:00:00 2001 From: Philipinho <16838612+Philipinho@users.noreply.github.com> Date: Tue, 11 Aug 2026 21:11:04 +0100 Subject: [PATCH] refactor(client): type comparePairAtom initializer so setters infer as writable --- apps/client/src/features/page-history/atoms/history-atoms.ts | 4 +++- .../src/features/page-history/components/history-list.tsx | 3 --- .../src/features/page-history/hooks/use-history-reset.ts | 1 - 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/apps/client/src/features/page-history/atoms/history-atoms.ts b/apps/client/src/features/page-history/atoms/history-atoms.ts index 900321ee6..32b65a20f 100644 --- a/apps/client/src/features/page-history/atoms/history-atoms.ts +++ b/apps/client/src/features/page-history/atoms/history-atoms.ts @@ -11,4 +11,6 @@ export const diffCountsAtom = atom(null); export type ComparePair = { newerId: string; olderId: string }; export const compareModeAtom = atom(false); export const compareSelectionAtom = atom([]); -export const comparePairAtom = atom(null); +export const comparePairAtom = atom( + null as ComparePair | null, +); diff --git a/apps/client/src/features/page-history/components/history-list.tsx b/apps/client/src/features/page-history/components/history-list.tsx index 6720dd27a..d82ade3b4 100644 --- a/apps/client/src/features/page-history/components/history-list.tsx +++ b/apps/client/src/features/page-history/components/history-list.tsx @@ -38,7 +38,6 @@ function HistoryList({ pageId }: Props) { const setHistoryModalOpen = useSetAtom(historyAtoms); const [compareMode, setCompareMode] = useAtom(compareModeAtom); const [compareSelection, setCompareSelection] = useAtom(compareSelectionAtom); - // @ts-ignore const setComparePair = useSetAtom(comparePairAtom); const { @@ -87,7 +86,6 @@ function HistoryList({ pageId }: Props) { const handleSelect = useCallback( (id: string, index: number) => { - // @ts-ignore setComparePair(null); setActiveHistoryId(id); setActiveHistoryPrevId(historyItems[index + 1]?.id ?? ""); @@ -108,7 +106,6 @@ function HistoryList({ pageId }: Props) { const handleStartCompare = useCallback( (id: string) => { - // @ts-ignore setComparePair(null); setCompareMode(true); setCompareSelection([id]); diff --git a/apps/client/src/features/page-history/hooks/use-history-reset.ts b/apps/client/src/features/page-history/hooks/use-history-reset.ts index acaafcf0f..8c0286e99 100644 --- a/apps/client/src/features/page-history/hooks/use-history-reset.ts +++ b/apps/client/src/features/page-history/hooks/use-history-reset.ts @@ -26,7 +26,6 @@ export function useHistoryReset(pageId: string) { const resetCompare = () => { setCompareMode(false); setCompareSelection([]); - // @ts-ignore setComparePair(null); };