From 1a73c68d07a20216d03c9c16aa65d02880b58725 Mon Sep 17 00:00:00 2001
From: Ephraim Duncan <55143799+ephraimduncan@users.noreply.github.com>
Date: Mon, 21 Oct 2024 04:33:21 +0000
Subject: [PATCH] fix: close direct link dialog when you click on save (#1412)

---
 .../templates/template-direct-link-dialog.tsx          | 10 ++++++----
 .../app-tests/e2e/templates/direct-templates.spec.ts   |  1 -
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/apps/web/src/app/(dashboard)/templates/template-direct-link-dialog.tsx b/apps/web/src/app/(dashboard)/templates/template-direct-link-dialog.tsx
index 2a5a92992..90cd2c5d4 100644
--- a/apps/web/src/app/(dashboard)/templates/template-direct-link-dialog.tsx
+++ b/apps/web/src/app/(dashboard)/templates/template-direct-link-dialog.tsx
@@ -434,12 +434,14 @@ export const TemplateDirectLinkDialog = ({
                   <Button
                     type="button"
                     loading={isTogglingTemplateAccess}
-                    onClick={async () =>
-                      toggleTemplateDirectLink({
+                    onClick={async () => {
+                      await toggleTemplateDirectLink({
                         templateId: template.id,
                         enabled: isEnabled,
-                      })
-                    }
+                      }).catch((e) => null);
+
+                      onOpenChange(false);
+                    }}
                   >
                     <Trans>Save</Trans>
                   </Button>
diff --git a/packages/app-tests/e2e/templates/direct-templates.spec.ts b/packages/app-tests/e2e/templates/direct-templates.spec.ts
index 9dc49ee3e..a15c3ff28 100644
--- a/packages/app-tests/e2e/templates/direct-templates.spec.ts
+++ b/packages/app-tests/e2e/templates/direct-templates.spec.ts
@@ -112,7 +112,6 @@ test('[DIRECT_TEMPLATES]: toggle direct template link', async ({ page }) => {
     await page.getByRole('switch').click();
     await page.getByRole('button', { name: 'Save' }).click();
     await expect(page.getByText('Direct link signing has been').first()).toBeVisible();
-    await page.getByLabel('Direct Link Signing', { exact: true }).press('Escape');
 
     // Check that the direct template link is no longer accessible.
     await page.goto(formatDirectTemplatePath(template.directLink?.token || ''));