From f8bf4fea36dc51e11021e802bd55f7cd1ba66282 Mon Sep 17 00:00:00 2001
From: nsylke <nicksylke@outlook.com>
Date: Sat, 26 Aug 2023 09:53:58 -0500
Subject: [PATCH 1/2] feat: set min/max lengths for password

---
 apps/web/src/components/forms/password.tsx | 8 ++++++--
 apps/web/src/components/forms/signin.tsx   | 4 +++-
 apps/web/src/components/forms/signup.tsx   | 4 +++-
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/apps/web/src/components/forms/password.tsx b/apps/web/src/components/forms/password.tsx
index eba0c9a43..de3161433 100644
--- a/apps/web/src/components/forms/password.tsx
+++ b/apps/web/src/components/forms/password.tsx
@@ -18,8 +18,8 @@ import { FormErrorMessage } from '../form/form-error-message';
 
 export const ZPasswordFormSchema = z
   .object({
-    password: z.string().min(6),
-    repeatedPassword: z.string().min(6),
+    password: z.string().min(6).max(72),
+    repeatedPassword: z.string().min(6).max(72),
   })
   .refine((data) => data.password === data.repeatedPassword, {
     message: 'Passwords do not match',
@@ -92,6 +92,8 @@ export const PasswordForm = ({ className }: PasswordFormProps) => {
         <Input
           id="password"
           type="password"
+          minLength={6}
+          maxLength={72}
           className="bg-background mt-2"
           {...register('password')}
         />
@@ -107,6 +109,8 @@ export const PasswordForm = ({ className }: PasswordFormProps) => {
         <Input
           id="repeated-password"
           type="password"
+          minLength={6}
+          maxLength={72}
           className="bg-background mt-2"
           {...register('repeatedPassword')}
         />
diff --git a/apps/web/src/components/forms/signin.tsx b/apps/web/src/components/forms/signin.tsx
index ae9540869..280b0d770 100644
--- a/apps/web/src/components/forms/signin.tsx
+++ b/apps/web/src/components/forms/signin.tsx
@@ -15,7 +15,7 @@ import { useToast } from '@documenso/ui/primitives/use-toast';
 
 export const ZSignInFormSchema = z.object({
   email: z.string().email().min(1),
-  password: z.string().min(1),
+  password: z.string().min(6).max(72),
 });
 
 export type TSignInFormSchema = z.infer<typeof ZSignInFormSchema>;
@@ -99,6 +99,8 @@ export const SignInForm = ({ className }: SignInFormProps) => {
         <Input
           id="password"
           type="password"
+          minLength={6}
+          maxLength={72}
           className="bg-background mt-2"
           {...register('password')}
         />
diff --git a/apps/web/src/components/forms/signup.tsx b/apps/web/src/components/forms/signup.tsx
index ce449f850..89669e667 100644
--- a/apps/web/src/components/forms/signup.tsx
+++ b/apps/web/src/components/forms/signup.tsx
@@ -18,7 +18,7 @@ import { useToast } from '@documenso/ui/primitives/use-toast';
 export const ZSignUpFormSchema = z.object({
   name: z.string().min(1),
   email: z.string().email().min(1),
-  password: z.string().min(1),
+  password: z.string().min(6).max(72),
 });
 
 export type TSignUpFormSchema = z.infer<typeof ZSignUpFormSchema>;
@@ -105,6 +105,8 @@ export const SignUpForm = ({ className }: SignUpFormProps) => {
         <Input
           id="password"
           type="password"
+          minLength={6}
+          maxLength={72}
           className="bg-background mt-2"
           {...register('password')}
         />

From 7ad3365b0ef554b761320026475220426358a1b8 Mon Sep 17 00:00:00 2001
From: nsylke <nicksylke@outlook.com>
Date: Sat, 26 Aug 2023 10:22:44 -0500
Subject: [PATCH 2/2] feat: add autocomplete for password managers

---
 apps/web/src/components/forms/password.tsx | 2 ++
 apps/web/src/components/forms/signin.tsx   | 1 +
 apps/web/src/components/forms/signup.tsx   | 1 +
 3 files changed, 4 insertions(+)

diff --git a/apps/web/src/components/forms/password.tsx b/apps/web/src/components/forms/password.tsx
index de3161433..7c595421e 100644
--- a/apps/web/src/components/forms/password.tsx
+++ b/apps/web/src/components/forms/password.tsx
@@ -94,6 +94,7 @@ export const PasswordForm = ({ className }: PasswordFormProps) => {
           type="password"
           minLength={6}
           maxLength={72}
+          autoComplete="new-password"
           className="bg-background mt-2"
           {...register('password')}
         />
@@ -111,6 +112,7 @@ export const PasswordForm = ({ className }: PasswordFormProps) => {
           type="password"
           minLength={6}
           maxLength={72}
+          autoComplete="new-password"
           className="bg-background mt-2"
           {...register('repeatedPassword')}
         />
diff --git a/apps/web/src/components/forms/signin.tsx b/apps/web/src/components/forms/signin.tsx
index 280b0d770..9e9a01976 100644
--- a/apps/web/src/components/forms/signin.tsx
+++ b/apps/web/src/components/forms/signin.tsx
@@ -101,6 +101,7 @@ export const SignInForm = ({ className }: SignInFormProps) => {
           type="password"
           minLength={6}
           maxLength={72}
+          autoComplete="current-password"
           className="bg-background mt-2"
           {...register('password')}
         />
diff --git a/apps/web/src/components/forms/signup.tsx b/apps/web/src/components/forms/signup.tsx
index 89669e667..917ae545b 100644
--- a/apps/web/src/components/forms/signup.tsx
+++ b/apps/web/src/components/forms/signup.tsx
@@ -107,6 +107,7 @@ export const SignUpForm = ({ className }: SignUpFormProps) => {
           type="password"
           minLength={6}
           maxLength={72}
+          autoComplete="new-password"
           className="bg-background mt-2"
           {...register('password')}
         />