From 28f51770643c6c0664586e0cb48b176f41a0b141 Mon Sep 17 00:00:00 2001 From: David Nguyen Date: Fri, 14 Feb 2025 16:14:02 +1100 Subject: [PATCH] fix: dialogs with search params --- apps/remix/app/components/dialogs/team-create-dialog.tsx | 2 +- .../document/document-recipient-link-copy-dialog.tsx | 2 +- .../lib/client-only/hooks/use-update-search-params.ts | 8 +++----- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/apps/remix/app/components/dialogs/team-create-dialog.tsx b/apps/remix/app/components/dialogs/team-create-dialog.tsx index a40a52850..0b49e9b6d 100644 --- a/apps/remix/app/components/dialogs/team-create-dialog.tsx +++ b/apps/remix/app/components/dialogs/team-create-dialog.tsx @@ -119,7 +119,7 @@ export const TeamCreateDialog = ({ trigger, ...props }: TeamCreateDialogProps) = setOpen(true); updateSearchParams({ action: null }); } - }, [actionSearchParam, open, setOpen, updateSearchParams]); + }, [actionSearchParam, open]); useEffect(() => { form.reset(); diff --git a/apps/remix/app/components/general/document/document-recipient-link-copy-dialog.tsx b/apps/remix/app/components/general/document/document-recipient-link-copy-dialog.tsx index 76ba4f56b..c347a7e94 100644 --- a/apps/remix/app/components/general/document/document-recipient-link-copy-dialog.tsx +++ b/apps/remix/app/components/general/document/document-recipient-link-copy-dialog.tsx @@ -67,7 +67,7 @@ export const DocumentRecipientLinkCopyDialog = ({ setOpen(true); updateSearchParams({ action: null }); } - }, [actionSearchParam, open, setOpen, updateSearchParams]); + }, [actionSearchParam, open]); return ( setOpen(value)}> diff --git a/packages/lib/client-only/hooks/use-update-search-params.ts b/packages/lib/client-only/hooks/use-update-search-params.ts index 2c86c42cb..067bb41a5 100644 --- a/packages/lib/client-only/hooks/use-update-search-params.ts +++ b/packages/lib/client-only/hooks/use-update-search-params.ts @@ -1,9 +1,7 @@ -import { useLocation, useNavigate, useSearchParams } from 'react-router'; +import { useSearchParams } from 'react-router'; export const useUpdateSearchParams = () => { - const navigate = useNavigate(); - const { pathname } = useLocation(); - const [searchParams] = useSearchParams(); + const [searchParams, setSearchParams] = useSearchParams(); return (params: Record) => { const nextSearchParams = new URLSearchParams(searchParams?.toString() ?? ''); @@ -16,6 +14,6 @@ export const useUpdateSearchParams = () => { } }); - void navigate(`${pathname}?${nextSearchParams.toString()}`); + setSearchParams(nextSearchParams); }; };