fix: pr review changes

This commit is contained in:
Ephraim Atta-Duncan
2024-04-08 17:26:25 +00:00
parent fdf4d03c14
commit 32348dd6f1
3 changed files with 6 additions and 14 deletions

View File

@ -60,7 +60,6 @@ export default async function AdminStatsPage() {
<CardMetric icon={UserPlus2} title="App Version" value={`v${process.env.APP_VERSION}`} /> <CardMetric icon={UserPlus2} title="App Version" value={`v${process.env.APP_VERSION}`} />
</div> </div>
{/* TODO: remove grid and see something */}
<div className="mt-16 gap-8"> <div className="mt-16 gap-8">
<div> <div>
<h3 className="text-3xl font-semibold">User metrics</h3> <h3 className="text-3xl font-semibold">User metrics</h3>
@ -68,12 +67,12 @@ export default async function AdminStatsPage() {
<div className="mb-8 mt-4 grid flex-1 grid-cols-1 gap-4 md:grid-cols-2"> <div className="mb-8 mt-4 grid flex-1 grid-cols-1 gap-4 md:grid-cols-2">
<CardMetric <CardMetric
icon={File} icon={File}
title="Users with document in the last month" title="Users who sent one or more documents in the past month"
value={userWithAtLeastOneDocumentPerMonth} value={userWithAtLeastOneDocumentPerMonth}
/> />
<CardMetric <CardMetric
icon={File} icon={File}
title="Users with signed document in the last month" title="Users who sent one or more documents in the past month"
value={userWithAtLeastOneDocumentSignedPerMonth} value={userWithAtLeastOneDocumentSignedPerMonth}
/> />
</div> </div>
@ -83,7 +82,6 @@ export default async function AdminStatsPage() {
<h3 className="text-3xl font-semibold">Document metrics</h3> <h3 className="text-3xl font-semibold">Document metrics</h3>
<div className="mb-8 mt-4 grid flex-1 grid-cols-1 gap-4 md:grid-cols-2"> <div className="mb-8 mt-4 grid flex-1 grid-cols-1 gap-4 md:grid-cols-2">
{/* <CardMetric icon={File} title="Total Documents" value={docStats.ALL} /> */}
<CardMetric icon={FileEdit} title="Drafted Documents" value={docStats.DRAFT} /> <CardMetric icon={FileEdit} title="Drafted Documents" value={docStats.DRAFT} />
<CardMetric icon={FileClock} title="Pending Documents" value={docStats.PENDING} /> <CardMetric icon={FileClock} title="Pending Documents" value={docStats.PENDING} />
<CardMetric icon={FileCheck} title="Completed Documents" value={docStats.COMPLETED} /> <CardMetric icon={FileCheck} title="Completed Documents" value={docStats.COMPLETED} />
@ -109,15 +107,9 @@ export default async function AdminStatsPage() {
<div className="mt-16"> <div className="mt-16">
<h3 className="text-3xl font-semibold">User Charts</h3> <h3 className="text-3xl font-semibold">User Charts</h3>
<UserWithDocumentChart <UserWithDocumentChart data={MONTHLY_USERS_SIGNED} className="mb-8 mt-4" />
data={MONTHLY_USERS_SIGNED}
className="col-span-12 mb-8 mt-4 lg:col-span-6"
/>
<UserWithDocumentCummulativeChart <UserWithDocumentCummulativeChart data={MONTHLY_USERS_SIGNED} className="mb-8 mt-4" />
data={MONTHLY_USERS_SIGNED}
className="col-span-12 mb-8 mt-4 lg:col-span-6"
/>
</div> </div>
</div> </div>
); );

View File

@ -18,7 +18,7 @@ export const UserWithDocumentCummulativeChart = ({
.reverse() .reverse()
.map(({ month, cume_count: count, cume_signed_count: signed_count }) => { .map(({ month, cume_count: count, cume_signed_count: signed_count }) => {
return { return {
month: DateTime.fromFormat(month, 'yyyy-MM').toFormat('LLLL'), month: DateTime.fromFormat(month, 'yyyy-MM').toFormat('LLL'),
count: Number(count), count: Number(count),
signed_count: Number(signed_count), signed_count: Number(signed_count),
}; };

View File

@ -13,7 +13,7 @@ export type UserWithDocumentChartProps = {
export const UserWithDocumentChart = ({ className, data }: UserWithDocumentChartProps) => { export const UserWithDocumentChart = ({ className, data }: UserWithDocumentChartProps) => {
const formattedData = [...data].reverse().map(({ month, count, signed_count }) => { const formattedData = [...data].reverse().map(({ month, count, signed_count }) => {
return { return {
month: DateTime.fromFormat(month, 'yyyy-MM').toFormat('LLLL'), month: DateTime.fromFormat(month, 'yyyy-MM').toFormat('LLL'),
count: Number(count), count: Number(count),
signed_count: Number(signed_count), signed_count: Number(signed_count),
}; };